Add TODOs for breaking changes

This commit is contained in:
Kasper Seweryn 2022-05-01 17:06:01 +02:00 committed by Georg Krause
parent 4865bf77be
commit e6534a1554
4 changed files with 14 additions and 14 deletions

View File

@ -242,6 +242,7 @@ export default {
set (key, value) {
// otherwise reactivity doesn't trigger :/
this.values = cloneDeep(this.values)
// TODO (wvffle): Replace $set and $delete with reactive()
this.$set(this.values, key, value)
}
}

View File

@ -1,15 +1,7 @@
import Vue from 'vue'
import EmbedFrame from './EmbedFrame.vue'
import VuePlyr from 'vue-plyr'
import { createApp } from 'vue'
Vue.use(VuePlyr)
Vue.config.productionTip = false
/* eslint-disable no-new */
new Vue({
el: '#app',
components: { EmbedFrame },
render (h) {
return h('EmbedFrame')
}
})
const app = createApp(EmbedFrame)
app.use(VuePlyr)
app.mount('#app')

View File

@ -1,11 +1,11 @@
import { InitModule } from '~/types'
import { registerSW } from 'virtual:pwa-register'
import useLogger from '~/composables/useLogger'
import Vue from 'vue'
import { gettext } from '~/init/locale'
const logger = useLogger()
const { $pgettext } = Vue.prototype
const { $pgettext } = gettext
export const install: InitModule = ({ store }) => {
const updateSW = registerSW({

View File

@ -45,3 +45,10 @@ Promise.all(modules).finally(() => {
app.mount('#app')
logger.info('Everything loaded!')
})
// TODO (wvffle): Migrate to pinia
// TODO (wvffle): Remove global Vue (Only vuex files affected)
// TODO (wvffle): Remove shims-vue2.d.ts
// TODO (wvffle): Check for mixin merging: https://v3-migration.vuejs.org/breaking-changes/data-option.html#mixin-merge-behavior-change=
// TODO (wvffle): Use emits options: https://v3-migration.vuejs.org/breaking-changes/emits-option.html
// TODO (wvffle): Migrate to new v-model: https://v3-migration.vuejs.org/breaking-changes/v-model.html