diff --git a/front/src/components/admin/SettingsGroup.vue b/front/src/components/admin/SettingsGroup.vue index c6fabebe2..f227a3b84 100644 --- a/front/src/components/admin/SettingsGroup.vue +++ b/front/src/components/admin/SettingsGroup.vue @@ -242,6 +242,7 @@ export default { set (key, value) { // otherwise reactivity doesn't trigger :/ this.values = cloneDeep(this.values) + // TODO (wvffle): Replace $set and $delete with reactive() this.$set(this.values, key, value) } } diff --git a/front/src/embed.ts b/front/src/embed.ts index a6561ea51..49bfd6b1b 100644 --- a/front/src/embed.ts +++ b/front/src/embed.ts @@ -1,15 +1,7 @@ -import Vue from 'vue' import EmbedFrame from './EmbedFrame.vue' import VuePlyr from 'vue-plyr' +import { createApp } from 'vue' -Vue.use(VuePlyr) - -Vue.config.productionTip = false -/* eslint-disable no-new */ -new Vue({ - el: '#app', - components: { EmbedFrame }, - render (h) { - return h('EmbedFrame') - } -}) +const app = createApp(EmbedFrame) +app.use(VuePlyr) +app.mount('#app') diff --git a/front/src/init/serviceWorker.ts b/front/src/init/serviceWorker.ts index bf6833982..9bcd49d82 100644 --- a/front/src/init/serviceWorker.ts +++ b/front/src/init/serviceWorker.ts @@ -1,11 +1,11 @@ import { InitModule } from '~/types' import { registerSW } from 'virtual:pwa-register' import useLogger from '~/composables/useLogger' -import Vue from 'vue' +import { gettext } from '~/init/locale' const logger = useLogger() -const { $pgettext } = Vue.prototype +const { $pgettext } = gettext export const install: InitModule = ({ store }) => { const updateSW = registerSW({ diff --git a/front/src/main.ts b/front/src/main.ts index eff84ebdc..5567440d5 100644 --- a/front/src/main.ts +++ b/front/src/main.ts @@ -45,3 +45,10 @@ Promise.all(modules).finally(() => { app.mount('#app') logger.info('Everything loaded!') }) + +// TODO (wvffle): Migrate to pinia +// TODO (wvffle): Remove global Vue (Only vuex files affected) +// TODO (wvffle): Remove shims-vue2.d.ts +// TODO (wvffle): Check for mixin merging: https://v3-migration.vuejs.org/breaking-changes/data-option.html#mixin-merge-behavior-change= +// TODO (wvffle): Use emits options: https://v3-migration.vuejs.org/breaking-changes/emits-option.html +// TODO (wvffle): Migrate to new v-model: https://v3-migration.vuejs.org/breaking-changes/v-model.html