MirrorMirror
/
funkwhale
mirror of https://dev.funkwhale.audio/funkwhale/funkwhale.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Adds sanity check to prevent uncontrolled exception from untagged imported tracks (!1382)

This commit is contained in:
Marcos Peña 2021-10-17 10:41:03 +00:00 committed by JuniorJPDJ
parent ae56890fa3
commit b942ed7a62
2 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
api/funkwhale_api/music/metadata.py
View File

@ -357,6 +357,8 @@ class Metadata(Mapping):
self._file = kind(filething) self._file = kind(filething)
if self._file is None: if self._file is None:
raise ValueError("Cannot parse metadata from {}".format(filething)) raise ValueError("Cannot parse metadata from {}".format(filething))
if len(self._file) == 0:
raise ValueError("No tags found in {}".format(filething))
self.fallback = self.load_fallback(filething, self._file) self.fallback = self.load_fallback(filething, self._file)
ft = self.get_file_type(self._file) ft = self.get_file_type(self._file)
try: try:

1
changes/changelog.d/1275.enhancement Normal file
View File

@ -0,0 +1 @@
Prevents an uncontrolled exception when uploading a file without tags, and prints user friendly message (1275)