Merge branch '398-favorites' into 'develop'

Resolve "Track already in favorites do not appear in player"

Closes #398

See merge request funkwhale/funkwhale!353

changes/changelog.d/398.bugfix

@@ -0,0 +1 @@
+Fixed favorited status of tracks not appearing in interface (#398)

front/src/store/favorites.js

@@ -57,13 +57,19 @@ export default {
       // will fetch favorites by batches from API to have them locally
       let params = {
         user: rootState.auth.profile.id,
-        page_size: 50
+        page_size: 50,
+        ordering: '-creation_date'
       }
-      url = url || 'favorites/tracks/'
+      let promise
-      return axios.get(url, {params: params}).then((response) => {
+      if (url) {
+        promise = axios.get(url)
+      } else {
+        promise = axios.get('favorites/tracks/', {params: params})
+      }
+      return promise.then((response) => {
         logger.default.info('Fetched a batch of ' + response.data.results.length + ' favorites')
         response.data.results.forEach(result => {
-          commit('track', {id: result.track, value: true})
+          commit('track', {id: result.track.id, value: true})
         })
         if (response.data.next) {
           dispatch('fetch', response.data.next)