MirrorMirror
/
funkwhale
mirror of https://dev.funkwhale.audio/funkwhale/funkwhale.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(tests): replace serialize_upload with UploadSerializer 

Part-of: <https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/2757>
This commit is contained in:
wvffle 2024-02-20 16:41:34 +00:00
parent 7957661573
commit 367ba84f13
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
api/funkwhale_api/music/serializers.py
View File

@ -226,7 +226,7 @@ class TrackAlbumSerializer(serializers.ModelSerializer):
) )
class UploadSerializer(serializers.Serializer): class TrackUploadSerializer(serializers.Serializer):
uuid = serializers.UUIDField() uuid = serializers.UUIDField()
listen_url = serializers.URLField() listen_url = serializers.URLField()
size = serializers.IntegerField() size = serializers.IntegerField()
@ -284,11 +284,11 @@ class TrackSerializer(OptionalDescriptionMixin, serializers.Serializer):
return obj.listen_url return obj.listen_url
# @extend_schema_field({"type": "array", "items": {"type": "object"}}) # @extend_schema_field({"type": "array", "items": {"type": "object"}})
@extend_schema_field(UploadSerializer(many=True)) @extend_schema_field(TrackUploadSerializer(many=True))
def get_uploads(self, obj): def get_uploads(self, obj):
uploads = getattr(obj, "playable_uploads", []) uploads = getattr(obj, "playable_uploads", [])
# we put local uploads first # we put local uploads first
uploads = [UploadSerializer(u).data for u in sort_uploads_for_listen(uploads)] uploads = [TrackUploadSerializer(u).data for u in sort_uploads_for_listen(uploads)]
uploads = sorted(uploads, key=lambda u: u["is_local"], reverse=True) uploads = sorted(uploads, key=lambda u: u["is_local"], reverse=True)
return list(uploads) return list(uploads)

6
api/tests/music/test_serializers.py
View File

@ -245,7 +245,7 @@ def test_track_serializer(factories, to_api_date):
"title": track.title, "title": track.title,
"position": track.position, "position": track.position,
"disc_number": track.disc_number, "disc_number": track.disc_number,
"uploads": [serializers.serialize_upload(upload)], "uploads": [serializers.TrackUploadSerializer(upload).data],
"creation_date": to_api_date(track.creation_date), "creation_date": to_api_date(track.creation_date),
"listen_url": track.listen_url, "listen_url": track.listen_url,
"license": upload.track.license.code, "license": upload.track.license.code,
@ -373,7 +373,7 @@ def test_manage_upload_action_publish(factories, mocker):
m.assert_any_call(tasks.process_upload.delay, upload_id=draft.pk) m.assert_any_call(tasks.process_upload.delay, upload_id=draft.pk)
def test_serialize_upload(factories): def test_track_upload_serializer(factories):
upload = factories["music.Upload"]() upload = factories["music.Upload"]()
expected = { expected = {
@ -387,7 +387,7 @@ def test_serialize_upload(factories):
"is_local": False, "is_local": False,
} }
data = serializers.serialize_upload(upload) data = serializers.TrackUploadSerializer(upload).data
assert data == expected assert data == expected