diff --git a/api/funkwhale_api/music/serializers.py b/api/funkwhale_api/music/serializers.py index 3e183b907..d0e08a0a0 100644 --- a/api/funkwhale_api/music/serializers.py +++ b/api/funkwhale_api/music/serializers.py @@ -226,7 +226,7 @@ class TrackAlbumSerializer(serializers.ModelSerializer): ) -class UploadSerializer(serializers.Serializer): +class TrackUploadSerializer(serializers.Serializer): uuid = serializers.UUIDField() listen_url = serializers.URLField() size = serializers.IntegerField() @@ -284,11 +284,11 @@ class TrackSerializer(OptionalDescriptionMixin, serializers.Serializer): return obj.listen_url # @extend_schema_field({"type": "array", "items": {"type": "object"}}) - @extend_schema_field(UploadSerializer(many=True)) + @extend_schema_field(TrackUploadSerializer(many=True)) def get_uploads(self, obj): uploads = getattr(obj, "playable_uploads", []) # we put local uploads first - uploads = [UploadSerializer(u).data for u in sort_uploads_for_listen(uploads)] + uploads = [TrackUploadSerializer(u).data for u in sort_uploads_for_listen(uploads)] uploads = sorted(uploads, key=lambda u: u["is_local"], reverse=True) return list(uploads) diff --git a/api/tests/music/test_serializers.py b/api/tests/music/test_serializers.py index c5cc40464..7df47e537 100644 --- a/api/tests/music/test_serializers.py +++ b/api/tests/music/test_serializers.py @@ -245,7 +245,7 @@ def test_track_serializer(factories, to_api_date): "title": track.title, "position": track.position, "disc_number": track.disc_number, - "uploads": [serializers.serialize_upload(upload)], + "uploads": [serializers.TrackUploadSerializer(upload).data], "creation_date": to_api_date(track.creation_date), "listen_url": track.listen_url, "license": upload.track.license.code, @@ -373,7 +373,7 @@ def test_manage_upload_action_publish(factories, mocker): m.assert_any_call(tasks.process_upload.delay, upload_id=draft.pk) -def test_serialize_upload(factories): +def test_track_upload_serializer(factories): upload = factories["music.Upload"]() expected = { @@ -387,7 +387,7 @@ def test_serialize_upload(factories): "is_local": False, } - data = serializers.serialize_upload(upload) + data = serializers.TrackUploadSerializer(upload).data assert data == expected