Resolve a bunch of non-virtual destructor warnings

This commit is contained in:
Brian Cox 2016-04-14 21:45:46 -07:00
parent a3bd6aec7d
commit f47e5e7a9d
12 changed files with 50 additions and 23 deletions

View File

@ -117,9 +117,8 @@ class iCodeConverter
protected: protected:
iCodeConverter() iCodeConverter() {}
{ virtual ~iCodeConverter() {}
};
private: private:
@ -170,7 +169,7 @@ class cIconvConverter : public iCodeConverter
virtual int Convert( ntdbs_t, size_t, const_ntmbs_t, size_t ); virtual int Convert( ntdbs_t, size_t, const_ntmbs_t, size_t );
cIconvConverter(); cIconvConverter();
~cIconvConverter(); virtual ~cIconvConverter();
private: private:
void Init(); void Init();
@ -189,7 +188,7 @@ class cDoubleIconvConverter : public iCodeConverter
virtual int Convert( ntdbs_t, size_t, const_ntmbs_t, size_t ); virtual int Convert( ntdbs_t, size_t, const_ntmbs_t, size_t );
cDoubleIconvConverter(); cDoubleIconvConverter();
~cDoubleIconvConverter(); virtual ~cDoubleIconvConverter();
private: private:
@ -221,6 +220,8 @@ class cWcharIs32BitUcs2Converterer : public iCodeConverter
public: public:
virtual int Convert( ntmbs_t, size_t, const_ntdbs_t, size_t ); virtual int Convert( ntmbs_t, size_t, const_ntdbs_t, size_t );
virtual int Convert( ntdbs_t, size_t, const_ntmbs_t, size_t ); virtual int Convert( ntdbs_t, size_t, const_ntmbs_t, size_t );
virtual ~cWcharIs32BitUcs2Converterer() {}
}; };
#endif // WCHAR_IS_32_BITS #endif // WCHAR_IS_32_BITS
@ -239,6 +240,8 @@ class cWcharIs16BitUcs2Converterer : public iCodeConverter
public: public:
virtual int Convert( ntmbs_t, size_t, const_ntdbs_t, size_t ); virtual int Convert( ntmbs_t, size_t, const_ntdbs_t, size_t );
virtual int Convert( ntdbs_t, size_t, const_ntmbs_t, size_t ); virtual int Convert( ntdbs_t, size_t, const_ntmbs_t, size_t );
virtual ~cWcharIs16BitUcs2Converterer() {}
}; };
#endif // WCHAR_IS_16_BITS #endif // WCHAR_IS_16_BITS
@ -250,6 +253,8 @@ class cGoodEnoughConverterer : public iCodeConverter
public: public:
virtual int Convert( ntmbs_t, size_t, const_ntdbs_t, size_t ); virtual int Convert( ntmbs_t, size_t, const_ntdbs_t, size_t );
virtual int Convert( ntdbs_t, size_t, const_ntmbs_t, size_t ); virtual int Convert( ntdbs_t, size_t, const_ntmbs_t, size_t );
virtual ~cGoodEnoughConverterer() {}
}; };

View File

@ -82,9 +82,7 @@ public:
virtual void Write(iSerializer* pSerializer) const = 0; // throw (eSerializer, eArchive) virtual void Write(iSerializer* pSerializer) const = 0; // throw (eSerializer, eArchive)
// objects implement these methods to read and write themselves to a serializer. // objects implement these methods to read and write themselves to a serializer.
#ifdef _SUNPRO virtual ~iSerializable() {}
~iSerializable();
#endif
}; };
class iTypedSerializable : public iTyped, public iSerializable class iTypedSerializable : public iTyped, public iSerializable
@ -101,9 +99,7 @@ public:
static int16 MajorVersion(int32 version) { return (int16)((uint32)version >> 16); } static int16 MajorVersion(int32 version) { return (int16)((uint32)version >> 16); }
static int16 MinorVersion(int32 version) { return (int16)version; } static int16 MinorVersion(int32 version) { return (int16)version; }
#ifdef _SUNPRO virtual ~iTypedSerializable() {}
~iTypedSerializable();
#endif
}; };
////////////////////////////// //////////////////////////////

View File

@ -155,6 +155,8 @@ public:
E_OUTPUT_STREAM_FORMAT = 706, E_OUTPUT_STREAM_FORMAT = 706,
E_NUMITEMS E_NUMITEMS
}; };
virtual ~iSerializer() {}
}; };

View File

@ -88,6 +88,9 @@ private:
// //
virtual int GetMax() { return LIMIT_MAX; }; virtual int GetMax() { return LIMIT_MAX; };
virtual int GetMin() { return LIMIT_MIN; }; virtual int GetMin() { return LIMIT_MIN; };
public:
virtual ~cInterpretInt() {}
}; };
/////////////////////////////////////////////// ///////////////////////////////////////////////
@ -104,6 +107,9 @@ private:
virtual int GetMax() { return LIMIT_MAX; }; virtual int GetMax() { return LIMIT_MAX; };
virtual int GetMin() { return LIMIT_MIN; }; virtual int GetMin() { return LIMIT_MIN; };
public:
virtual ~cSeverityLimits() {}
}; };
/////////////////////////////////////////////// ///////////////////////////////////////////////
@ -120,6 +126,9 @@ private:
virtual int GetMax() { return LIMIT_MAX; }; virtual int GetMax() { return LIMIT_MAX; };
virtual int GetMin() { return LIMIT_MIN; }; virtual int GetMin() { return LIMIT_MIN; };
public:
virtual ~cRecurseDepthLimits() {}
}; };
#endif //__TWLIMITS_H #endif //__TWLIMITS_H

View File

@ -62,9 +62,7 @@ public:
// (b) returning that object in their implementation of GetType() // (b) returning that object in their implementation of GetType()
// You can use the macros below to simplify the process // You can use the macros below to simplify the process
#ifdef _SUNPRO virtual ~iTyped() {}
~iTyped();
#endif
}; };
////////////////////////////////////////////// //////////////////////////////////////////////

View File

@ -47,6 +47,7 @@ class iFCONameInfo
public: public:
virtual bool IsCaseSensitive() const = 0; virtual bool IsCaseSensitive() const = 0;
virtual TCHAR GetDelimitingChar() const = 0; virtual TCHAR GetDelimitingChar() const = 0;
virtual ~iFCONameInfo() {}
}; };

View File

@ -82,6 +82,8 @@ public:
virtual bool DisplayStringToFCOName( const TSTRING& str, cFCOName& name ) const = 0; virtual bool DisplayStringToFCOName( const TSTRING& str, cFCOName& name ) const = 0;
// this function converts strings from FCONameToDisplayString back into an fconame // this function converts strings from FCONameToDisplayString back into an fconame
// returns false if can't convert. // returns false if can't convert.
virtual ~iFCONameTranslator() {}
}; };
#endif //__FCONAMETRANSLATOR_H #endif //__FCONAMETRANSLATOR_H

View File

@ -56,6 +56,8 @@ class iFCOSpecHelper;
class iFCOSpec : public iSerRefCountObj class iFCOSpec : public iSerRefCountObj
{ {
public: public:
virtual ~iFCOSpec() {}
virtual const TSTRING& GetName() const = 0; virtual const TSTRING& GetName() const = 0;
// returns the name of this FCOSpec // returns the name of this FCOSpec
virtual void SetName(const TSTRING& name) = 0; virtual void SetName(const TSTRING& name) = 0;
@ -120,6 +122,7 @@ public:
class iFCOSpecMask class iFCOSpecMask
{ {
public: public:
virtual ~iFCOSpecMask() {}
virtual const TSTRING& GetName() const = 0; virtual const TSTRING& GetName() const = 0;
// return the name of this mask // return the name of this mask

View File

@ -59,6 +59,8 @@ public:
{ {
return _T('/'); return _T('/');
} }
virtual ~cUnixNameInfo() {}
}; };

View File

@ -58,6 +58,8 @@ public:
virtual TSTRING ToStringAPI( const cFCOName& name ) const; virtual TSTRING ToStringAPI( const cFCOName& name ) const;
virtual TSTRING ToStringDisplay( const cFCOName& name, bool bUnique = false ) const; virtual TSTRING ToStringDisplay( const cFCOName& name, bool bUnique = false ) const;
virtual bool DisplayStringToFCOName( const TSTRING& str, cFCOName& name ) const; virtual bool DisplayStringToFCOName( const TSTRING& str, cFCOName& name ) const;
virtual ~cFSNameTranslator() {}
}; };
#endif //__FSNAMETRANSLATOR_H #endif //__FSNAMETRANSLATOR_H

View File

@ -151,6 +151,7 @@ public:
class iMimeEncoding class iMimeEncoding
{ {
public: public:
virtual ~iMimeEncoding() {}
virtual virtual
std::string std::string
@ -174,6 +175,8 @@ class iMimeEncoding
class cBase64Encoding : public iMimeEncoding class cBase64Encoding : public iMimeEncoding
{ {
public: public:
virtual ~cBase64Encoding() {}
virtual virtual
std::string std::string
Encode( const std::string& sIn, Encode( const std::string& sIn,
@ -192,6 +195,8 @@ class cBase64Encoding : public iMimeEncoding
class cQuotedPrintableEncoding : public iMimeEncoding class cQuotedPrintableEncoding : public iMimeEncoding
{ {
public: public:
virtual ~cQuotedPrintableEncoding() {}
virtual virtual
std::string std::string
Encode( const std::string& sIn, Encode( const std::string& sIn,

View File

@ -121,6 +121,8 @@ public:
// Returns a TSTRING that describes specific usage for a derived mode. // Returns a TSTRING that describes specific usage for a derived mode.
virtual cTWPrintCmdLine::CmdLineArgs GetModeID() = 0; virtual cTWPrintCmdLine::CmdLineArgs GetModeID() = 0;
virtual void SetConfigFile( TSTRING configFilePath ) = 0; virtual void SetConfigFile( TSTRING configFilePath ) = 0;
virtual ~iTWMode() {}
}; };
/////////////////////////////////////////////////////////////////////////////// ///////////////////////////////////////////////////////////////////////////////