colin
/
sharded-gotify
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't use id provided from POST /message api

This commit is contained in:
Jannis Mattheis 2020-06-23 17:01:28 +02:00
parent 92a468bf74
commit a9249bbd28
2 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
api/message.go
View File

@ -367,6 +367,7 @@ func (a *MessageAPI) CreateMessage(ctx *gin.Context) {
message.Title = application.Name message.Title = application.Name
} }
message.Date = timeNow() message.Date = timeNow()
message.ID = 0
msgInternal := toInternalMessage(&message) msgInternal := toInternalMessage(&message)
if success := successOrAbort(ctx, 500, a.DB.CreateMessage(msgInternal)); !success { if success := successOrAbort(ctx, 500, a.DB.CreateMessage(msgInternal)); !success {
return return

17
api/message_test.go
View File

@ -408,6 +408,23 @@ func (s *MessageSuite) Test_CreateMessage_WithBlankTitle() {
assert.Equal(s.T(), 200, s.recorder.Code) assert.Equal(s.T(), 200, s.recorder.Code)
assert.Equal(s.T(), "mymessage", msgs[0].Message) assert.Equal(s.T(), "mymessage", msgs[0].Message)
} }
func (s *MessageSuite) Test_CreateMessage_IgnoreID() {
auth.RegisterAuthentication(s.ctx, nil, 4, "app-token")
s.db.User(4).AppWithTokenAndName(8, "app-token", "Application name")
s.ctx.Request = httptest.NewRequest("POST", "/message", strings.NewReader(`{"message": "mymessage", "id": 1337}`))
s.ctx.Request.Header.Set("Content-Type", "application/json")
s.a.CreateMessage(s.ctx)
msgs, err := s.db.GetMessagesByApplication(8)
assert.NoError(s.T(), err)
assert.Len(s.T(), msgs, 1)
assert.NotEqual(s.T(), msgs[0].ID, uint(1337))
assert.Equal(s.T(), 200, s.recorder.Code)
}
func (s *MessageSuite) Test_CreateMessage_WithExtras() { func (s *MessageSuite) Test_CreateMessage_WithExtras() {
auth.RegisterAuthentication(s.ctx, nil, 4, "app-token") auth.RegisterAuthentication(s.ctx, nil, 4, "app-token")
s.db.User(4).AppWithTokenAndName(8, "app-token", "Application name") s.db.User(4).AppWithTokenAndName(8, "app-token", "Application name")