fix: message overflow state preservation from previous messages
Using index is bad practice: https://react.dev/learn/rendering-lists#rules-of-keys We don't recalculate the overflow state once the message is overflown. When using the index as key, then when a new message is added at the top of the array at index 0. The overflow state from the previous message at index 0 is kept. The overflow state shouldn't be reused.
This commit is contained in:
parent
f1bf24c10f
commit
9ff713c537
|
|
@ -33,9 +33,9 @@ const Messages = observer(() => {
|
||||||
}
|
}
|
||||||
}, [appId]);
|
}, [appId]);
|
||||||
|
|
||||||
const renderMessage = (index: number, message: IMessage) => (
|
const renderMessage = (_index: number, message: IMessage) => (
|
||||||
<Message
|
<Message
|
||||||
key={index}
|
key={message.id}
|
||||||
fDelete={deleteMessage(message)}
|
fDelete={deleteMessage(message)}
|
||||||
onExpand={(expanded) => (expandedState.current[message.id] = expanded)}
|
onExpand={(expanded) => (expandedState.current[message.id] = expanded)}
|
||||||
title={message.title}
|
title={message.title}
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue