From 26f36442fd5fe01437f0a23958aa9d872d0079f8 Mon Sep 17 00:00:00 2001 From: Jannis Mattheis Date: Sun, 15 Apr 2018 16:39:30 +0200 Subject: [PATCH] Only shift message when messages were fetched at least one time --- ui/src/stores/MessageStore.js | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/ui/src/stores/MessageStore.js b/ui/src/stores/MessageStore.js index debc470..7a25046 100644 --- a/ui/src/stores/MessageStore.js +++ b/ui/src/stores/MessageStore.js @@ -56,12 +56,14 @@ class MessageStore extends EventEmitter { this.loading = false; this.emit('change'); } else if (data.type === 'ONE_MESSAGE') { - this.createIfNotExist(payload.appid); - this.createIfNotExist(-1); - this.appToMessages[payload.appid].messages.unshift(payload); - this.appToMessages[-1].messages.unshift(payload); - this.reset = 0; - this.resetOnAll = 0; + if (this.exists(payload.appid)) { + this.appToMessages[payload.appid].messages.unshift(payload); + this.reset = 0; + } + if (this.exists(-1)) { + this.appToMessages[-1].messages.unshift(payload); + this.resetOnAll = 0; + } this.updateApps(); this.emit('change'); } else if (data.type === 'DELETE_MESSAGE') { @@ -100,12 +102,6 @@ class MessageStore extends EventEmitter { appMessages.messages.forEach((message) => message.image = appToUrl[message.appid]); }); }; - - createIfNotExist(id) { - if (!(id in this.appToMessages)) { - this.appToMessages[id] = this.get(id); - } - } } const store = new MessageStore();