47b3b1ae0a
Resolve "Upload problem due to a formatting error in the date tag" Closes #718, #583, #501, #252, #544 (yes, that's a lot :D) So, this MR changes the way we parse audio metadata and handle validation for this data: - There is now a strict and explicit separation between the retrieve step (extracting raw metadata value from files), and the validation step (ensure the raw metadata is actually valid, convert it to our internal types, etc.) - The date parsing issue from #718 should be solved (and Funkwhale should not crash anymore against invalid dates, skipping those instead) - We are now ready to deal with multiple artists at the metadata parsing level (cf !515). It should also be easier to exclude featuring artists now (cf #736), but it's not implemented here - When invalid metadata makes the import fail, we store the errors on the upload so we can display those to the user - Tables that list uploads in the Web UI leverage this new data to display more detailed errors and advices, as shown on the screenshot below ## Link to the detail modal  ## Import error detail   As you can see, we display the type of errors, the failing tags and the actual error, as well as some link to the documentation, support forum and some debug info you can easily copy-paste to get help. See merge request funkwhale/funkwhale!703 |
||
|---|---|---|
| .gitlab | ||
| api | ||
| changes | ||
| demo | ||
| deploy | ||
| docker | ||
| docs | ||
| front | ||
| scripts | ||
| .dockerignore | ||
| .editorconfig | ||
| .env.dev | ||
| .gitattributes | ||
| .gitignore | ||
| .gitlab-ci.yml | ||
| CHANGELOG | ||
| CONTRIBUTING.rst | ||
| CONTRIBUTORS.txt | ||
| LICENSE | ||
| README.rst | ||
| TRANSLATORS.rst | ||
| dev.yml | ||
| pyproject.toml | ||
README.rst
Funkwhale ============= .. image:: ./front/src/assets/logo/logo-full-500.png :alt: Funkwhale logo :target: https://funkwhale.audio A self-hosted tribute to Grooveshark.com. LICENSE: AGPL3 Getting help ------------ We offer various Matrix.org rooms to discuss about Funkwhale: - `#funkwhale:matrix.org <https://matrix.to/#/#funkwhale:matrix.org>`_ for general questions about funkwhale - `#funkwhale-dev:matrix.org <https://matrix.to/#/#funkwhale-dev:matrix.org>`_ for development-focused discussion Please join those rooms if you have any questions! You can also contact `@funkwhale@mastodon.eliotberriot.com <https://mastodon.eliotberriot.com/@funkwhale>`_ on the fediverse. Contribute ---------- Contribution guidelines as well as development installation instructions are outlined in `CONTRIBUTING <CONTRIBUTING.rst>`_. Translate ^^^^^^^^^ Translators willing to help can refer to `TRANSLATORS <TRANSLATORS.rst>`_ for instructions. Code of Conduct --------------- `Our Code of Conduct <https://funkwhale.audio/code-of-conduct/>`_ applies to all the community spaces, including our GitLab instance. Please, take a moment to read it.