Commit Graph

2624 Commits

Author SHA1 Message Date
Eliot Berriot 4d55c844f4 Merge branch 'nodeinfo-autofetch' into 'develop'
Nodeinfo autofetch

See merge request funkwhale/funkwhale!714
2019-04-11 11:29:09 +02:00
Eliot Berriot 5e3cc99f20
See #689: fetch nodeinfo when seing a domain for the first time 2019-04-11 11:25:55 +02:00
Eliot Berriot 84e2f0af9f
See #689: added a task to refresh nodeinfo data on known domain periodically 2019-04-11 11:14:27 +02:00
Eliot Berriot b45cada689 Merge branch 'attribute-artist' into 'develop'
Attribute artist

See merge request funkwhale/funkwhale!713
2019-04-11 10:17:10 +02:00
Eliot Berriot 4e44e4e4b6 Attribute artist 2019-04-11 10:17:10 +02:00
Eliot Berriot 8687a64873 Merge branch 'license-metadata-update' into 'develop'
License metadata update

See merge request funkwhale/funkwhale!712
2019-04-09 11:18:47 +02:00
Eliot Berriot 0ce51d25d4
Can now edit track copyright information 2019-04-09 11:15:43 +02:00
Eliot Berriot 45142bf24b
Added better dropdown for choosing licenses 2019-04-09 11:15:43 +02:00
Eliot Berriot a3ad476c88
More configurable pagination 2019-04-09 11:15:43 +02:00
Eliot Berriot b36b03383e
Fixed broken metadata update on track without license 2019-04-09 09:34:59 +02:00
Eliot Berriot e8c4deaa10
Removed obsolete information about soundcloud/youtube import 2019-04-08 15:17:31 +02:00
Eliot Berriot e3bba6fe01 Merge branch '791-user-page-width' into 'develop'
Fix #791: overflowing input on account detail page

Closes #791

See merge request funkwhale/funkwhale!711
2019-04-08 12:32:36 +02:00
Eliot Berriot ae626a5c0a
Fix #791: overflowing input on account detail page 2019-04-08 12:28:00 +02:00
Eliot Berriot 8eb0022842 Merge branch '795-album-cover' into 'develop'
Fix#795: cover not showing in queue/player when playing tracks from "albums" tab

Closes #795

See merge request funkwhale/funkwhale!710
2019-04-08 11:43:04 +02:00
Eliot Berriot a4a112e081 Fix#795: cover not showing in queue/player when playing tracks from "albums" tab 2019-04-08 11:43:04 +02:00
Eliot Berriot 0488eddf32 Merge branch 'jdll-workshop-docs' into 'master'
Fixed some typo/wording in the documentation

See merge request funkwhale/funkwhale!709
2019-04-08 11:14:44 +02:00
Eliot Berriot e9cfc4d279
Fixed some typo/wording in the documentation 2019-04-08 11:11:35 +02:00
Eliot Berriot eb1f7e5569 Merge branch 'wip/issue/359/title-display-track-info' into 'develop'
Update document title to display track info.

Closes #359

See merge request funkwhale/funkwhale!702
2019-04-08 10:01:21 +02:00
Ben Finney f24d2549ae Update document title to display track info. 2019-04-08 10:01:21 +02:00
Eliot Berriot f281189f47 Merge branch '781-remove-tracks-not-found' into 'develop'
Fix #781: Added a `check_inplace_files` management command to remove purge the...

Closes #781

See merge request funkwhale/funkwhale!707
2019-04-05 18:58:17 +02:00
Eliot Berriot 6649d0720d
Fix #781: Added a `check_inplace_files` management command to remove purge the database from references to in-place imported files that don't exist on disk anymore 2019-04-05 18:55:00 +02:00
Eliot Berriot da6b3400a0
Better permissions on .env file, added a few missing env vars in mono-container install 2019-04-05 17:48:04 +02:00
Eliot Berriot 156d9c813a Merge branch '787-broken-follow' into 'develop'
Fix #787: federation issue due to missing error handling

Closes #787

See merge request funkwhale/funkwhale!706
2019-04-05 16:25:37 +02:00
Eliot Berriot f5a6a40d7f
Fix #787: federation issue due to missing error handling 2019-04-05 16:22:32 +02:00
Eliot Berriot 9bf1c0cde0 Merge branch '788-album-error-handling' into 'develop'
Fix #788: fixed crashing import with empty album artist

Closes #788

See merge request funkwhale/funkwhale!705
2019-04-05 15:44:05 +02:00
Eliot Berriot 2a82367667
Fix #788: fixed crashing import with empty album artist 2019-04-05 15:41:28 +02:00
Eliot Berriot 48ce87d25f Merge branch '783-migration-error' into 'develop'
Fix #783: migration issue on develop

Closes #783

See merge request funkwhale/funkwhale!704
2019-04-04 16:08:11 +02:00
Eliot Berriot 47b3b1ae0a Merge branch '718-error-handling' into 'develop'
Resolve "Upload problem due to a formatting error in the date tag"

Closes #718, #583, #501, #252, #544 (yes, that's a lot :D)

So, this MR changes the way we parse audio metadata and handle validation for this data:

- There is now a strict and explicit separation between the retrieve step (extracting raw metadata value from files), and the validation step (ensure the raw metadata is actually valid, convert it to our internal types, etc.)
- The date parsing issue from #718 should be solved (and Funkwhale should not crash anymore against invalid dates, skipping those instead)
- We are now ready to deal with multiple artists at the metadata parsing level (cf !515). It should also be easier to exclude featuring artists now (cf #736), but it's not implemented here
- When invalid metadata makes the import fail, we store the errors on the upload so we can display those to the user
- Tables that list uploads in the Web UI leverage this new data to display more detailed errors and advices, as shown on the screenshot below

## Link to the detail modal

![image](/uploads/20eab969c7cb46fe68a402d8a509815d/image.png)

## Import error detail

![image](/uploads/7cebae6dd05f437345fa38340e8675c7/image.png)

![image](/uploads/946c8ae59cd89fe29e701700fbd5063f/image.png)

As you can see, we display the type of errors, the failing tags and the actual error, as well as some link to the documentation, support forum and some debug info you can easily copy-paste to get help.

See merge request funkwhale/funkwhale!703
2019-04-04 16:07:44 +02:00
Eliot Berriot 05f0129025 Better error handling on display for import errors (#718, #583, #501, #252, #544) 2019-04-04 16:07:43 +02:00
Eliot Berriot 63c3c22534
Fix #783: migration issue on develop 2019-04-04 16:05:34 +02:00
Eliot Berriot 28a5c918cf Merge branch 'eliotberriot-master-patch-07259' into 'master'
Added missing sudo in upgrade instructions

See merge request funkwhale/funkwhale!701
2019-04-01 19:23:07 +02:00
Eliot Berriot 3a4c927820 Added missing sudo in upgrade instructions 2019-04-01 19:20:17 +02:00
Eliot Berriot 524794c81f Merge branch 'tag-data' into 'master'
Added a small json file in documentation to get releases info

See merge request funkwhale/funkwhale!700
2019-04-01 11:41:18 +02:00
Eliot Berriot cf51d37a47
Added a small json file in documentation to get releases info 2019-04-01 11:36:13 +02:00
Eliot Berriot 3a95957dfe Merge branch 'eliotberriot-master-patch-38666' into 'master'
Added missing library_id parameter on in-place import documentation

See merge request funkwhale/funkwhale!699
2019-04-01 09:50:15 +02:00
Eliot Berriot 537f18cf08 Added missing library_id parameter on in-place import documentation 2019-04-01 09:45:54 +02:00
Eliot Berriot 7bb0fa2e64 Merge branch '777-library-pruning' into 'develop'
Fix #777: Added a prune_library management command to remove obsolete metadata

Closes #777

See merge request funkwhale/funkwhale!698
2019-03-27 17:07:23 +01:00
Eliot Berriot 5916a1ba99
Fix #777: Added a prune_library management command to remove obsolete metadata 2019-03-27 17:04:10 +01:00
Eliot Berriot 96010917fb Merge branch 'migration-to-loomio' into 'develop'
Updated forum urls

See merge request funkwhale/funkwhale!697
2019-03-27 13:49:02 +01:00
Eliot Berriot 8a5c85a823 Merge branch 'discard-unhandled-activities' into 'develop'
Fix #776: Don't store unhandled ActivityPub messages in database

Closes #776

See merge request funkwhale/funkwhale!696
2019-03-27 13:46:08 +01:00
Eliot Berriot 9e8c223021
Updated forum urls 2019-03-27 13:45:52 +01:00
Eliot Berriot 583a6ddf08 Merge branch '740-skipped-track-position' into 'develop'
Fix #740: Do not consider tracks as duplicates during import if they have different positions

Closes #740

See merge request funkwhale/funkwhale!695
2019-03-27 12:58:29 +01:00
Eliot Berriot ca7b39c692
Fix #740: Do not consider tracks as duplicates during import if they have different positions 2019-03-27 12:54:29 +01:00
Eliot Berriot 46f1d96206
Fix #776: Don't store unhandled ActivityPub messages in database 2019-03-27 12:53:35 +01:00
Eliot Berriot b9b1e1e26a Merge branch '772-skipped-release' into 'develop'
Fix #772: Prevent skipping on file import if album_mbid is different

Closes #772

See merge request funkwhale/funkwhale!694
2019-03-27 12:16:55 +01:00
Eliot Berriot 31227b8641
Fix #772: Prevent skipping on file import if album_mbid is different 2019-03-27 12:13:25 +01:00
Eliot Berriot 659c355ad8
API doc introduction 2019-03-26 17:21:44 +01:00
Eliot Berriot f8e30736a2 Merge branch 'more-api-docs-again' into 'master'
More api docs again

See merge request funkwhale/funkwhale!693
2019-03-26 17:13:08 +01:00
Eliot Berriot dcb9ca04a1
Documented /users and /auth endpoints 2019-03-26 15:38:14 +01:00
Eliot Berriot 26e8281733 Merge branch 'more-api-docs' into 'master'
More api docs

See merge request funkwhale/funkwhale!692
2019-03-26 15:04:36 +01:00