From dcb664162c18e4c1407b72c6d4a178460e3ac006 Mon Sep 17 00:00:00 2001 From: ArneBo Date: Tue, 8 Apr 2025 05:39:38 +0200 Subject: [PATCH] fix(front): consistent pixel perfect header with description modal on all detail pages --- .../components/audio/ArtistCreditLabel.vue | 1 + .../src/components/audio/ChannelSerieCard.vue | 123 ++-- front/src/components/audio/PlayButton.vue | 7 +- .../src/components/audio/track/MobileRow.vue | 4 +- .../components/common/RenderedDescription.vue | 43 +- front/src/components/library/AlbumBase.vue | 282 ++++---- .../src/components/library/AlbumDropdown.vue | 8 +- front/src/components/library/ArtistBase.vue | 410 ++++++----- front/src/components/library/TrackDetail.vue | 4 +- .../components/playlists/PlaylistDropdown.vue | 6 +- front/src/components/ui/Header.vue | 9 +- front/src/components/ui/button/Options.vue | 4 +- front/src/locales/en_GB.json | 78 +++ front/src/locales/en_US.json | 138 +++- front/src/style/globals/_channels.scss | 4 +- front/src/views/auth/ProfileBase.vue | 61 +- front/src/views/channels/DetailBase.vue | 647 +++++++++--------- front/src/views/playlists/Detail.vue | 279 ++++---- 18 files changed, 1223 insertions(+), 885 deletions(-) diff --git a/front/src/components/audio/ArtistCreditLabel.vue b/front/src/components/audio/ArtistCreditLabel.vue index 0043baf71..f33293054 100644 --- a/front/src/components/audio/ArtistCreditLabel.vue +++ b/front/src/components/audio/ArtistCreditLabel.vue @@ -66,5 +66,6 @@ const getRoute = (ac: ArtistCredit) => { diff --git a/front/src/components/audio/ChannelSerieCard.vue b/front/src/components/audio/ChannelSerieCard.vue index 3de332eeb..92b8083a0 100644 --- a/front/src/components/audio/ChannelSerieCard.vue +++ b/front/src/components/audio/ChannelSerieCard.vue @@ -1,79 +1,78 @@ + + diff --git a/front/src/components/audio/PlayButton.vue b/front/src/components/audio/PlayButton.vue index 64ae38f5c..936ba1215 100644 --- a/front/src/components/audio/PlayButton.vue +++ b/front/src/components/audio/PlayButton.vue @@ -25,6 +25,7 @@ interface Props extends PlayOptionsProps { iconOnly?: boolean playing?: boolean paused?: boolean + lowHeight?: boolean // TODO(wvffle): Remove after https://github.com/vuejs/core/pull/4512 is merged isPlayable?: boolean @@ -56,7 +57,8 @@ const props = withDefaults(defineProps(), { iconOnly: () => false, isPlayable: () => false, playing: () => false, - paused: () => false + paused: () => false, + lowHeight: () => false }) // (1) Create a PlayButton @@ -125,6 +127,8 @@ const isOpen = ref(false) :class="[...buttonClasses, 'play-button']" :isloading="isLoading" :dropdown-only="dropdownOnly" + :low-height="lowHeight || undefined" + style="align-self: start;" @click.stop.prevent="replacePlay()" @split-click="isOpen = !isOpen" > @@ -238,6 +242,7 @@ const isOpen = ref(false) :round="iconOnly" :primary="iconOnly && !discrete" :ghost="discrete" + :low-height="lowHeight || undefined" @click.stop.prevent="replacePlay()" >