MirrorMirror
/
funkwhale
mirror of https://dev.funkwhale.audio/funkwhale/funkwhale.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge branch '220-fix-mp3-track-numbers' into 'develop' 

Resolve "Track numbers from mp3 don't get imported"

Closes #220

See merge request funkwhale/funkwhale!214
This commit is contained in:
Eliot Berriot 2018-05-26 11:40:25 +00:00
parent 9745b57f13 8790631a65
commit d2c99b9f5d
4 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
api/funkwhale_api/music/metadata.py
View File

@ -132,7 +132,7 @@ CONF = {
'getter': get_id3_tag, 'getter': get_id3_tag,
'fields': { 'fields': {
'track_number': { 'track_number': {
'field': 'TPOS', 'field': 'TRCK',
'to_application': convert_track_number 'to_application': convert_track_number
}, },
'title': { 'title': {

BIN
api/tests/music/test.mp3
View File

Binary file not shown.

4
api/tests/music/test_metadata.py
View File

@ -43,10 +43,10 @@ def test_can_get_metadata_from_ogg_theora_file(field, value):
@pytest.mark.parametrize('field,value', [ @pytest.mark.parametrize('field,value', [
('title', 'Bend'), ('title', 'Bend'),
('artist', 'Binärpilot'), ('artist', 'Bindrpilot'),
('album', 'You Can\'t Stop Da Funk'), ('album', 'You Can\'t Stop Da Funk'),
('date', datetime.date(2006, 2, 7)), ('date', datetime.date(2006, 2, 7)),
('track_number', 1), ('track_number', 2),
('musicbrainz_albumid', uuid.UUID('ce40cdb1-a562-4fd8-a269-9269f98d4124')), ('musicbrainz_albumid', uuid.UUID('ce40cdb1-a562-4fd8-a269-9269f98d4124')),
('musicbrainz_recordingid', uuid.UUID('f269d497-1cc0-4ae4-a0c4-157ec7d73fcb')), ('musicbrainz_recordingid', uuid.UUID('f269d497-1cc0-4ae4-a0c4-157ec7d73fcb')),
('musicbrainz_artistid', uuid.UUID('9c6bddde-6228-4d9f-ad0d-03f6fcb19e13')), ('musicbrainz_artistid', uuid.UUID('9c6bddde-6228-4d9f-ad0d-03f6fcb19e13')),

1
changes/changelog.d/220.bugfix Normal file
View File

@ -0,0 +1 @@
Read ID3Tag Tracknumber from TRCK (#220)