MirrorMirror
/
funkwhale
mirror of https://dev.funkwhale.audio/funkwhale/funkwhale.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

chore: Improve comments and remove useless try/catch

This commit is contained in:
Georg Krause 2022-11-15 11:13:40 +01:00 committed by JuniorJPDJ
parent 2fcb274c06
commit ceab2252fb
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
api/funkwhale_api/users/oauth/views.py
View File

@ -52,16 +52,14 @@ class ApplicationViewSet(
def create(self, request, *args, **kwargs): def create(self, request, *args, **kwargs):
request_data = request.data.copy() request_data = request.data.copy()
try: secret = secrets.token_hex(64)
secret = request_data["client_secret"] request_data["client_secret"] = secret
except KeyError:
secret = secrets.token_hex(64)
request_data["client_secret"] = secret
serializer = self.get_serializer(data=request_data) serializer = self.get_serializer(data=request_data)
serializer.is_valid(raise_exception=True) serializer.is_valid(raise_exception=True)
self.perform_create(serializer) self.perform_create(serializer)
headers = self.get_success_headers(serializer.data) headers = self.get_success_headers(serializer.data)
data = serializer.data data = serializer.data
# Since the serializer returns a hashed secret, we need to override it for the response.
data["client_secret"] = secret data["client_secret"] = secret
return response.Response(data, status=201, headers=headers) return response.Response(data, status=201, headers=headers)