diff --git a/api/funkwhale_api/music/metadata.py b/api/funkwhale_api/music/metadata.py index a20069783..494256711 100644 --- a/api/funkwhale_api/music/metadata.py +++ b/api/funkwhale_api/music/metadata.py @@ -28,6 +28,13 @@ def get_id3_tag(f, k): raise TagNotFound(k) +def get_flac_tag(f, k): + try: + return f.get(k)[0] + except (KeyError, IndexError): + raise TagNotFound(k) + + def get_mp3_recording_id(f, k): try: return [ @@ -121,7 +128,38 @@ CONF = { 'getter': get_mp3_recording_id, }, } - } + }, + 'FLAC': { + 'getter': get_flac_tag, + 'fields': { + 'track_number': { + 'field': 'tracknumber', + 'to_application': convert_track_number + }, + 'title': { + 'field': 'title' + }, + 'artist': { + 'field': 'artist' + }, + 'album': { + 'field': 'album' + }, + 'date': { + 'field': 'date', + 'to_application': lambda v: arrow.get(str(v)).date() + }, + 'musicbrainz_albumid': { + 'field': 'musicbrainz_albumid' + }, + 'musicbrainz_artistid': { + 'field': 'musicbrainz_artistid' + }, + 'musicbrainz_recordingid': { + 'field': 'musicbrainz_trackid' + }, + } + }, } diff --git a/api/funkwhale_api/music/utils.py b/api/funkwhale_api/music/utils.py index 49a639303..329a99bed 100644 --- a/api/funkwhale_api/music/utils.py +++ b/api/funkwhale_api/music/utils.py @@ -66,6 +66,7 @@ def compute_status(jobs): AUDIO_EXTENSIONS_AND_MIMETYPE = [ ('ogg', 'audio/ogg'), ('mp3', 'audio/mpeg'), + ('flac', 'audio/flac'), ] EXTENSION_TO_MIMETYPE = {ext: mt for ext, mt in AUDIO_EXTENSIONS_AND_MIMETYPE} diff --git a/api/tests/music/sample.flac b/api/tests/music/sample.flac new file mode 100644 index 000000000..6eff1c06e Binary files /dev/null and b/api/tests/music/sample.flac differ diff --git a/api/tests/music/test_metadata.py b/api/tests/music/test_metadata.py index 342bc99b8..3f1ea9177 100644 --- a/api/tests/music/test_metadata.py +++ b/api/tests/music/test_metadata.py @@ -40,3 +40,20 @@ def test_can_get_metadata_from_id3_mp3_file(field, value): data = metadata.Metadata(path) assert data.get(field) == value + + +@pytest.mark.parametrize('field,value', [ + ('title', '999,999'), + ('artist', 'Nine Inch Nails'), + ('album', 'The Slip'), + ('date', datetime.date(2008, 5, 5)), + ('track_number', 1), + ('musicbrainz_albumid', uuid.UUID('12b57d46-a192-499e-a91f-7da66790a1c1')), + ('musicbrainz_recordingid', uuid.UUID('30f3f33e-8d0c-4e69-8539-cbd701d18f28')), + ('musicbrainz_artistid', uuid.UUID('b7ffd2af-418f-4be2-bdd1-22f8b48613da')), +]) +def test_can_get_metadata_from_flac_file(field, value): + path = os.path.join(DATA_DIR, 'sample.flac') + data = metadata.Metadata(path) + + assert data.get(field) == value diff --git a/changes/changelog.d/157.feature b/changes/changelog.d/157.feature new file mode 100644 index 000000000..0560541b5 --- /dev/null +++ b/changes/changelog.d/157.feature @@ -0,0 +1 @@ +Can now import and play flac files (#157) diff --git a/front/src/audio/formats.js b/front/src/audio/formats.js index f6e2157a1..a4c2ecf0e 100644 --- a/front/src/audio/formats.js +++ b/front/src/audio/formats.js @@ -5,6 +5,7 @@ export default { ], formatsMap: { 'audio/ogg': 'ogg', - 'audio/mpeg': 'mp3' + 'audio/mpeg': 'mp3', + 'audio/flac': 'flac' } }