diff --git a/api/funkwhale_api/federation/activity.py b/api/funkwhale_api/federation/activity.py index 361b136b3..a56c4c41c 100644 --- a/api/funkwhale_api/federation/activity.py +++ b/api/funkwhale_api/federation/activity.py @@ -346,7 +346,6 @@ def activity_pass_object_privacy_level(context, routing): if object_type in MUSIC_OBJECT_TYPE: return True - # to do : support sending activity to followers only if object and obj_privacy_level and obj_privacy_level in ["me", "instance"]: return False diff --git a/api/funkwhale_api/federation/routes.py b/api/funkwhale_api/federation/routes.py index 91970f3b2..4c3dc4fac 100644 --- a/api/funkwhale_api/federation/routes.py +++ b/api/funkwhale_api/federation/routes.py @@ -679,9 +679,6 @@ def inbox_delete_favorite(payload, context): favorite.delete() -# to do : test listening routes and broadcast - - @outbox.register({"type": "Listen", "object.type": "Track"}) def outbox_create_listening(context): track = context["track"] diff --git a/api/funkwhale_api/playlists/migrations/0009_playlist_library.py b/api/funkwhale_api/playlists/migrations/0009_playlist_library.py index 32c63c56d..9376847e1 100644 --- a/api/funkwhale_api/playlists/migrations/0009_playlist_library.py +++ b/api/funkwhale_api/playlists/migrations/0009_playlist_library.py @@ -5,7 +5,6 @@ from django.urls import reverse import uuid -# to do : test migration def add_uploads_to_pl_library(playlist, library): for plt in playlist.playlist_tracks.all(): for upload in plt.track.uploads.filter(library__actor=playlist.actor): diff --git a/docs/specs/playlist-library-federation/index.md b/docs/specs/playlist-library-federation/index.md index 0a366a492..1959f2b85 100644 --- a/docs/specs/playlist-library-federation/index.md +++ b/docs/specs/playlist-library-federation/index.md @@ -2,7 +2,7 @@ ### The Issue -- Has a user I want to share a list of tracks privately to mmy friends +- Has a user I want to share a list of tracks privately to my friends - Has a user I want to have a single container to curate my content (not playlist and libraries, only playlists) ### Proposed Solution @@ -60,5 +60,5 @@ There is no other reason to share the playlit.library to remote. - [ ] Finish library drop (delete libraries endpoints) - [ ] Playlist discovery : fetch federation endpoint for playlists - [ ] Playlist discovery : add the playlist to my playlist collection = follow request to playlist -- [ ] PLaylist Track activity (to avoid having to refetch the whole playlist) -- [ ] Document : The user that want to federate need to activate remote activities in it's user settings. Even if the library is public the playlist activities will not be sended to remote -> We need to implement a followers activity setting +- [ ] Playlist Track activity (to avoid having to refetch the whole playlist) +- [ ] Document : The user that want to federate need to activate remote activities in it's user settings. Even if the library is public the playlist activities will not be sended to remote -> We need to implement a followers activity setting (#2362)