From 29171853b3a9cdf3fcb9851cc6cba97c52988112 Mon Sep 17 00:00:00 2001 From: Eliot Berriot Date: Mon, 19 Nov 2018 23:33:22 +0100 Subject: [PATCH] Fix #612: Improved accessibility by using main/section/nav tags and aria-labels in most critical places --- changes/changelog.d/612.enhancement | 1 + front/src/components/About.vue | 24 +- front/src/components/Footer.vue | 54 +++-- front/src/components/Home.vue | 21 +- front/src/components/PageNotFound.vue | 14 +- front/src/components/Pagination.vue | 44 ++-- front/src/components/Sidebar.vue | 140 ++++++----- front/src/components/audio/Player.vue | 218 ++++++++++-------- front/src/components/auth/Login.vue | 59 ++--- front/src/components/auth/Logout.vue | 12 +- front/src/components/auth/Profile.vue | 29 +-- front/src/components/auth/Settings.vue | 183 ++++++++------- front/src/components/auth/Signup.vue | 72 +++--- front/src/components/favorites/List.vue | 84 +++---- front/src/components/library/Album.vue | 70 +++--- front/src/components/library/Artist.vue | 125 +++++----- front/src/components/library/Artists.vue | 77 +++---- front/src/components/library/Home.vue | 44 ++-- front/src/components/library/Library.vue | 26 ++- front/src/components/library/Radios.vue | 75 +++--- front/src/components/library/Track.vue | 121 +++++----- .../src/components/library/radios/Builder.vue | 102 ++++---- front/src/components/metadata/ArtistCard.vue | 28 +-- front/src/views/Notifications.vue | 59 +++-- front/src/views/admin/Settings.vue | 114 +++++---- front/src/views/admin/library/Base.vue | 14 +- front/src/views/admin/library/FilesList.vue | 14 +- front/src/views/admin/users/Base.vue | 9 +- .../src/views/admin/users/InvitationsList.vue | 16 +- front/src/views/admin/users/UsersDetail.vue | 87 ++++--- front/src/views/admin/users/UsersList.vue | 14 +- front/src/views/auth/EmailConfirm.vue | 38 +-- front/src/views/auth/PasswordReset.vue | 48 ++-- front/src/views/auth/PasswordResetConfirm.vue | 42 ++-- front/src/views/content/Base.vue | 17 +- front/src/views/content/Home.vue | 17 +- front/src/views/content/libraries/Detail.vue | 46 ++-- front/src/views/content/libraries/Files.vue | 8 +- front/src/views/content/libraries/Home.vue | 22 +- front/src/views/playlists/Detail.vue | 65 +++--- front/src/views/playlists/List.vue | 72 +++--- front/src/views/radios/Detail.vue | 63 ++--- 42 files changed, 1266 insertions(+), 1122 deletions(-) create mode 100644 changes/changelog.d/612.enhancement diff --git a/changes/changelog.d/612.enhancement b/changes/changelog.d/612.enhancement new file mode 100644 index 000000000..092f3ec5d --- /dev/null +++ b/changes/changelog.d/612.enhancement @@ -0,0 +1 @@ +Improved accessibility by using main/section/nav tags and aria-labels in most critical places (#612) diff --git a/front/src/components/About.vue b/front/src/components/About.vue index 438fed67d..16c58b173 100644 --- a/front/src/components/About.vue +++ b/front/src/components/About.vue @@ -1,6 +1,6 @@ diff --git a/front/src/components/Home.vue b/front/src/components/Home.vue index 3448d10df..800f77b9f 100644 --- a/front/src/components/Home.vue +++ b/front/src/components/Home.vue @@ -1,6 +1,6 @@ diff --git a/front/src/components/auth/Login.vue b/front/src/components/auth/Login.vue index 88caa5afe..30cb15a36 100644 --- a/front/src/components/auth/Login.vue +++ b/front/src/components/auth/Login.vue @@ -1,6 +1,6 @@ diff --git a/front/src/components/auth/Logout.vue b/front/src/components/auth/Logout.vue index 5f60a9dbe..90495f5e0 100644 --- a/front/src/components/auth/Logout.vue +++ b/front/src/components/auth/Logout.vue @@ -1,6 +1,6 @@ diff --git a/front/src/components/auth/Signup.vue b/front/src/components/auth/Signup.vue index 8d2e80470..01230a117 100644 --- a/front/src/components/auth/Signup.vue +++ b/front/src/components/auth/Signup.vue @@ -1,6 +1,6 @@ diff --git a/front/src/views/admin/library/FilesList.vue b/front/src/views/admin/library/FilesList.vue index 1c5216c8f..3557879bb 100644 --- a/front/src/views/admin/library/FilesList.vue +++ b/front/src/views/admin/library/FilesList.vue @@ -1,24 +1,24 @@ diff --git a/front/src/views/auth/PasswordReset.vue b/front/src/views/auth/PasswordReset.vue index 52787a516..e7759113c 100644 --- a/front/src/views/auth/PasswordReset.vue +++ b/front/src/views/auth/PasswordReset.vue @@ -1,6 +1,6 @@ diff --git a/front/src/views/auth/PasswordResetConfirm.vue b/front/src/views/auth/PasswordResetConfirm.vue index b6e4f2322..df0589beb 100644 --- a/front/src/views/auth/PasswordResetConfirm.vue +++ b/front/src/views/auth/PasswordResetConfirm.vue @@ -1,6 +1,6 @@ diff --git a/front/src/views/content/Base.vue b/front/src/views/content/Base.vue index cfdd20428..039e21adc 100644 --- a/front/src/views/content/Base.vue +++ b/front/src/views/content/Base.vue @@ -1,24 +1,25 @@