Merge tag '0.14.1' into develop
0.14.1 (2018-06-06) ------------------- Upgrade instructions are available at https://docs.funkwhale.audio/upgrading.html Enhancements: - Display server version in the footer (#270) - fix_track_files will now update files with bad mimetype (and not only the one with no mimetype) (#273) - Huge performance boost (~x5 to x7) during CLI import that queries MusicBrainz (#288) - Removed alpha-state transcoding support (#271) Bugfixes: - Broken logging statement during import error (#274) - Broken search bar on library home (#278) - Do not crash when importing track with an artist that do not match the release artist (#237) - Do not crash when tag contains multiple uuids with a / separator (#267) - Ensure we do not store bad mimetypes (such as application/x-empty) (#266) - Fix broken "play all" button that played only 25 tracks (#281) - Fixed broken track download modal (overflow and wrong URL) (#239) - Removed hardcoded size limit in file upload widget (#275) Documentation: - Added warning about _protected/music location in nginx configuration (#247) Removed alpha-state transcoding (#271) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ A few months ago, a basic transcoding feature was implemented. Due to the way this feature was designed, it was slow, CPU intensive on the server side, and very tightly coupled to the reverse-proxy configuration, preventing it to work Apache2, for instance. It was also not compatible with Subsonic clients. Based on that, we're currently removing support for transcoding **in its current state**. The work on a better designed transcoding feature can be tracked in https://code.eliotberriot.com/funkwhale/funkwhale/issues/272. You don't have to do anything on your side, but you may want to remove the now obsolete configuration from your reverse proxy file (nginx only):: # Remove those blocks: # transcode cache proxy_cache_path /tmp/funkwhale-transcode levels=1:2 keys_zone=transcode:10m max_size=1g inactive=7d; # Transcoding logic and caching location = /transcode-auth { include /etc/nginx/funkwhale_proxy.conf; # needed so we can authenticate transcode requests, but still # cache the result internal; set $query ''; # ensure we actually pass the jwt to the underlytin auth url if ($request_uri ~* "[^\?]+\?(.*)$") { set $query $1; } proxy_pass http://funkwhale-api/api/v1/trackfiles/viewable/?$query; proxy_pass_request_body off; proxy_set_header Content-Length ""; } location /api/v1/trackfiles/transcode/ { include /etc/nginx/funkwhale_proxy.conf; # this block deals with authenticating and caching transcoding # requests. Caching is heavily recommended as transcoding # is a CPU intensive process. auth_request /transcode-auth; if ($args ~ (.*)jwt=[^&]*(.*)) { set $cleaned_args $1$2; } proxy_cache_key "$scheme$request_method$host$uri$is_args$cleaned_args"; proxy_cache transcode; proxy_cache_valid 200 7d; proxy_ignore_headers "Set-Cookie"; proxy_hide_header "Set-Cookie"; add_header X-Cache-Status $upstream_cache_status; proxy_pass http://funkwhale-api; } # end of transcoding logic
This commit is contained in:
Eliot Berriot
commit
ab43d6d078
88
CHANGELOG
88
CHANGELOG
|
|
@ -10,6 +10,94 @@ This changelog is viewable on the web at https://docs.funkwhale.audio/changelog.
|
|||
|
||||
.. towncrier
|
||||
|
||||
0.14.1 (2018-06-06)
|
||||
-------------------
|
||||
|
||||
Upgrade instructions are available at https://docs.funkwhale.audio/upgrading.html
|
||||
|
||||
Enhancements:
|
||||
|
||||
- Display server version in the footer (#270)
|
||||
- fix_track_files will now update files with bad mimetype (and not only the one
|
||||
with no mimetype) (#273)
|
||||
- Huge performance boost (~x5 to x7) during CLI import that queries MusicBrainz
|
||||
(#288)
|
||||
- Removed alpha-state transcoding support (#271)
|
||||
|
||||
Bugfixes:
|
||||
|
||||
- Broken logging statement during import error (#274)
|
||||
- Broken search bar on library home (#278)
|
||||
- Do not crash when importing track with an artist that do not match the
|
||||
release artist (#237)
|
||||
- Do not crash when tag contains multiple uuids with a / separator (#267)
|
||||
- Ensure we do not store bad mimetypes (such as application/x-empty) (#266)
|
||||
- Fix broken "play all" button that played only 25 tracks (#281)
|
||||
- Fixed broken track download modal (overflow and wrong URL) (#239)
|
||||
- Removed hardcoded size limit in file upload widget (#275)
|
||||
|
||||
|
||||
Documentation:
|
||||
|
||||
- Added warning about _protected/music location in nginx configuration (#247)
|
||||
|
||||
|
||||
Removed alpha-state transcoding (#271)
|
||||
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
A few months ago, a basic transcoding feature was implemented. Due to the way
|
||||
this feature was designed, it was slow, CPU intensive on the server side,
|
||||
and very tightly coupled to the reverse-proxy configuration, preventing
|
||||
it to work Apache2, for instance. It was also not compatible with Subsonic clients.
|
||||
|
||||
Based on that, we're currently removing support for transcoding
|
||||
**in its current state**. The work on a better designed transcoding feature
|
||||
can be tracked in https://code.eliotberriot.com/funkwhale/funkwhale/issues/272.
|
||||
|
||||
You don't have to do anything on your side, but you may want to remove
|
||||
the now obsolete configuration from your reverse proxy file (nginx only)::
|
||||
|
||||
# Remove those blocks:
|
||||
|
||||
# transcode cache
|
||||
proxy_cache_path /tmp/funkwhale-transcode levels=1:2 keys_zone=transcode:10m max_size=1g inactive=7d;
|
||||
|
||||
# Transcoding logic and caching
|
||||
location = /transcode-auth {
|
||||
include /etc/nginx/funkwhale_proxy.conf;
|
||||
# needed so we can authenticate transcode requests, but still
|
||||
# cache the result
|
||||
internal;
|
||||
set $query '';
|
||||
# ensure we actually pass the jwt to the underlytin auth url
|
||||
if ($request_uri ~* "[^\?]+\?(.*)$") {
|
||||
set $query $1;
|
||||
}
|
||||
proxy_pass http://funkwhale-api/api/v1/trackfiles/viewable/?$query;
|
||||
proxy_pass_request_body off;
|
||||
proxy_set_header Content-Length "";
|
||||
}
|
||||
|
||||
location /api/v1/trackfiles/transcode/ {
|
||||
include /etc/nginx/funkwhale_proxy.conf;
|
||||
# this block deals with authenticating and caching transcoding
|
||||
# requests. Caching is heavily recommended as transcoding
|
||||
# is a CPU intensive process.
|
||||
auth_request /transcode-auth;
|
||||
if ($args ~ (.*)jwt=[^&]*(.*)) {
|
||||
set $cleaned_args $1$2;
|
||||
}
|
||||
proxy_cache_key "$scheme$request_method$host$uri$is_args$cleaned_args";
|
||||
proxy_cache transcode;
|
||||
proxy_cache_valid 200 7d;
|
||||
proxy_ignore_headers "Set-Cookie";
|
||||
proxy_hide_header "Set-Cookie";
|
||||
add_header X-Cache-Status $upstream_cache_status;
|
||||
proxy_pass http://funkwhale-api;
|
||||
}
|
||||
# end of transcoding logic
|
||||
|
||||
|
||||
0.14 (2018-06-02)
|
||||
-----------------
|
||||
|
||||
|
|
|
|||
|
|
@ -1,3 +1,3 @@
|
|||
# -*- coding: utf-8 -*-
|
||||
__version__ = '0.14'
|
||||
__version__ = '0.14.1'
|
||||
__version_info__ = tuple([int(num) if num.isdigit() else num for num in __version__.replace('-', '.', 1).split('.')])
|
||||
|
|
|
|||
|
|
@ -1 +0,0 @@
|
|||
Do not crash when importing track with an artist that do not match the release artist (#237)
|
||||
|
|
@ -1 +0,0 @@
|
|||
Fixed broken track download modal (overflow and wrong URL) (#239)
|
||||
|
|
@ -1 +0,0 @@
|
|||
Added warning about _protected/music location in nginx configuration (#247)
|
||||
|
|
@ -1 +0,0 @@
|
|||
Ensure we do not store bad mimetypes (such as application/x-empty) (#266)
|
||||
|
|
@ -1 +0,0 @@
|
|||
Do not crash when tag contains multiple uuids with a / separator (#267)
|
||||
|
|
@ -1 +0,0 @@
|
|||
Display server version in the footer (#270)
|
||||
|
|
@ -1,57 +0,0 @@
|
|||
Removed transcoding support (#271)
|
||||
|
||||
|
||||
Removed alpha-state transcoding (#271)
|
||||
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
A few months ago, a basic transcoding feature was implemented. Due to the way
|
||||
this feature was designed, it was slow, CPU intensive on the server side,
|
||||
and very tightly coupled to the reverse-proxy configuration, preventing
|
||||
it to work Apache2, for instance. It was also not compatible with Subsonic clients.
|
||||
|
||||
Based on that, we're currently removing support for transcoding
|
||||
**in its current state**. The work on a better designed transcoding feature
|
||||
can be tracked in https://code.eliotberriot.com/funkwhale/funkwhale/issues/272.
|
||||
|
||||
You don't have to do anything on your side, but you may want to remove
|
||||
the now obsolete configuration from your reverse proxy file (nginx only)::
|
||||
|
||||
# Remove those blocks:
|
||||
|
||||
# transcode cache
|
||||
proxy_cache_path /tmp/funkwhale-transcode levels=1:2 keys_zone=transcode:10m max_size=1g inactive=7d;
|
||||
|
||||
# Transcoding logic and caching
|
||||
location = /transcode-auth {
|
||||
include /etc/nginx/funkwhale_proxy.conf;
|
||||
# needed so we can authenticate transcode requests, but still
|
||||
# cache the result
|
||||
internal;
|
||||
set $query '';
|
||||
# ensure we actually pass the jwt to the underlytin auth url
|
||||
if ($request_uri ~* "[^\?]+\?(.*)$") {
|
||||
set $query $1;
|
||||
}
|
||||
proxy_pass http://funkwhale-api/api/v1/trackfiles/viewable/?$query;
|
||||
proxy_pass_request_body off;
|
||||
proxy_set_header Content-Length "";
|
||||
}
|
||||
|
||||
location /api/v1/trackfiles/transcode/ {
|
||||
include /etc/nginx/funkwhale_proxy.conf;
|
||||
# this block deals with authenticating and caching transcoding
|
||||
# requests. Caching is heavily recommended as transcoding
|
||||
# is a CPU intensive process.
|
||||
auth_request /transcode-auth;
|
||||
if ($args ~ (.*)jwt=[^&]*(.*)) {
|
||||
set $cleaned_args $1$2;
|
||||
}
|
||||
proxy_cache_key "$scheme$request_method$host$uri$is_args$cleaned_args";
|
||||
proxy_cache transcode;
|
||||
proxy_cache_valid 200 7d;
|
||||
proxy_ignore_headers "Set-Cookie";
|
||||
proxy_hide_header "Set-Cookie";
|
||||
add_header X-Cache-Status $upstream_cache_status;
|
||||
proxy_pass http://funkwhale-api;
|
||||
}
|
||||
# end of transcoding logic
|
||||
|
|
@ -1,2 +0,0 @@
|
|||
fix_track_files will now update files with bad mimetype (and not only
|
||||
the one with no mimetype) (#273)
|
||||
|
|
@ -1 +0,0 @@
|
|||
Broken logging statement during import error (#274)
|
||||
|
|
@ -1 +0,0 @@
|
|||
Removed hardcoded size limit in file upload widget (#275)
|
||||
|
|
@ -1 +0,0 @@
|
|||
Broken search bar on library home (#278)
|
||||
|
|
@ -1 +0,0 @@
|
|||
Fix broken "play all" button that played only 25 tracks (#281)
|
||||
|
|
@ -1 +0,0 @@
|
|||
Huge performance boost (~x5 to x7) during CLI import that queries MusicBrainz (#288)
|
||||
|
|
@ -1,5 +1,6 @@
|
|||
|
||||
Upgrade instructions are available at https://docs.funkwhale.audio/upgrading.html
|
||||
Upgrade instructions are available at
|
||||
https://docs.funkwhale.audio/upgrading.html
|
||||
|
||||
{% for section, _ in sections.items() %}
|
||||
{% if sections[section] %}
|
||||
|
|
|
|||
Loading…
Reference in New Issue