From a717d02133195a3ddc5ee1d44aaf9254b2e6b86e Mon Sep 17 00:00:00 2001
From: ArneBo <arne@ecobasa.org>
Date: Sat, 25 Jan 2025 23:22:21 +0100
Subject: [PATCH] [WIP] refactor(front): channel detail page

---
 .../components/channels/SubscribeButton.vue   |  18 +-
 front/src/components/common/ActorLink.vue     |   2 +-
 front/src/components/tags/List.vue            |  21 +-
 front/src/views/channels/DetailBase.vue       | 540 +++++++++---------
 4 files changed, 296 insertions(+), 285 deletions(-)

diff --git a/front/src/components/channels/SubscribeButton.vue b/front/src/components/channels/SubscribeButton.vue
index 436e6930f..c52702cdf 100644
--- a/front/src/components/channels/SubscribeButton.vue
+++ b/front/src/components/channels/SubscribeButton.vue
@@ -9,6 +9,7 @@ import { useRoute } from 'vue-router'
 const route = useRoute()
 
 import LoginModal from '~/components/common/LoginModal.vue'
+import Button from '~/components/ui/Button.vue'
 
 interface Events {
   (e: 'unsubscribed'): void
@@ -46,20 +47,21 @@ const loginModal = ref()
 </script>
 
 <template>
-  <button
+  <Button
     v-if="store.state.auth.authenticated"
-    :class="['ui', 'pink', {'inverted': isSubscribed}, {'favorited': isSubscribed}, 'icon', 'labeled', 'button']"
+    :class="['pink', {'inverted': isSubscribed}, {'favorited': isSubscribed}]"
+    outline
+    icon="bi-heart-fill"
     @click.stop="toggle"
   >
-    <i class="heart icon" />
     {{ title }}
-  </button>
-  <button
+  </Button>
+  <Button
     v-else
-    :class="['ui', 'pink', 'icon', 'labeled', 'button']"
+    outline
+    icon="bi-heart"
     @click="loginModal.show = true"
   >
-    <i class="heart icon" />
     {{ title }}
     <login-modal
       ref="loginModal"
@@ -69,5 +71,5 @@ const loginModal = ref()
       :cover="channel.artist?.cover!"
       @created="loginModal.show = false"
     />
-  </button>
+  </Button>
 </template>
diff --git a/front/src/components/common/ActorLink.vue b/front/src/components/common/ActorLink.vue
index 002145b05..18560bf71 100644
--- a/front/src/components/common/ActorLink.vue
+++ b/front/src/components/common/ActorLink.vue
@@ -67,7 +67,7 @@ const url = computed(() => {
         v-if="avatar"
         :actor="actor"
       />
-      <slot>{{ repr }}</slot>
+      <slot>@{{ repr }}</slot>
     </span>
   </Link>
 </template>
diff --git a/front/src/components/tags/List.vue b/front/src/components/tags/List.vue
index b2bdde144..2b4b0b7fc 100644
--- a/front/src/components/tags/List.vue
+++ b/front/src/components/tags/List.vue
@@ -3,7 +3,8 @@ import { truncate } from '~/utils/filters'
 import { computed, ref } from 'vue'
 import { useI18n } from 'vue-i18n'
 
-import TagsList from '~/components/tags/List.vue'
+import Layout from '~/components/ui/Layout.vue'
+import Pill from '~/components/ui/Pill.vue'
 
 interface Props {
   tags: string[]
@@ -35,23 +36,23 @@ const tags = computed(() => {
 </script>
 
 <template>
-  <div class="component-tags-list">
+  <Layout flex style="gap: 8px" class="component-tags-list">
     <router-link
       v-for="tag in tags"
       :key="tag"
       :to="{name: props.detailRoute, params: { id: tag } }"
-      :class="['ui', 'circular', 'hashtag', 'label', props.labelClasses]"
+      :class="props.labelClasses"
     >
-      <span class="hashtag symbol" />
-      {{ truncate(tag, props.truncateSize) }}
+      <Pill solid raised secondary>
+        <span class="hashtag symbol" />
+        {{ truncate(tag, props.truncateSize) }}
+      </Pill>
     </router-link>
-    <div
+    <Pill
       v-if="props.showMore && tags.length < props.tags.length"
-      role="button"
-      class="ui circular inverted accent label"
       @click.prevent="honorLimit = false"
     >
       {{ t('components.tags.List.button.more', props.tags.length - tags.length) }}
-    </div>
-  </div>
+    </Pill>
+  </Layout>
 </template>
diff --git a/front/src/views/channels/DetailBase.vue b/front/src/views/channels/DetailBase.vue
index e8f9ea03a..6ad655928 100644
--- a/front/src/views/channels/DetailBase.vue
+++ b/front/src/views/channels/DetailBase.vue
@@ -11,9 +11,21 @@ import axios from 'axios'
 import SubscribeButton from '~/components/channels/SubscribeButton.vue'
 import ChannelForm from '~/components/audio/ChannelForm.vue'
 import EmbedWizard from '~/components/audio/EmbedWizard.vue'
-import SemanticModal from '~/components/semantic/Modal.vue'
+import HumanDuration from '~/components/common/HumanDuration.vue'
 import PlayButton from '~/components/audio/PlayButton.vue'
 import TagsList from '~/components/tags/List.vue'
+import SemanticModal from '~/components/semantic/Modal.vue'
+import RadioButton from '~/components/radios/Button.vue'
+import Loader from '~/components/ui/Loader.vue'
+import Button from '~/components/ui/Button.vue'
+import Tabs from '~/components/ui/Tabs.vue'
+import Tab from '~/components/ui/Tab.vue'
+import OptionsButton from '~/components/ui/button/Options.vue'
+import Popover from '~/components/ui/Popover.vue'
+import PopoverItem from '~/components/ui/popover/PopoverItem.vue'
+import Layout from '~/components/ui/Layout.vue'
+import Modal from '~/components/ui/Modal.vue'
+import Spacer from '~/components/ui/Spacer.vue'
 
 import useErrorHandler from '~/composables/useErrorHandler'
 import useReport from '~/composables/moderation/useReport'
@@ -92,6 +104,7 @@ const fetchData = async () => {
 
 watch(() => props.id, fetchData, { immediate: true })
 
+
 const uuid = computed(() => store.state.channels.latestPublication?.channel.uuid)
 watch([uuid, object], ([uuid, object], [lastUuid, lastObject]) => {
   if (object?.uuid && object.uuid === lastObject?.uuid) return
@@ -128,49 +141,36 @@ const updateSubscriptionCount = (delta: number) => {
 </script>
 
 <template>
-  <main
+  <Layout stack main
     v-title="labels.title"
-    class="main"
   >
-    <div
-      v-if="isLoading"
-      class="ui vertical segment"
-    >
-      <div :class="['ui', 'centered', 'active', 'inline', 'loader']" />
-    </div>
+    <Loader v-if="isLoading" />
     <template v-if="object && !isLoading">
       <section
         v-title="object.artist?.name"
-        class="ui head vertical stripe segment container"
       >
-        <div class="ui stackable grid">
-          <div class="seven wide column">
-            <div class="ui two column grid">
-              <div class="column">
-                <img
-                  v-if="object.artist?.cover"
-                  alt=""
-                  class="huge channel-image"
-                  :src="store.getters['instance/absoluteUrl'](object.artist.cover.urls.medium_square_crop)"
-                >
-                <i
-                  v-else
-                  class="huge circular inverted users violet icon"
-                />
+        <Layout flex>
+          <img
+            v-if="object.artist?.cover"
+            alt=""
+            class="huge channel-image"
+            :src="store.getters['instance/absoluteUrl'](object.artist.cover.urls.large_square_crop)"
+          >
+          <i
+            v-else
+            class="huge circular inverted bi bi-person-circle-fill violet"
+          />
+          <Layout stack noGap style="flex: 1;">
+            <h1>
+              <div
+                :title="object.artist?.name"
+              >
+                {{ object.artist?.name }}
               </div>
-              <div class="ui column right aligned">
-                <TagsList
-                  v-if="object.artist?.tags && object.artist?.tags.length > 0"
-                  :tags="object.artist.tags"
-                />
-                <actor-link
-                  v-if="object.actor"
-                  :avatar="false"
-                  :actor="object.attributed_to"
-                  :display-name="true"
-                />
+            </h1>
+            <Layout stack class="meta" style="gap: 0;">
+              <Layout flex noGap>
                 <template v-if="totalTracks > 0">
-                  <div class="ui hidden very small divider" />
                   <span
                     v-if="object.artist?.content_category === 'podcast'"
                   >
@@ -183,213 +183,169 @@ const updateSubscriptionCount = (delta: number) => {
                   </span>
                 </template>
                 <template v-if="object.attributed_to.full_username === store.state.auth.fullUsername || store.getters['channels/isSubscribed'](object.uuid)">
-                  <br>
+                  <i class="bi bi-dot" />
                   {{ t('views.channels.DetailBase.meta.subscribers', object?.subscriptions_count ?? 0) }}
-                  <br>
+                  <i class="bi bi-dot" />
                   {{ t('views.channels.DetailBase.meta.listenings', object?.downloads_count ?? 0) }}
                 </template>
-                <div class="ui hidden small divider" />
-                <a
-                  class="ui icon small basic button"
-                  @click.stop.prevent="showSubscribeModal = true"
-                >
-                  <i class="feed icon" />
-                </a>
-                <semantic-modal
-                  v-model:show="showSubscribeModal"
-                  class="tiny"
-                >
-                  <h4 class="header">
-                    {{ t('views.channels.DetailBase.modal.subscribe.header') }}
-                  </h4>
-                  <div class="scrollable content">
-                    <div class="description">
-                      <template v-if="store.state.auth.authenticated">
-                        <h3>
-                          <i class="user icon" />
-                          {{ t('views.channels.DetailBase.modal.subscribe.funkwhale.header') }}
-                        </h3>
-                        <subscribe-button
-                          :channel="object"
-                          @subscribed="updateSubscriptionCount(1)"
-                          @unsubscribed="updateSubscriptionCount(-1)"
-                        />
-                      </template>
-                      <template v-if="object.rss_url">
-                        <h3>
-                          <i class="feed icon" />
-                          {{ t('views.channels.DetailBase.modal.subscribe.rss.header') }}
-                        </h3>
-                        <p>
-                          {{ t('views.channels.DetailBase.modal.subscribe.rss.content.help') }}
-                        </p>
-                        <copy-input :value="object.rss_url" />
-                      </template>
-                      <template v-if="object.actor">
-                        <h3>
-                          <i class="bell icon" />
-                          {{ t('views.channels.DetailBase.modal.subscribe.fediverse.header') }}
-                        </h3>
-                        <p>
-                          {{ t('views.channels.DetailBase.modal.subscribe.fediverse.content.help') }}
-                        </p>
-                        <copy-input
-                          id="copy-tag"
-                          :value="`@${object.actor.full_username}`"
-                        />
-                      </template>
-                    </div>
-                  </div>
-                  <div class="actions">
-                    <button class="ui basic deny button">
-                      {{ t('views.channels.DetailBase.button.cancel') }}
-                    </button>
-                  </div>
-                </semantic-modal>
-                <button
-                  ref="dropdown"
-                  v-dropdown="{direction: 'downward'}"
-                  class="ui right floated pointing dropdown icon small basic button"
-                >
-                  <i class="ellipsis vertical icon" />
-                  <div class="menu">
-                    <a
-                      v-if="totalTracks > 0"
-                      href=""
-                      class="basic item"
-                      @click.prevent="showEmbedModal = !showEmbedModal"
-                    >
-                      <i class="code icon" />
-                      {{ t('views.channels.DetailBase.button.embed') }}
-                    </a>
-                    <a
-                      v-if="object.actor && object.actor.domain != store.getters['instance/domain']"
-                      :href="object.url"
-                      target="_blank"
-                      class="basic item"
-                    >
-                      <i class="external icon" />
-                      {{ t('views.channels.DetailBase.link.domainView', {domain: object.actor.domain}) }}
-                    </a>
-                    <div class="divider" />
-                    <a
-                      v-for="obj in getReportableObjects({account: object.attributed_to, channel: object})"
-                      :key="obj.target.type + obj.target.id"
-                      href=""
-                      class="basic item"
-                      @click.stop.prevent="report(obj)"
-                    >
-                      <i class="share icon" /> {{ obj.label }}
-                    </a>
 
-                    <template v-if="isOwner">
-                      <div class="divider" />
-                      <a
-                        class="item"
-                        href=""
-                        @click.stop.prevent="showEditModal = true"
-                      >
-                        <i class="edit icon" />
-                        {{ t('views.channels.DetailBase.button.edit') }}
-                      </a>
-                      <dangerous-button
-                        v-if="object"
-                        :class="['ui', {loading: isLoading}, 'item']"
-                        @confirm="remove()"
-                      >
-                        <i class="ui trash icon" />
-                        {{ t('views.channels.DetailBase.button.delete') }}
-                        <template #modal-header>
-                          <p>
-                            {{ t('views.channels.DetailBase.modal.delete.header') }}
-                          </p>
-                        </template>
-                        <template #modal-content>
-                          <div>
-                            <p>
-                              {{ t('views.channels.DetailBase.modal.delete.content.warning') }}
-                            </p>
-                          </div>
-                        </template>
-                        <template #modal-confirm>
-                          <p>
-                            {{ t('views.channels.DetailBase.button.confirm') }}
-                          </p>
-                        </template>
-                      </dangerous-button>
-                    </template>
-                    <template v-if="store.state.auth.availablePermissions['library']">
-                      <div class="divider" />
-                      <router-link
-                        class="basic item"
-                        :to="{name: 'manage.channels.detail', params: {id: object.uuid}}"
-                      >
-                        <i class="wrench icon" />
-                        {{ t('views.channels.DetailBase.link.moderation') }}
-                      </router-link>
-                    </template>
-                  </div>
-                </button>
-              </div>
-            </div>
-            <h1 class="ui header">
-              <div
-                class="left aligned"
-                :title="object.artist?.name"
-              >
-                {{ object.artist?.name }}
-                <div class="ui hidden very small divider" />
-                <div
-                  v-if="object.actor"
-                  class="sub header ellipsis"
-                  :title="object.actor.full_username"
-                >
-                  {{ object.actor.full_username }}
+                <div v-if="totalTracks > 0">
+                  <i class="bi bi-dot" />
+                  <human-duration
+                    v-if="totalTracks > 0"
+                    :duration="totalTracks"
+                  />
                 </div>
-                <div
-                  v-else
-                  class="sub header ellipsis"
+              </Layout>
+              <Layout flex noGap>
+                <span
+                  v-if="object.artist?.content_category === 'podcast'"
                 >
+                  {{ t('views.channels.DetailBase.header.podcastChannel') }}
+                </span>
+                <span
+                  v-if="!object.actor"
+                >
+                  <i class="bi bi-dot" />
                   <a
                     :href="object.url || object.rss_url"
                     rel="noopener noreferrer"
                     target="_blank"
                   >
-                    <i class="external link icon" />
+                    <i class="bi bi-box-arrow-up-right" />
                     {{ t('views.channels.DetailBase.link.mirrored', {domain: externalDomain}) }}
                   </a>
-                </div>
-              </div>
-            </h1>
-            <div class="header-buttons">
-              <div
-                v-if="isOwner"
-                class="ui buttons"
-              >
-                <button
-                  class="ui basic labeled icon button"
-                  @click.prevent.stop="store.commit('channels/showUploadModal', {show: true, config: {channel: object}})"
+                </span>
+                <span
+                  v-else
                 >
-                  <i class="upload icon" />
-                  {{ t('views.channels.DetailBase.button.upload') }}
-                </button>
-              </div>
-              <div class="ui buttons">
-                <play-button
-                  :is-playable="isPlayable"
-                  class="vibrant"
-                  :artist="object.artist"
-                >
-                  {{ t('views.channels.DetailBase.button.play') }}
-                </play-button>
-              </div>
-              <div class="ui buttons">
-                <subscribe-button
-                  :channel="object"
-                  @subscribed="updateSubscriptionCount(1)"
-                  @unsubscribed="updateSubscriptionCount(-1)"
+                  {{ t('views.channels.DetailBase.header.artistChannel') }}
+                </span>
+                <span v-if="object.actor">
+                  <i class="bi bi-dot" />
+                  {{ t('views.library.LibraryBase.link.owner') }}
+                </span>
+                <Spacer h :size="4" />
+                <ActorLink
+                  v-if="object.actor"
+                  discrete
+                  :avatar="false"
+                  :actor="object.attributed_to"
+                  :display-name="true"
                 />
-              </div>
+              </Layout>
+            </Layout>
+              <rendered-description
+                :content="object.artist?.description"
+                :update-url="`channels/${object.uuid}/`"
+                :can-update="false"
+                @updated="object = $event"
+              />
+            <Layout flex class="header-buttons">
+              <Button
+                v-if="isOwner"
+                primary
+                icon="bi-upload"
+                @click.prevent.stop="store.commit('channels/showUploadModal', {show: true, config: {channel: object}})"
+              >
+                {{ t('views.channels.DetailBase.button.upload') }}
+              </Button>
+              <PlayButton
+                :is-playable="isPlayable"
+                split
+                class="vibrant"
+                :artist="object.artist"
+              >
+                {{ t('views.channels.DetailBase.button.play') }}
+              </PlayButton>
+              <RadioButton
+                type="artist"
+                :object-id="object.artist.id"
+              />
+
+              <Popover>
+                <template #default="{ toggleOpen }">
+                  <OptionsButton
+                    @click="toggleOpen"
+                  />
+                </template>
+                <template #items>
+                  <PopoverItem
+                    v-if="totalTracks > 0"
+                    icon="bi-code-slash"
+                    @click.prevent="showEmbedModal = !showEmbedModal"
+                  >
+                    {{ t('views.channels.DetailBase.button.embed') }}
+                  </PopoverItem>
+                  <PopoverItem
+                    v-if="object.actor && object.actor.domain != store.getters['instance/domain']"
+                    :href="object.url"
+                    target="_blank"
+                    icon="bi-box-arrow-up-right"
+                  >
+                    {{ t('views.channels.DetailBase.link.domainView', {domain: object.actor.domain}) }}
+                  </PopoverItem>
+                  <hr>
+                  <PopoverItem
+                    v-for="obj in getReportableObjects({account: object.attributed_to, channel: object})"
+                    icon="bi-share"
+                    :key="obj.target.type + obj.target.id"
+                    @click.stop.prevent="report(obj)"
+                  >
+                    {{ obj.label }}
+                  </PopoverItem>
+
+                  <template v-if="isOwner">
+                    <hr>
+                    <PopoverItem
+                      icon="bi-pencil"
+                      @click.stop.prevent="showEditModal = true"
+                    >
+                      {{ t('views.channels.DetailBase.button.edit') }}
+                    </PopoverItem>
+                    <dangerous-button
+                      v-if="object"
+                      :class="['ui', {loading: isLoading}, 'item']"
+                      @confirm="remove()"
+                    >
+                      <i class="bi bi-trash" />
+                      {{ t('views.channels.DetailBase.button.delete') }}
+                      <template #modal-header>
+                        <p>
+                          {{ t('views.channels.DetailBase.modal.delete.header') }}
+                        </p>
+                      </template>
+                      <template #modal-content>
+                        <div>
+                          <p>
+                            {{ t('views.channels.DetailBase.modal.delete.content.warning') }}
+                          </p>
+                        </div>
+                      </template>
+                      <template #modal-confirm>
+                        <p>
+                          {{ t('views.channels.DetailBase.button.confirm') }}
+                        </p>
+                      </template>
+                    </dangerous-button>
+                  </template>
+                  <template v-if="store.state.auth.availablePermissions['library']">
+                    <hr>
+                    <PopoverItem
+                      :to="{name: 'manage.channels.detail', params: {id: object.uuid}}"
+                      icon="bi-wrench"
+                    >
+                      {{ t('views.channels.DetailBase.link.moderation') }}
+                    </PopoverItem>
+                  </template>
+                </template>
+              </Popover>
+              <Spacer h grow />
+              <subscribe-button
+                :channel="object"
+                @subscribed="updateSubscriptionCount(1)"
+                @unsubscribed="updateSubscriptionCount(-1)"
+              />
 
               <semantic-modal
                 v-if="totalTracks > 0"
@@ -451,51 +407,103 @@ const updateSubscriptionCount = (delta: number) => {
                   </button>
                 </div>
               </semantic-modal>
-            </div>
-            <div v-if="store.getters['ui/layoutVersion'] === 'large'">
-              <rendered-description
-                :content="object.artist?.description"
-                :update-url="`channels/${object.uuid}/`"
-                :can-update="false"
-                @updated="object = $event"
+              <Button
+                secondary
+                icon="bi-rss"
+                @click.stop.prevent="showSubscribeModal = true"
               />
-            </div>
-          </div>
-          <div class="nine wide column">
-            <div class="ui secondary pointing center aligned menu">
-              <router-link
-                class="item"
-
-                :to="{name: 'channels.detail', params: {id: id}}"
+              <semantic-modal
+                v-model:show="showSubscribeModal"
+                class="tiny"
               >
-                {{ t('views.channels.DetailBase.link.channelOverview') }}
-              </router-link>
-              <router-link
-                class="item"
-
-                :to="{name: 'channels.detail.episodes', params: {id: id}}"
-              >
-                <span
-                  v-if="isPodcast"
-                >
-                  {{ t('views.channels.DetailBase.link.channelEpisodes') }}
-                </span>
-                <span
-                  v-else
-                >
-                  {{ t('views.channels.DetailBase.link.channelTracks') }}
-                </span>
-              </router-link>
-            </div>
-            <div class="ui hidden divider" />
+                <h4 class="header">
+                  {{ t('views.channels.DetailBase.modal.subscribe.header') }}
+                </h4>
+                <div class="scrollable content">
+                  <div class="description">
+                    <template v-if="store.state.auth.authenticated">
+                      <h3>
+                        <i class="user icon" />
+                        {{ t('views.channels.DetailBase.modal.subscribe.funkwhale.header') }}
+                      </h3>
+                      <subscribe-button
+                        :channel="object"
+                        @subscribed="updateSubscriptionCount(1)"
+                        @unsubscribed="updateSubscriptionCount(-1)"
+                      />
+                    </template>
+                    <template v-if="object.rss_url">
+                      <h3>
+                        <i class="feed icon" />
+                        {{ t('views.channels.DetailBase.modal.subscribe.rss.header') }}
+                      </h3>
+                      <p>
+                        {{ t('views.channels.DetailBase.modal.subscribe.rss.content.help') }}
+                      </p>
+                      <copy-input :value="object.rss_url" />
+                    </template>
+                    <template v-if="object.actor">
+                      <h3>
+                        <i class="bell icon" />
+                        {{ t('views.channels.DetailBase.modal.subscribe.fediverse.header') }}
+                      </h3>
+                      <p>
+                        {{ t('views.channels.DetailBase.modal.subscribe.fediverse.content.help') }}
+                      </p>
+                      <copy-input
+                        id="copy-tag"
+                        :value="`@${object.actor.full_username}`"
+                      />
+                    </template>
+                  </div>
+                </div>
+                <div class="actions">
+                  <button class="ui basic deny button">
+                    {{ t('views.channels.DetailBase.button.cancel') }}
+                  </button>
+                </div>
+              </semantic-modal>
+            </Layout>
+          </Layout>
+        </Layout>
+        <hr>
+        <TagsList
+          v-if="object.artist?.tags && object.artist?.tags.length > 0"
+          :tags="object.artist.tags"
+        />
+        <Tabs>
+          <Tab
+            :title="t('views.channels.DetailBase.link.channelOverview')"
+            :to="{name: 'channels.detail', params: {id: id}}"
+          >
             <router-view
               v-if="object"
               :object="object"
               @tracks-loaded="totalTracks = $event"
             />
-          </div>
-        </div>
+          </Tab>
+          <Tab
+            :title="t('views.channels.DetailBase.link.channelEpisodes')"
+            :to="{name: 'channels.detail.episodes', params: {id: id}}"
+          >
+            <router-view
+              v-if="object"
+              :object="object"
+              @tracks-loaded="totalTracks = $event"
+            />
+          </Tab>
+        </Tabs>
       </section>
     </template>
-  </main>
+  </Layout>
 </template>
+
+<style scoped>
+  .channel-image {
+    border-radius: 50%;
+  }
+  .meta {
+    line-height: 24px;
+    font-size: 15px;
+  }
+</style>