From a03c785460cce75e62b94c8627b54bc8c2e60373 Mon Sep 17 00:00:00 2001
From: jo <ljonas@riseup.net>
Date: Fri, 16 Dec 2022 03:28:17 +0100
Subject: [PATCH] ci: simplify check missing changelog job

Part-of: <https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/2286>
---
 .gitlab-ci.yml | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 3dcc8998d..ebfdd40f0 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -132,19 +132,19 @@ find_broken_links:
 
 require_changelog:
   interruptible: true
-  image: alpine:3.17
   stage: lint
-  before_script:
-    - apk add git
-    - git fetch origin $CI_MERGE_REQUEST_TARGET_BRANCH_NAME
-  script:
-    - git diff --name-only FETCH_HEAD | grep "changes/changelog.d/*"
   rules:
-    - if: $CI_COMMIT_AUTHOR == 'Renovate Bot <bot@dev.funkwhale.audio>'
+    # Don't run on merge request that mention NOCHANGELOG or renovate bot commits
+    - if: >
+        $CI_MERGE_REQUEST_TITLE =~ /NOCHANGELOG/ ||
+        $CI_COMMIT_AUTHOR == "Renovate Bot <bot@dev.funkwhale.audio>"
       when: never
-    - if: $CI_MERGE_REQUEST_TITLE =~ /NOCHANGELOG/
-      when: never
-    - if: $CI_PIPELINE_SOURCE == 'merge_request_event'
+    - if: $CI_PIPELINE_SOURCE == "merge_request_event"
+
+  image: python:3.11
+  script:
+    - git fetch origin "$CI_MERGE_REQUEST_TARGET_BRANCH_NAME"
+    - git diff --name-only FETCH_HEAD | grep "changes/changelog.d/*"
 
 pre-commit:
   extends: [.pre-commit]