From 9ed6213a464092f7da6bbeaefc09a9f340078edc Mon Sep 17 00:00:00 2001
From: wvffle <funkwhale@wvffle.net>
Date: Fri, 1 Jul 2022 12:21:57 +0000
Subject: [PATCH] Cleanup qs.stringify comments

---
 front/src/components/library/Radios.vue                  | 6 +-----
 front/src/components/manage/ChannelsTable.vue            | 4 ----
 front/src/components/manage/library/AlbumsTable.vue      | 5 +----
 front/src/components/manage/library/ArtistsTable.vue     | 4 ----
 front/src/components/manage/library/EditsCardList.vue    | 4 ----
 front/src/components/manage/library/LibrariesTable.vue   | 4 ----
 front/src/components/manage/library/TagsTable.vue        | 4 ----
 front/src/components/manage/library/TracksTable.vue      | 4 ----
 front/src/components/manage/library/UploadsTable.vue     | 4 ----
 front/src/components/manage/moderation/AccountsTable.vue | 4 ----
 front/src/components/manage/moderation/DomainsTable.vue  | 4 ----
 front/src/components/manage/users/InvitationsTable.vue   | 4 ----
 front/src/components/manage/users/UsersTable.vue         | 4 ----
 front/src/views/admin/moderation/ReportsList.vue         | 4 ----
 front/src/views/admin/moderation/RequestsList.vue        | 4 ----
 front/src/views/content/libraries/FilesTable.vue         | 4 ----
 front/src/views/playlists/List.vue                       | 6 +-----
 17 files changed, 3 insertions(+), 70 deletions(-)

diff --git a/front/src/components/library/Radios.vue b/front/src/components/library/Radios.vue
index e7157f27b..4e3c593cd 100644
--- a/front/src/components/library/Radios.vue
+++ b/front/src/components/library/Radios.vue
@@ -70,10 +70,6 @@ const fetchData = async () => {
   try {
     const response = await axios.get('radios/radios/', {
       params
-      // TODO (wvffle): Check if params should be serialized. In other similar components (Podcasts, Artists) they are
-      // paramsSerializer: function (params) {
-      //   return qs.stringify(params, { indices: false })
-      // }
     })
 
     result.value = response.data
@@ -234,7 +230,7 @@ const labels = computed(() => ({
       </form>
       <div class="ui hidden divider" />
       <div
-        v-if="result && !result.results.length > 0"
+        v-if="result && result.results.length === 0"
         class="ui placeholder segment"
       >
         <div class="ui icon header">
diff --git a/front/src/components/manage/ChannelsTable.vue b/front/src/components/manage/ChannelsTable.vue
index 863875488..b734d45eb 100644
--- a/front/src/components/manage/ChannelsTable.vue
+++ b/front/src/components/manage/ChannelsTable.vue
@@ -51,10 +51,6 @@ const fetchData = async () => {
   try {
     const response = await axios.get('/manage/channels/', {
       params
-      // TODO (wvffle): Check if params should be serialized. In other similar components (Podcasts, Artists) they are
-      // paramsSerializer: function (params) {
-      //   return qs.stringify(params, { indices: false })
-      // }
     })
 
     result.value = response.data
diff --git a/front/src/components/manage/library/AlbumsTable.vue b/front/src/components/manage/library/AlbumsTable.vue
index a74a3d80f..a3ba6af89 100644
--- a/front/src/components/manage/library/AlbumsTable.vue
+++ b/front/src/components/manage/library/AlbumsTable.vue
@@ -10,6 +10,7 @@ import { computed, ref, watch } from 'vue'
 import { useGettext } from 'vue3-gettext'
 
 interface Props extends SmartSearchProps, OrderingProps {
+  // TODO (wvffle): Remove from EVERY SINGLE component that does not use it at all
   // TODO (wvffle): find object type
   filters?: object
 }
@@ -61,10 +62,6 @@ const fetchData = async () => {
   try {
     const response = await axios.get('/manage/library/albums/', {
       params
-      // TODO (wvffle): Check if params should be serialized. In other similar components (Podcasts, Artists) they are
-      // paramsSerializer: function (params) {
-      //   return qs.stringify(params, { indices: false })
-      // }
     })
 
     result.value = response.data
diff --git a/front/src/components/manage/library/ArtistsTable.vue b/front/src/components/manage/library/ArtistsTable.vue
index fd328a3b3..758015e74 100644
--- a/front/src/components/manage/library/ArtistsTable.vue
+++ b/front/src/components/manage/library/ArtistsTable.vue
@@ -59,10 +59,6 @@ const fetchData = async () => {
   try {
     const response = await axios.get('/manage/library/artists/', {
       params
-      // TODO (wvffle): Check if params should be serialized. In other similar components (Podcasts, Artists) they are
-      // paramsSerializer: function (params) {
-      //   return qs.stringify(params, { indices: false })
-      // }
     })
 
     result.value = response.data
diff --git a/front/src/components/manage/library/EditsCardList.vue b/front/src/components/manage/library/EditsCardList.vue
index 638f9eee8..a2c49ea49 100644
--- a/front/src/components/manage/library/EditsCardList.vue
+++ b/front/src/components/manage/library/EditsCardList.vue
@@ -104,10 +104,6 @@ const fetchData = async () => {
   try {
     const response = await axios.get('mutations/', {
       params
-      // TODO (wvffle): Check if params should be serialized. In other similar components (Podcasts, Artists) they are
-      // paramsSerializer: function (params) {
-      //   return qs.stringify(params, { indices: false })
-      // }
     })
 
     result.value = response.data
diff --git a/front/src/components/manage/library/LibrariesTable.vue b/front/src/components/manage/library/LibrariesTable.vue
index 1434833fa..5bbf91d09 100644
--- a/front/src/components/manage/library/LibrariesTable.vue
+++ b/front/src/components/manage/library/LibrariesTable.vue
@@ -61,10 +61,6 @@ const fetchData = async () => {
   try {
     const response = await axios.get('/manage/library/libraries/', {
       params
-      // TODO (wvffle): Check if params should be serialized. In other similar components (Podcasts, Artists) they are
-      // paramsSerializer: function (params) {
-      //   return qs.stringify(params, { indices: false })
-      // }
     })
 
     result.value = response.data
diff --git a/front/src/components/manage/library/TagsTable.vue b/front/src/components/manage/library/TagsTable.vue
index ad70dee23..0f0633372 100644
--- a/front/src/components/manage/library/TagsTable.vue
+++ b/front/src/components/manage/library/TagsTable.vue
@@ -64,10 +64,6 @@ const fetchData = async () => {
   try {
     const response = await axios.get('/manage/tags/', {
       params
-      // TODO (wvffle): Check if params should be serialized. In other similar components (Podcasts, Artists) they are
-      // paramsSerializer: function (params) {
-      //   return qs.stringify(params, { indices: false })
-      // }
     })
 
     result.value = response.data
diff --git a/front/src/components/manage/library/TracksTable.vue b/front/src/components/manage/library/TracksTable.vue
index 1ad7d54af..507ed9c05 100644
--- a/front/src/components/manage/library/TracksTable.vue
+++ b/front/src/components/manage/library/TracksTable.vue
@@ -59,10 +59,6 @@ const fetchData = async () => {
   try {
     const response = await axios.get('/manage/library/tracks/', {
       params
-      // TODO (wvffle): Check if params should be serialized. In other similar components (Podcasts, Artists) they are
-      // paramsSerializer: function (params) {
-      //   return qs.stringify(params, { indices: false })
-      // }
     })
 
     result.value = response.data
diff --git a/front/src/components/manage/library/UploadsTable.vue b/front/src/components/manage/library/UploadsTable.vue
index 8bf5b8e6f..9f0627365 100644
--- a/front/src/components/manage/library/UploadsTable.vue
+++ b/front/src/components/manage/library/UploadsTable.vue
@@ -67,10 +67,6 @@ const fetchData = async () => {
   try {
     const response = await axios.get('/manage/library/uploads/', {
       params
-      // TODO (wvffle): Check if params should be serialized. In other similar components (Podcasts, Artists) they are
-      // paramsSerializer: function (params) {
-      //   return qs.stringify(params, { indices: false })
-      // }
     })
 
     result.value = response.data
diff --git a/front/src/components/manage/moderation/AccountsTable.vue b/front/src/components/manage/moderation/AccountsTable.vue
index 01a9e94de..91341015c 100644
--- a/front/src/components/manage/moderation/AccountsTable.vue
+++ b/front/src/components/manage/moderation/AccountsTable.vue
@@ -60,10 +60,6 @@ const fetchData = async () => {
   try {
     const response = await axios.get('/manage/accounts/', {
       params
-      // TODO (wvffle): Check if params should be serialized. In other similar components (Podcasts, Artists) they are
-      // paramsSerializer: function (params) {
-      //   return qs.stringify(params, { indices: false })
-      // }
     })
 
     result.value = response.data
diff --git a/front/src/components/manage/moderation/DomainsTable.vue b/front/src/components/manage/moderation/DomainsTable.vue
index 524ab23cd..a76dda67c 100644
--- a/front/src/components/manage/moderation/DomainsTable.vue
+++ b/front/src/components/manage/moderation/DomainsTable.vue
@@ -79,10 +79,6 @@ const fetchData = async () => {
   try {
     const response = await axios.get('/manage/federation/domains/', {
       params
-      // TODO (wvffle): Check if params should be serialized. In other similar components (Podcasts, Artists) they are
-      // paramsSerializer: function (params) {
-      //   return qs.stringify(params, { indices: false })
-      // }
     })
 
     result.value = response.data
diff --git a/front/src/components/manage/users/InvitationsTable.vue b/front/src/components/manage/users/InvitationsTable.vue
index a793dda05..546f0cc11 100644
--- a/front/src/components/manage/users/InvitationsTable.vue
+++ b/front/src/components/manage/users/InvitationsTable.vue
@@ -60,10 +60,6 @@ const fetchData = async () => {
   try {
     const response = await axios.get('/manage/users/invitations/', {
       params
-      // TODO (wvffle): Check if params should be serialized. In other similar components (Podcasts, Artists) they are
-      // paramsSerializer: function (params) {
-      //   return qs.stringify(params, { indices: false })
-      // }
     })
 
     result.value = response.data
diff --git a/front/src/components/manage/users/UsersTable.vue b/front/src/components/manage/users/UsersTable.vue
index 894e3cb5c..a08b18283 100644
--- a/front/src/components/manage/users/UsersTable.vue
+++ b/front/src/components/manage/users/UsersTable.vue
@@ -66,10 +66,6 @@ const fetchData = async () => {
   try {
     const response = await axios.get('/manage/users/users/', {
       params
-      // TODO (wvffle): Check if params should be serialized. In other similar components (Podcasts, Artists) they are
-      // paramsSerializer: function (params) {
-      //   return qs.stringify(params, { indices: false })
-      // }
     })
 
     result.value = response.data
diff --git a/front/src/views/admin/moderation/ReportsList.vue b/front/src/views/admin/moderation/ReportsList.vue
index 31f9890cf..36f616107 100644
--- a/front/src/views/admin/moderation/ReportsList.vue
+++ b/front/src/views/admin/moderation/ReportsList.vue
@@ -49,10 +49,6 @@ const fetchData = async () => {
   try {
     const response = await axios.get('manage/moderation/reports/', {
       params
-      // TODO (wvffle): Check if params should be serialized. In other similar components (Podcasts, Artists) they are
-      // paramsSerializer: function (params) {
-      //   return qs.stringify(params, { indices: false })
-      // }
     })
 
     result.value = response.data
diff --git a/front/src/views/admin/moderation/RequestsList.vue b/front/src/views/admin/moderation/RequestsList.vue
index 50ed682b8..d91d8a9af 100644
--- a/front/src/views/admin/moderation/RequestsList.vue
+++ b/front/src/views/admin/moderation/RequestsList.vue
@@ -44,10 +44,6 @@ const fetchData = async () => {
   try {
     const response = await axios.get('manage/moderation/requests/', {
       params
-      // TODO (wvffle): Check if params should be serialized. In other similar components (Podcasts, Artists) they are
-      // paramsSerializer: function (params) {
-      //   return qs.stringify(params, { indices: false })
-      // }
     })
 
     result.value = response.data
diff --git a/front/src/views/content/libraries/FilesTable.vue b/front/src/views/content/libraries/FilesTable.vue
index c81fc2064..0297fe4ae 100644
--- a/front/src/views/content/libraries/FilesTable.vue
+++ b/front/src/views/content/libraries/FilesTable.vue
@@ -86,10 +86,6 @@ const fetchData = async () => {
   try {
     const response = await axios.get('/uploads/', {
       params
-      // TODO (wvffle): Check if params should be serialized. In other similar components (Podcasts, Artists) they are
-      // paramsSerializer: function (params) {
-      //   return qs.stringify(params, { indices: false })
-      // }
     })
 
     result.value = response.data
diff --git a/front/src/views/playlists/List.vue b/front/src/views/playlists/List.vue
index c69390319..d97f11028 100644
--- a/front/src/views/playlists/List.vue
+++ b/front/src/views/playlists/List.vue
@@ -1,7 +1,6 @@
 <script setup lang="ts">
 import axios from 'axios'
 import $ from 'jquery'
-import qs from 'qs'
 import { computed, ref, watch, onMounted } from 'vue'
 import { useRouter, onBeforeRouteUpdate } from 'vue-router'
 import { useGettext } from 'vue3-gettext'
@@ -70,10 +69,7 @@ const fetchData = async () => {
   logger.time('Fetching albums')
   try {
     const response = await axios.get('playlists/', {
-      params,
-      paramsSerializer: function (params) {
-        return qs.stringify(params, { indices: false })
-      }
+      params
     })
 
     result.value = response.data