Merge branch '716-upload-reorder' into 'master'

Fix #716: constant and unpredictable reordering during file upload

See merge request funkwhale/funkwhale!647

changes/changelog.d/716.bugfix

@@ -0,0 +1 @@
+Fixed constant and unpredictable reordering during file upload (#716)

front/src/components/library/FileUpload.vue

@@ -279,15 +279,18 @@ export default {
     },
     sortedFiles() {
       // return errored files on top
-      return this.files.sort(f => {
+
+      return _.sortBy(this.files.map(f => {
+        let statusIndex = 0
         if (f.errored) {
-          return -5;
+          statusIndex = -1
         }
         if (f.success) {
-          return 5;
+          statusIndex = 1
         }
-        return 0;
-      });
+        f.statusIndex = statusIndex
+        return f
+      }), ['statusIndex', 'name'])
     }
   },
   watch: {