From 988f735a978ddb6eb7faa3ee218998f787f7796d Mon Sep 17 00:00:00 2001
From: ArneBo <arne@ecobasa.org>
Date: Thu, 30 Jan 2025 01:12:32 +0100
Subject: [PATCH] fix(front): clean up and fix errors

---
 front/src/components/library/ArtistBase.vue |  2 +-
 front/src/components/library/Artists.vue    |  4 ++--
 front/src/components/library/Podcasts.vue   |  5 +----
 front/src/components/library/Radios.vue     |  2 +-
 front/src/types.ts                          | 12 ------------
 front/src/views/auth/ProfileBase.vue        |  7 +++----
 front/src/views/playlists/List.vue          |  2 +-
 7 files changed, 9 insertions(+), 25 deletions(-)

diff --git a/front/src/components/library/ArtistBase.vue b/front/src/components/library/ArtistBase.vue
index 8cb3a54de..a51d8b8e9 100644
--- a/front/src/components/library/ArtistBase.vue
+++ b/front/src/components/library/ArtistBase.vue
@@ -125,7 +125,7 @@ watch(() => props.id, fetchData, { immediate: true })
 </script>
 
 <template>
-  <Layout stack main>
+  <Layout stack main v-title="labels.title">
     <Loader v-if="isLoading" />
     <template v-if="object && !isLoading">
       <Layout flex>
diff --git a/front/src/components/library/Artists.vue b/front/src/components/library/Artists.vue
index b29037132..09355b3c2 100644
--- a/front/src/components/library/Artists.vue
+++ b/front/src/components/library/Artists.vue
@@ -4,7 +4,7 @@ import type { Artist, BackendResponse } from '~/types'
 import type { RouteRecordName } from 'vue-router'
 import type { OrderingField } from '~/store/ui'
 
-import { computed, ref, watch, onMounted } from 'vue'
+import { computed, ref, watch } from 'vue'
 import { useRouteQuery } from '@vueuse/router'
 import { useI18n } from 'vue-i18n'
 import { syncRef } from '@vueuse/core'
@@ -242,7 +242,7 @@ const paginateOptions = computed(() => sortedUniq([12, 30, 50, paginateBy.value]
         small
         primary
         @click="store.commit('ui/toggleModal', 'upload')"
-        :aria-pressed="store.state.ui.modalsOpen.has('upload') || undefine"
+        :aria-pressed="store.state.ui.modalsOpen.has('upload') || undefined"
       >
         <template #image>
           <i class="bi bi-upload" style="font-size: 100px; position: relative; top: 50px;" />
diff --git a/front/src/components/library/Podcasts.vue b/front/src/components/library/Podcasts.vue
index acea53451..f644a6384 100644
--- a/front/src/components/library/Podcasts.vue
+++ b/front/src/components/library/Podcasts.vue
@@ -4,7 +4,7 @@ import type { Artist, BackendResponse } from '~/types'
 import type { RouteRecordName } from 'vue-router'
 import type { OrderingField } from '~/store/ui'
 
-import { computed, ref, watch, onMounted } from 'vue'
+import { computed, ref, watch } from 'vue'
 import { useRouteQuery } from '@vueuse/router'
 import { useI18n } from 'vue-i18n'
 import { syncRef } from '@vueuse/core'
@@ -59,7 +59,6 @@ const query = ref(q.value)
 syncRef(q, query, { direction: 'ltr' })
 
 const result = ref<BackendResponse<Artist>>()
-const showSubscribeModal = ref(false)
 
 const orderingOptions: [OrderingField, keyof typeof sharedLabels.filters][] = [
   ['creation_date', 'creation_date'],
@@ -115,8 +114,6 @@ const search = () => {
   q.value = query.value
 }
 
-const artistOrdering = ref(false)
-
 onOrderingUpdate(() => {
   page.value = 1
   fetchData()
diff --git a/front/src/components/library/Radios.vue b/front/src/components/library/Radios.vue
index 2695d8e82..69a61a62d 100644
--- a/front/src/components/library/Radios.vue
+++ b/front/src/components/library/Radios.vue
@@ -4,7 +4,7 @@ import type { Radio, BackendResponse } from '~/types'
 import type { RouteRecordName } from 'vue-router'
 import type { OrderingField } from '~/store/ui'
 
-import { computed, onMounted, ref, watch } from 'vue'
+import { computed, ref, watch } from 'vue'
 import { useRouteQuery } from '@vueuse/router'
 import { useI18n } from 'vue-i18n'
 import { syncRef } from '@vueuse/core'
diff --git a/front/src/types.ts b/front/src/types.ts
index 8372e6b2a..bbcaa60b2 100644
--- a/front/src/types.ts
+++ b/front/src/types.ts
@@ -341,24 +341,12 @@ export interface UserRequest {
 }
 
 // Notification stuff
-export type Activity = {
-  actor: Actor
-  creation_date: string
-  related_object: LibraryFollow | UserFollow
-  type: 'Follow' | 'Accept'
-  object: LibraryFollow | UserFollow
-}
 export interface Notification {
   id: number
   is_read: boolean
   activity: Activity
 }
 
-// Tags stuff
-export interface Tag {
-  name: string
-}
-
 // Application stuff
 export interface Application {
   client_id: string
diff --git a/front/src/views/auth/ProfileBase.vue b/front/src/views/auth/ProfileBase.vue
index 52a00f6c8..0b1215dfb 100644
--- a/front/src/views/auth/ProfileBase.vue
+++ b/front/src/views/auth/ProfileBase.vue
@@ -20,7 +20,6 @@ import Tabs from '~/components/ui/Tabs.vue'
 import Tab from '~/components/ui/Tab.vue'
 import LibraryWidget from '~/components/federation/LibraryWidget.vue'
 import ChannelsWidget from '~/components/audio/ChannelsWidget.vue'
-import PlaylistWidget from '~/components/playlists/Widget.vue'
 import AlbumWidget from '~/components/album/Widget.vue'
 import TrackWidget from '~/components/audio/track/Widget.vue'
 
@@ -44,7 +43,7 @@ const store = useStore()
 // We are working either with an Actor or null
 const object = ref<Actor | null>(null)
 
-const actorColor = computed(() => intToRGB(hashCode(object.full_username)))
+const actorColor = computed(() => intToRGB(hashCode(object.value?.full_username)))
 const defaultAvatarStyle = computed(() => ({ backgroundColor: `#${actorColor.value}` }))
 
 const displayName = computed(() => object.value?.name ?? object.value?.preferred_username)
@@ -174,7 +173,7 @@ const recentActivity = ref(0)
 
         <track-widget
           :url="'history/listenings/'"
-          :filters="{ scope: `actor:${object.full_username}`, ordering: '-creation_date', ...qualityFilters}"
+          :filters="{ scope: `actor:${object?.full_username}`, ordering: '-creation_date', ...qualityFilters}"
           :websocket-handlers="['Listen']"
           @count="recentActivity = $event"
         >
@@ -192,7 +191,7 @@ const recentActivity = ref(0)
           </template>
         </track-widget>
 
-        <album-widget :filters="{scope: `actor:${object.full_username}`, playable: true, ordering: '-creation_date', ...qualityFilters}">
+        <album-widget :filters="{scope: `actor:${object?.full_username}`, playable: true, ordering: '-creation_date', ...qualityFilters}">
           <template #title>
             {{ t('components.library.Home.header.recentlyAdded') }}
           </template>
diff --git a/front/src/views/playlists/List.vue b/front/src/views/playlists/List.vue
index 3c0640978..5adb59a0b 100644
--- a/front/src/views/playlists/List.vue
+++ b/front/src/views/playlists/List.vue
@@ -4,7 +4,7 @@ import type { Playlist, BackendResponse } from '~/types'
 import type { RouteRecordName } from 'vue-router'
 import type { OrderingField } from '~/store/ui'
 
-import { computed, ref, watch, onMounted } from 'vue'
+import { computed, ref, watch } from 'vue'
 import { useRouteQuery } from '@vueuse/router'
 import { useI18n } from 'vue-i18n'
 import { syncRef } from '@vueuse/core'