From 966181e48032e2b9ef82f8657a161984c7b9c63e Mon Sep 17 00:00:00 2001 From: ArneBo Date: Sun, 23 Feb 2025 00:26:33 +0100 Subject: [PATCH] feat(style): consistent look and use of artist credit label on detail pages --- .../components/audio/ArtistCreditLabel.vue | 49 +- front/src/components/library/AlbumBase.vue | 209 ++++---- front/src/components/library/ArtistBase.vue | 37 +- front/src/components/library/TrackBase.vue | 481 +++++++++--------- front/src/components/ui/pill.scss | 5 + 5 files changed, 366 insertions(+), 415 deletions(-) diff --git a/front/src/components/audio/ArtistCreditLabel.vue b/front/src/components/audio/ArtistCreditLabel.vue index 74feeb5b5..80589543a 100644 --- a/front/src/components/audio/ArtistCreditLabel.vue +++ b/front/src/components/audio/ArtistCreditLabel.vue @@ -2,7 +2,7 @@ import type { ArtistCredit } from '~/types' import { useStore } from '~/store' -import Link from '~/components/ui/Link.vue' +import Pill from '~/components/ui/Pill.vue' const store = useStore() @@ -23,31 +23,28 @@ const getRoute = (ac: ArtistCredit) => { diff --git a/front/src/components/library/AlbumBase.vue b/front/src/components/library/AlbumBase.vue index 19a8b27d9..c9f46558f 100644 --- a/front/src/components/library/AlbumBase.vue +++ b/front/src/components/library/AlbumBase.vue @@ -69,7 +69,7 @@ const labels = computed(() => ({ const { isShuffled, - shuffle + shuffle, } = useQueue() const isLoading = ref(false) @@ -150,10 +150,7 @@ const remove = async () => { diff --git a/front/src/components/library/ArtistBase.vue b/front/src/components/library/ArtistBase.vue index a0989cef0..5f10e925d 100644 --- a/front/src/components/library/ArtistBase.vue +++ b/front/src/components/library/ArtistBase.vue @@ -25,6 +25,7 @@ import Layout from '~/components/ui/Layout.vue' import Modal from '~/components/ui/Modal.vue' import Spacer from '~/components/ui/Spacer.vue' + interface Props { id: number } @@ -55,7 +56,8 @@ const musicbrainzUrl = computed(() => object.value?.mbid ? `https://musicbrainz. const discogsUrl = computed(() => `https://discogs.com/search/?type=artist&title=${encodeURI(object.value?.name ?? '')}`) const publicLibraries = computed(() => libraries.value?.filter(library => library.privacy_level === 'everyone') ?? []) -const cover = computed(() => { + +const cover = computed(() => { const artistCover: Cover | undefined = object.value?.cover const albumCover: Cover | undefined = object.value?.albums @@ -66,12 +68,12 @@ const cover = computed(() => { )?.cover const fallback : Cover = { - uuid: '', - urls: { - original: `${import.meta.env.BASE_URL}embed-default-cover.jpeg`, - medium_square_crop: `${import.meta.env.BASE_URL}embed-default-cover.jpeg`, - large_square_crop: `${import.meta.env.BASE_URL}embed-default-cover.jpeg` - } + uuid: '', + urls: { + original: `${import.meta.env.BASE_URL}embed-default-cover.jpeg`, + medium_square_crop: `${import.meta.env.BASE_URL}embed-default-cover.jpeg`, + large_square_crop: `${import.meta.env.BASE_URL}embed-default-cover.jpeg` + } } return artistCover @@ -120,11 +122,7 @@ watch(() => props.id, fetchData, { immediate: true })