From 81b40be7f5c565b0505b69bf6aca26f9f63dd216 Mon Sep 17 00:00:00 2001
From: petitminion <pablodurandoz@riseup.net>
Date: Wed, 21 May 2025 16:28:53 +0000
Subject: [PATCH] fix(front):only request playlist.libfollow if not my playlist
 NOCHANGELOG

---
 api/funkwhale_api/contrib/archivedl/tasks.py  |  2 +-
 front/src/App.vue                             |  2 +-
 front/src/components/audio/PlayButton.vue     | 12 +++---
 front/src/components/audio/track/Modal.vue    |  6 +--
 front/src/components/auth/Plugin.vue          | 38 ++++++++++-------
 front/src/components/favorites/List.vue       | 12 +++---
 .../components/federation/LibraryWidget.vue   | 29 +++++++------
 front/src/locales/en_US.json                  |  5 ++-
 front/src/types.ts                            |  1 +
 front/src/ui/modals/Search.vue                |  2 +-
 front/src/utils/utils.ts                      | 17 ++++++--
 front/src/views/auth/PasswordResetConfirm.vue | 41 +++++++++++--------
 front/src/views/auth/Plugins.vue              | 10 ++---
 front/src/views/auth/ProfileOverview.vue      |  9 ----
 14 files changed, 103 insertions(+), 83 deletions(-)

diff --git a/api/funkwhale_api/contrib/archivedl/tasks.py b/api/funkwhale_api/contrib/archivedl/tasks.py
index 7b4096796..51e0d9da4 100644
--- a/api/funkwhale_api/contrib/archivedl/tasks.py
+++ b/api/funkwhale_api/contrib/archivedl/tasks.py
@@ -189,4 +189,4 @@ def filter_files(files, allowed_extensions):
 def get_search_url(query, page_size, page):
     q = urllib.parse.urlencode({"q": query})
     return f"https://archive.org/advancedsearch.php?{q}&sort[]=addeddate+desc&rows={page_size}\
-        &page={page}&output=json&mediatype=audio"
+        &page={page}&output=json"
diff --git a/front/src/App.vue b/front/src/App.vue
index a30cba419..cbe3f3d6e 100644
--- a/front/src/App.vue
+++ b/front/src/App.vue
@@ -122,7 +122,7 @@ store.dispatch('auth/fetchUser')
 .responsive {
   display: grid !important;
   grid-template-rows: min-content;
-  min-height: calc(100vh - 64px);
+  min-height: 100vh;
 
   @media screen and (min-width: 1024px) {
     grid-template-columns: 300px 1fr;
diff --git a/front/src/components/audio/PlayButton.vue b/front/src/components/audio/PlayButton.vue
index dfc8e4600..523cbce71 100644
--- a/front/src/components/audio/PlayButton.vue
+++ b/front/src/components/audio/PlayButton.vue
@@ -108,7 +108,7 @@ const labels = computed(() => ({
 
 const isOpen = ref(false)
 
-const playlistFollowInfo = computed(() => {
+const playlistLibraryFollowInfo = computed(() => {
   const playlist = props.playlist;
   if (!playlist) return null;
 
@@ -268,13 +268,13 @@ const playlistFollowInfo = computed(() => {
         {{ obj.label }}
       </PopoverItem>
       <PopoverItem
-        v-if="playlist && playlistFollowInfo"
-        :title="playlistFollowInfo.tooltip"
-        :icon="playlistFollowInfo.icon"
-        :disabled="playlistFollowInfo.disabled"
+        v-if="playlist && playlistLibraryFollowInfo && store.state.auth.profile && playlist.actor.full_username != store.state.auth.fullUsername"
+        :title="playlistLibraryFollowInfo.tooltip"
+        :icon="playlistLibraryFollowInfo.icon"
+        :disabled="playlistLibraryFollowInfo.disabled"
         @click.stop.prevent="requestPlaylistUploadsAccess(playlist)"
       >
-        {{ playlistFollowInfo.label }}
+        {{ playlistLibraryFollowInfo.label }}
       </PopoverItem>
     </template>
   </Popover>
diff --git a/front/src/components/audio/track/Modal.vue b/front/src/components/audio/track/Modal.vue
index d070e28f5..1fa734214 100644
--- a/front/src/components/audio/track/Modal.vue
+++ b/front/src/components/audio/track/Modal.vue
@@ -7,7 +7,7 @@ import useReport from '~/composables/moderation/useReport'
 import { useStore } from '~/store'
 import { useRouter } from 'vue-router'
 import { useI18n } from 'vue-i18n'
-import { computed, ref } from 'vue'
+import { computed } from 'vue'
 import { useVModel } from '@vueuse/core'
 import { generateTrackCreditString, getArtistCoverUrl } from '~/utils/utils'
 
@@ -50,7 +50,6 @@ const props = withDefaults(defineProps<Props>(), {
   account: null
 })
 
-const modal = ref()
 
 const show = useVModel(props, 'show', emit)
 
@@ -94,11 +93,8 @@ const labels = computed(() => ({
 
 <template>
   <Modal
-    ref="modal"
     v-model="show"
     :title="track.title"
-    :scrolling="true"
-    class="scrolling-track-options"
   >
     <div class="header">
       <div class="ui large centered rounded image">
diff --git a/front/src/components/auth/Plugin.vue b/front/src/components/auth/Plugin.vue
index fcc5765b6..be327e3e6 100644
--- a/front/src/components/auth/Plugin.vue
+++ b/front/src/components/auth/Plugin.vue
@@ -67,20 +67,30 @@ const submitAndScan = async () => {
     :class="['ui form', {loading: isLoading}]"
     @submit.prevent="submit"
   >
-    <h3>{{ plugin.label }}</h3>
-    <sanitized-html
-      v-if="plugin.description"
-      :html="description"
-    />
-    <template v-if="plugin.homepage">
-      <a
-        :href="plugin.homepage"
-        target="_blank"
-      >
-        <i class="external icon" />
-        {{ t('components.auth.Plugin.link.documentation') }}
-      </a>
-    </template>
+    <h2>{{ plugin.label }}</h2>
+    <Alert blue>
+      <Layout flex>
+        <p><i class="bi bi-info-circle-fill" /></p>
+        <Layout
+          stack
+          no-gap
+        >
+          <sanitized-html
+            v-if="plugin.description"
+            :html="description"
+          />
+          <template v-if="plugin.homepage">
+            <a
+              :href="plugin.homepage"
+              target="_blank"
+            >
+              <i class="bi bi-box-arrow-up-right" />
+              {{ t('components.auth.Plugin.link.documentation') }}
+            </a>
+          </template>
+        </Layout>
+      </Layout>
+    </Alert>
     <Alert
       v-if="errors.length > 0"
       red
diff --git a/front/src/components/favorites/List.vue b/front/src/components/favorites/List.vue
index 58b007a29..106d62531 100644
--- a/front/src/components/favorites/List.vue
+++ b/front/src/components/favorites/List.vue
@@ -2,7 +2,7 @@
 import type { OrderingProps } from '~/composables/navigation/useOrdering'
 import type { RouteRecordName } from 'vue-router'
 import type { OrderingField } from '~/store/ui'
-import type { Track } from '~/types'
+import type { UserTrackFavorite } from '~/types'
 
 import { computed, onMounted, reactive, ref, watch } from 'vue'
 import { useI18n } from 'vue-i18n'
@@ -53,7 +53,7 @@ const sharedLabels = useSharedLabels()
 
 const { onOrderingUpdate, orderingString, paginateBy, ordering, orderingDirection } = useOrdering(props)
 
-const results = reactive<Track[]>([])
+const results = reactive<UserTrackFavorite[]>([])
 const nextLink = ref()
 const previousLink = ref()
 const count = ref(0)
@@ -66,7 +66,7 @@ const fetchFavorites = async () => {
     page: page.value,
     page_size: paginateBy.value,
     ordering: orderingString.value,
-    scope: store.state.auth.fullUsername
+    scope: "me"
   }
 
   const measureLoading = logger.time('Loading user favorites')
@@ -76,8 +76,8 @@ const fetchFavorites = async () => {
     results.length = 0
     results.push(...response.data.results)
 
-    for (const track of results) {
-      store.commit('favorites/track', { id: track.id, value: true })
+    for (const trackfavorite of results) {
+      store.commit('favorites/track', { id: trackfavorite.track.id, value: true })
     }
 
     count.value = response.data.count
@@ -225,7 +225,7 @@ const paginateOptions = computed(() => sortedUniq([12, 25, 50, paginateBy.value]
         :search="true"
         :show-artist="true"
         :show-album="true"
-        :tracks="results"
+        :tracks="results.map(r => r.track)"
       />
     </Layout>
     <Alert
diff --git a/front/src/components/federation/LibraryWidget.vue b/front/src/components/federation/LibraryWidget.vue
index 4b075e231..2918d9854 100644
--- a/front/src/components/federation/LibraryWidget.vue
+++ b/front/src/components/federation/LibraryWidget.vue
@@ -2,19 +2,19 @@
 import type { Library } from '~/types'
 
 import { ref, reactive, onMounted, watch } from 'vue'
-import { useStore } from '~/store'
 import { useI18n } from 'vue-i18n'
 
 import axios from 'axios'
 
-import LibraryCard from '~/views/content/remote/Card.vue'
 import Button from '~/components/ui/Button.vue'
 import Section from '~/components/ui/Section.vue'
 import Loader from '~/components/ui/Loader.vue'
 import Alert from '~/components/ui/Alert.vue'
 import Spacer from '~/components/ui/Spacer.vue'
+import ActorLink from '~/components/common/ActorLink.vue'
 
 import useErrorHandler from '~/composables/useErrorHandler'
+import Layout from '../ui/Layout.vue'
 
 interface Events {
   (e: 'loaded', libraries: Library[]): void
@@ -26,7 +26,6 @@ interface Props {
 }
 
 const { t } = useI18n()
-const store = useStore()
 
 const emit = defineEmits<Events>()
 const props = defineProps<Props>()
@@ -67,7 +66,6 @@ watch(() => props.url, () => {
   <Section
     align-left
     :h2="title"
-    :columns-per-item="3"
   >
     <Loader
       v-if="isLoading"
@@ -80,14 +78,21 @@ watch(() => props.url, () => {
     >
       {{ t('components.federation.LibraryWidget.empty.noMatch') }}
     </Alert>
-    <library-card
-      v-for="library in libraries"
-      :key="library.uuid"
-      :display-scan="false"
-      :display-follow="store.state.auth.authenticated && library.actor.full_username != store.state.auth.fullUsername"
-      :initial-library="library"
-      :display-copy-fid="true"
-    />
+    <Layout
+      v-if="!isLoading && libraries.length > 0"
+      flex
+    >
+      {{ t('components.federation.LibraryWidget.main') }}
+      <template
+        v-for="library in libraries"
+        :key="library.uuid"
+      >
+        <ActorLink
+          :actor="library.actor"
+          discrete
+        />
+      </template>
+    </Layout>
     <template v-if="nextPage">
       <Spacer />
       <Button
diff --git a/front/src/locales/en_US.json b/front/src/locales/en_US.json
index 4a4232dcd..fae68bcd4 100644
--- a/front/src/locales/en_US.json
+++ b/front/src/locales/en_US.json
@@ -1414,7 +1414,8 @@
         },
         "empty": {
           "noMatch": "No matching library."
-        }
+        },
+        "main": "This audio object is present in the audio collection of"
       }
     },
     "forms": {
@@ -1445,7 +1446,7 @@
         },
         "header": {
           "episodes": "Episodes",
-          "libraries": "User libraries",
+          "libraries": "On the network",
           "tracks": "Tracks"
         },
         "meta": {
diff --git a/front/src/types.ts b/front/src/types.ts
index b46f873b7..8e9844831 100644
--- a/front/src/types.ts
+++ b/front/src/types.ts
@@ -68,6 +68,7 @@ export type Cover = components['schemas']['CoverField']
 export type RateLimitStatus = components['schemas']['RateLimit']['scopes'][number]
 export type PaginatedAlbumList = components['schemas']['PaginatedAlbumList']
 export type PaginatedChannelList = components['schemas']['PaginatedChannelList']
+export type UserTrackFavorite = components['schemas']['UserTrackFavorite']
 
 export type Artist = components['schemas']['Artist']
 
diff --git a/front/src/ui/modals/Search.vue b/front/src/ui/modals/Search.vue
index 38c49e767..ce47a09cb 100644
--- a/front/src/ui/modals/Search.vue
+++ b/front/src/ui/modals/Search.vue
@@ -155,7 +155,7 @@ const categories = computed(() => [
     type: 'playlists',
     label: t('views.Search.label.playlists'),
     more: '/library/playlists/',
-    endpoint: '/TODO'
+    endpoint: '/playlists'
   },
   {
     type: 'radios',
diff --git a/front/src/utils/utils.ts b/front/src/utils/utils.ts
index 848103ce4..d73551a4d 100644
--- a/front/src/utils/utils.ts
+++ b/front/src/utils/utils.ts
@@ -1,9 +1,8 @@
 import type { Track, Album, ArtistCredit, QueueItemSource } from '~/types'
 import type { components } from '~/generated/types'
-import { useStore } from '~/store'
 import type { QueueTrack } from '~/composables/audio/queue'
+import store from '~/store'
 
-const store = useStore()
 
 export function generateTrackCreditString (track: Track | Album | null): string | null {
   if (!track || !track.artist_credit || track.artist_credit.length === 0) {
@@ -51,5 +50,15 @@ const getSimpleArtistCover = (artist: components['schemas']['SimpleChannelArtist
  * @param artist: a simple artist
  * @param field: the size you want
 */
-export const getSimpleArtistCoverUrl = (artist: components['schemas']['SimpleChannelArtist'] | components['schemas']['Artist'] | components['schemas']['ArtistWithAlbums'], field: 'original' | 'small_square_crop' | 'medium_square_crop' | 'large_square_crop') =>
-  store.getters['instance/absoluteUrl'](getSimpleArtistCover(artist)(field))
+export const getSimpleArtistCoverUrl = (
+  artist: components['schemas']['SimpleChannelArtist'] | components['schemas']['Artist'] | components['schemas']['ArtistWithAlbums'],
+  field: 'original' | 'small_square_crop' | 'medium_square_crop' | 'large_square_crop'
+): string | null => {
+  const coverGetter = getSimpleArtistCover(artist);
+  if (!coverGetter) return null;
+
+  const cover = coverGetter(field);
+  if (!cover) return null;
+
+  return store.getters['instance/absoluteUrl'](cover);
+};
diff --git a/front/src/views/auth/PasswordResetConfirm.vue b/front/src/views/auth/PasswordResetConfirm.vue
index 8f62c4f79..d7ee9bd0d 100644
--- a/front/src/views/auth/PasswordResetConfirm.vue
+++ b/front/src/views/auth/PasswordResetConfirm.vue
@@ -6,7 +6,10 @@ import { computed, ref } from 'vue'
 
 import axios from 'axios'
 
+import Layout from '~/components/ui/Layout.vue'
 import Alert from '~/components/ui/Alert.vue'
+import Input from '~/components/ui/Input.vue'
+import Link from '~/components/ui/Link.vue'
 import Button from '~/components/ui/Button.vue'
 
 interface Props {
@@ -56,15 +59,14 @@ const submit = async () => {
     class="main"
   >
     <h2>{{ labels.changePassword }}</h2>
-    <form
+    <Layout
       v-if="!success"
-      class="ui form"
+      form
       @submit.prevent="submit()"
     >
       <Alert
         v-if="errors.length > 0"
-        role="alert"
-        class="ui negative message"
+        red
       >
         <h4 class="header">
           {{ t('views.auth.PasswordResetConfirm.header.failure') }}
@@ -83,26 +85,33 @@ const submit = async () => {
           <Input
             v-model="newPassword"
             password
-            label="t('views.auth.PasswordResetConfirm.label.newPassword')"
+            :label="t('views.auth.PasswordResetConfirm.label.newPassword')"
           />
         </div>
-        <router-link :to="{path: '/login'}">
-          {{ t('views.auth.PasswordResetConfirm.link.back') }}
-        </router-link>
-        <Button
-          :class="['ui', {'loading': isLoading}, 'right', 'floated', 'success', 'button']"
-          type="submit"
-          auto
-        >
-          {{ t('views.auth.PasswordResetConfirm.button.update') }}
-        </Button>
+        <Layout flex>
+          <Link
+            solid
+            secondary
+            :to="{path: '/login'}"
+          >
+            {{ t('views.auth.PasswordResetConfirm.link.back') }}
+          </Link>
+          <Button
+            :class="['ui', {'loading': isLoading}, 'right', 'floated', 'success', 'button']"
+            type="submit"
+            auto
+            primary
+          >
+            {{ t('views.auth.PasswordResetConfirm.button.update') }}
+          </Button>
+        </Layout>
       </template>
       <template v-else>
         <p>
           {{ t('views.auth.PasswordResetConfirm.message.requestSent') }}
         </p>
       </template>
-    </form>
+    </Layout>
     <Alert
       v-else
       green
diff --git a/front/src/views/auth/Plugins.vue b/front/src/views/auth/Plugins.vue
index ba3ebc9a3..33911af25 100644
--- a/front/src/views/auth/Plugins.vue
+++ b/front/src/views/auth/Plugins.vue
@@ -7,6 +7,7 @@ import axios from 'axios'
 import PluginForm from '~/components/auth/Plugin.vue'
 
 import Layout from '~/components/ui/Layout.vue'
+import Loader from '~/components/ui/Loader.vue'
 
 import useErrorHandler from '~/composables/useErrorHandler'
 
@@ -46,13 +47,10 @@ fetchData()
     main
     stack
   >
-    <h2>{{ labels.title }}</h2>
-    <div
+    <h1>{{ labels.title }}</h1>
+    <Loader
       v-if="isLoading"
-      class="ui inverted active dimmer"
-    >
-      <div class="ui loader" />
-    </div>
+    />
 
     <template v-if="plugins && plugins.length > 0">
       <plugin-form
diff --git a/front/src/views/auth/ProfileOverview.vue b/front/src/views/auth/ProfileOverview.vue
index c2dc10981..0b5e5e67b 100644
--- a/front/src/views/auth/ProfileOverview.vue
+++ b/front/src/views/auth/ProfileOverview.vue
@@ -1,7 +1,6 @@
 <script setup lang="ts">
 import type { Actor } from '~/types'
 
-import LibraryWidget from '~/components/federation/LibraryWidget.vue'
 import ChannelsWidget from '~/components/audio/ChannelsWidget.vue'
 import ChannelForm from '~/components/audio/ChannelForm.vue'
 import { ref } from 'vue'
@@ -59,14 +58,6 @@ const createForm = ref()
         </div>
       </h2>
       <channels-widget :filters="{scope: `actor:${object?.full_username}`}" />
-      <h2 class="ui with-actions header">
-        {{ t('views.auth.ProfileOverview.header.libraries') }}
-      </h2>
-      <library-widget :url="`federation/actors/${object?.full_username}/libraries/`">
-        <template #title>
-          {{ t('views.auth.ProfileOverview.header.sharedLibraries') }}
-        </template>
-      </library-widget>
     </div>
 
     <Modal