From 77ebc5baa54b26b379492ce249a2cb59bf23b989 Mon Sep 17 00:00:00 2001 From: Jo Vuit Date: Sat, 9 Feb 2019 16:06:57 +0100 Subject: [PATCH 1/3] Added 'Hidden text' in the doc as a possible component part for any text that is not displayed. The major use case is aria-label fields. --- CONTRIBUTING.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst index e43adc078..b0e96d6ab 100644 --- a/CONTRIBUTING.rst +++ b/CONTRIBUTING.rst @@ -477,6 +477,7 @@ This hierarchical structure is made of several parts: - ``Table`` - ``Title`` - ``Tooltip`` + - ``Hidden text`` - ``*`` for strings that are not tied to a specific component The detail part, which is optional and refers to the contents of the string itself, such as: From e0f11cc70eac985c02ab723159ea79aa657c989a Mon Sep 17 00:00:00 2001 From: Jo Vuit Date: Sat, 9 Feb 2019 16:08:19 +0100 Subject: [PATCH 2/3] Added translation context --- front/src/views/admin/users/Base.vue | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/front/src/views/admin/users/Base.vue b/front/src/views/admin/users/Base.vue index 41110fb3c..856fa4076 100644 --- a/front/src/views/admin/users/Base.vue +++ b/front/src/views/admin/users/Base.vue @@ -3,10 +3,10 @@ @@ -17,8 +17,8 @@ export default { computed: { labels() { return { - manageUsers: this.$gettext("Manage users"), - secondaryMenu: this.$gettext("Secondary menu") + manageUsers: this.$pgettext('Head/Admin/Title', 'Manage users'), + secondaryMenu: this.$gettext('Menu/*/Hidden text','Secondary menu') } } } From 02c08c6959f90270381997cfa4070d0d0deb328b Mon Sep 17 00:00:00 2001 From: Jo Vuit Date: Sat, 9 Feb 2019 16:26:57 +0100 Subject: [PATCH 3/3] Changed function $gettext to $pgettext --- front/src/views/admin/users/Base.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/front/src/views/admin/users/Base.vue b/front/src/views/admin/users/Base.vue index 856fa4076..1c526d112 100644 --- a/front/src/views/admin/users/Base.vue +++ b/front/src/views/admin/users/Base.vue @@ -18,7 +18,7 @@ export default { labels() { return { manageUsers: this.$pgettext('Head/Admin/Title', 'Manage users'), - secondaryMenu: this.$gettext('Menu/*/Hidden text','Secondary menu') + secondaryMenu: this.$pgettext('Menu/*/Hidden text','Secondary menu') } } }