Merge branch 'fail-graciously-on-empty-media-type' into 'develop'

Fail graciously when AP representation includes a null_value for mediaType

See merge request funkwhale/funkwhale!135
This commit is contained in:
Eliot Berriot 2018-04-17 22:25:40 +00:00
commit 74bd0bae8c
2 changed files with 2 additions and 17 deletions

View File

@ -708,23 +708,7 @@ class AudioSerializer(serializers.Serializer):
except (KeyError, TypeError):
raise serializers.ValidationError('Missing mediaType')
if not media_type.startswith('audio/'):
raise serializers.ValidationError('Invalid mediaType')
return url
def validate_url(self, v):
try:
url = v['href']
except (KeyError, TypeError):
raise serializers.ValidationError('Missing href')
try:
media_type = v['mediaType']
except (KeyError, TypeError):
raise serializers.ValidationError('Missing mediaType')
if not media_type.startswith('audio/'):
if not media_type or not media_type.startswith('audio/'):
raise serializers.ValidationError('Invalid mediaType')
return v

View File

@ -0,0 +1 @@
Fail graciously when AP representation includes a null_value for mediaType