From 73b1dc8f3063c7dccfb50fae4ed39b1ffedd254e Mon Sep 17 00:00:00 2001
From: wvffle <funkwhale@wvffle.net>
Date: Thu, 21 Jul 2022 01:11:36 +0000
Subject: [PATCH] MIgrate some components

---
 front/src/components/audio/ChannelEntries.vue | 135 +++++------
 front/src/views/admin/library/TrackDetail.vue | 227 +++++++++---------
 front/src/views/library/DetailTracks.vue      |  27 +--
 3 files changed, 190 insertions(+), 199 deletions(-)

diff --git a/front/src/components/audio/ChannelEntries.vue b/front/src/components/audio/ChannelEntries.vue
index 4b192eb9c..18ae198c3 100644
--- a/front/src/components/audio/ChannelEntries.vue
+++ b/front/src/components/audio/ChannelEntries.vue
@@ -1,3 +1,59 @@
+<script setup lang="ts">
+import type { Cover, Track, BackendError } from '~/types'
+
+import { clone } from 'lodash-es'
+import { ref, watch } from 'vue'
+
+import axios from 'axios'
+import PodcastTable from '~/components/audio/podcast/Table.vue'
+import TrackTable from '~/components/audio/track/Table.vue'
+
+interface Props {
+  filters: object
+  limit?: number
+  defaultCover: Cover | null
+  isPodcast: boolean
+}
+
+const emit = defineEmits(['fetched'])
+const props = withDefaults(defineProps<Props>(), {
+  limit: 10,
+  defaultCover: null
+})
+
+const channels = ref([] as Track[])
+const nextPage = ref()
+const page = ref(1)
+const count = ref(0)
+const errors = ref([] as string[])
+
+const isLoading = ref(false)
+const fetchData = async () => {
+  isLoading.value = true
+
+  const params = {
+    ...clone(props.filters),
+    page_size: props.limit,
+    page: page.value,
+    include_channels: true
+  }
+
+  try {
+    const response = await axios.get('tracks/', { params })
+    nextPage.value = response.data.next
+    channels.value = response.data.results
+    count.value = response.data.count
+    emit('fetched', response.data)
+  } catch (error) {
+    errors.value = (error as BackendError).backendErrors
+  }
+
+  isLoading.value = false
+}
+
+watch(page, fetchData, { immediate: true })
+</script>
+
 <template>
   <div>
     <slot />
@@ -10,39 +66,37 @@
     </div>
     <podcast-table
       v-if="isPodcast"
+      v-model:page="page"
       :default-cover="defaultCover"
       :is-podcast="isPodcast"
       :show-art="true"
       :show-position="false"
-      :tracks="objects"
+      :tracks="channels"
       :show-artist="false"
       :show-album="false"
       :paginate-results="true"
       :total="count"
-      :page="page"
       :paginate-by="limit"
-      @page-changed="updatePage"
     />
     <track-table
       v-else
+      v-model:page="page"
       :default-cover="defaultCover"
       :is-podcast="isPodcast"
       :show-art="true"
       :show-position="false"
-      :tracks="objects"
+      :tracks="channels"
       :show-artist="false"
       :show-album="false"
       :paginate-results="true"
       :total="count"
-      :page="page"
       :paginate-by="limit"
       :filters="filters"
-      @page-changed="updatePage"
     />
-    <template v-if="!isLoading && objects.length === 0">
+    <template v-if="!isLoading && channels.length === 0">
       <empty-state
         :refresh="true"
-        @refresh="fetchData('tracks/')"
+        @refresh="fetchData()"
       >
         <p>
           <translate translate-context="Content/Channels/*">
@@ -53,68 +107,3 @@
     </template>
   </div>
 </template>
-
-<script>
-import { clone } from 'lodash-es'
-import axios from 'axios'
-import PodcastTable from '~/components/audio/podcast/Table.vue'
-import TrackTable from '~/components/audio/track/Table.vue'
-
-export default {
-  components: {
-    PodcastTable,
-    TrackTable
-  },
-  props: {
-    filters: { type: Object, required: true },
-    limit: { type: Number, default: 10 },
-    defaultCover: { type: Object, default: () => ({}) },
-    isPodcast: { type: Boolean, required: true }
-  },
-  data () {
-    return {
-      objects: [],
-      count: 0,
-      isLoading: false,
-      errors: [],
-      nextPage: null,
-      page: 1
-    }
-  },
-  watch: {
-    page () {
-      this.fetchData('tracks/')
-    }
-  },
-  created () {
-    this.fetchData('tracks/')
-  },
-  methods: {
-    async fetchData (url) {
-      if (!url) {
-        return
-      }
-      this.isLoading = true
-      const self = this
-      const params = clone(this.filters)
-      params.page_size = this.limit
-      params.page = this.page
-      params.include_channels = true
-      try {
-        const channelsPromise = await axios.get(url, { params: params })
-        self.nextPage = channelsPromise.data.next
-        self.objects = channelsPromise.data.results
-        self.count = channelsPromise.data.count
-        self.$emit('fetched', channelsPromise.data)
-        self.isLoading = false
-      } catch (e) {
-        self.isLoading = false
-        self.errors = e.backendErrors
-      }
-    },
-    updatePage: function (page) {
-      this.page = page
-    }
-  }
-}
-</script>
diff --git a/front/src/views/admin/library/TrackDetail.vue b/front/src/views/admin/library/TrackDetail.vue
index 3658b8bae..26f9fdda8 100644
--- a/front/src/views/admin/library/TrackDetail.vue
+++ b/front/src/views/admin/library/TrackDetail.vue
@@ -1,3 +1,74 @@
+<script setup lang="ts">
+import { humanSize, truncate } from '~/utils/filters'
+import { ref, computed } from 'vue'
+import { useGettext } from 'vue3-gettext'
+import { useRouter } from 'vue-router'
+
+import axios from 'axios'
+import FetchButton from '~/components/federation/FetchButton.vue'
+import TagsList from '~/components/tags/List.vue'
+
+interface Props {
+  id: number
+}
+
+const props = defineProps<Props>()
+
+const { $pgettext } = useGettext()
+const labels = computed(() => ({
+  statsWarning: $pgettext('Content/Moderation/Help text', 'Statistics are computed from known activity and content on your instance, and do not reflect general activity for this object')
+}))
+
+const track = ref()
+const isLoading = ref(false)
+const fetchData = async () => {
+  isLoading.value = true
+
+  try {
+    const response = await axios.get(`manage/library/tracks/${props.id}/`)
+    track.value = response.data
+  } catch (error) {
+    // TODO (wvffle): Handle error
+  }
+
+  isLoading.value = false
+}
+
+const stats = ref()
+const isLoadingStats = ref(false)
+const fetchStats = async () => {
+  isLoadingStats.value = true
+
+  try {
+    const response = await axios.get(`manage/library/tracks/${props.id}/stats/`)
+    stats.value = response.data
+  } catch (error) {
+    // TODO (wvffle): Handle error
+  }
+
+  isLoadingStats.value = false
+}
+
+fetchData()
+fetchStats()
+
+const router = useRouter()
+const remove = async () => {
+  isLoading.value = true
+
+  try {
+    await axios.delete(`manage/library/tracks/${props.id}/`)
+    await router.push({ name: 'manage.library.tracks' })
+  } catch (error) {
+    // TODO (wvffle): Handle error
+  }
+
+  isLoading.value = false
+}
+
+const getQuery = (field: string, value: string) => `${field}:"${value}"`
+</script>
+
 <template>
   <main>
     <div
@@ -6,9 +77,9 @@
     >
       <div :class="['ui', 'centered', 'active', 'inline', 'loader']" />
     </div>
-    <template v-if="object">
+    <template v-if="track">
       <section
-        v-title="object.title"
+        v-title="track.title"
         :class="['ui', 'head', 'vertical', 'stripe', 'segment']"
       >
         <div class="ui stackable one column grid">
@@ -16,8 +87,8 @@
             <div class="segment-content">
               <h2 class="ui header">
                 <img
-                  v-if="object.cover && object.cover.urls.medium_square_crop"
-                  v-lazy="$store.getters['instance/absoluteUrl'](object.cover.urls.medium_square_crop)"
+                  v-if="track.cover && track.cover.urls.medium_square_crop"
+                  v-lazy="$store.getters['instance/absoluteUrl'](track.cover.urls.medium_square_crop)"
                   alt=""
                 >
                 <img
@@ -26,9 +97,9 @@
                   src="../../../assets/audio/default-cover.png"
                 >
                 <div class="content">
-                  {{ truncate(object.title) }}
+                  {{ truncate(track.title) }}
                   <div class="sub header">
-                    <template v-if="object.is_local">
+                    <template v-if="track.is_local">
                       <span class="ui tiny accent label">
                         <i class="home icon" />
                         <translate translate-context="Content/Moderation/*/Short, Noun">Local</translate>
@@ -39,11 +110,11 @@
                 </div>
               </h2>
 
-              <template v-if="object.tags && object.tags.length > 0">
+              <template v-if="track.tags && track.tags.length > 0">
                 <tags-list
                   :limit="5"
                   detail-route="manage.library.tags.detail"
-                  :tags="object.tags"
+                  :tags="track.tags"
                 />
                 <div class="ui hidden divider" />
               </template>
@@ -52,7 +123,7 @@
                 <div class="ui icon buttons">
                   <router-link
                     class="ui icon labeled button"
-                    :to="{name: 'library.tracks.detail', params: {id: object.id }}"
+                    :to="{name: 'library.tracks.detail', params: {id: track.id }}"
                   >
                     <i class="info icon" />
                     <translate translate-context="Content/Moderation/Link/Verb">
@@ -68,7 +139,7 @@
                       <a
                         v-if="$store.state.auth.profile && $store.state.auth.profile.is_superuser"
                         class="basic item"
-                        :href="$store.getters['instance/absoluteUrl'](`/api/admin/music/track/${object.id}`)"
+                        :href="$store.getters['instance/absoluteUrl'](`/api/admin/music/track/${track.id}`)"
                         target="_blank"
                         rel="noopener noreferrer"
                       >
@@ -76,9 +147,9 @@
                         <translate translate-context="Content/Moderation/Link/Verb">View in Django's admin</translate>&nbsp;
                       </a>
                       <a
-                        v-if="object.mbid"
+                        v-if="track.mbid"
                         class="basic item"
-                        :href="`https://musicbrainz.org/recording/${object.mbid}`"
+                        :href="`https://musicbrainz.org/recording/${track.mbid}`"
                         target="_blank"
                         rel="noopener noreferrer"
                       >
@@ -86,9 +157,9 @@
                         <translate translate-context="Content/Moderation/Link/Verb">Open on MusicBrainz</translate>&nbsp;
                       </a>
                       <fetch-button
-                        v-if="!object.is_local"
+                        v-if="!track.is_local"
                         class="basic item"
-                        :url="`tracks/${object.id}/fetches/`"
+                        :url="`tracks/${track.id}/fetches/`"
                         @refresh="fetchData"
                       >
                         <i class="refresh icon" />&nbsp;
@@ -98,7 +169,7 @@
                       </fetch-button>
                       <a
                         class="basic item"
-                        :href="object.url || object.fid"
+                        :href="track.url || track.fid"
                         target="_blank"
                         rel="noopener noreferrer"
                       >
@@ -110,8 +181,8 @@
                 </div>
                 <div class="ui buttons">
                   <router-link
-                    v-if="object.is_local"
-                    :to="{name: 'library.tracks.edit', params: {id: object.id }}"
+                    v-if="track.is_local"
+                    :to="{name: 'library.tracks.edit', params: {id: track.id }}"
                     class="ui labeled icon button"
                   >
                     <i class="edit icon" />
@@ -179,44 +250,44 @@
                       </translate>
                     </td>
                     <td>
-                      {{ object.title }}
+                      {{ track.title }}
                     </td>
                   </tr>
-                  <tr v-if="object.album">
+                  <tr v-if="track.album">
                     <td>
-                      <router-link :to="{name: 'manage.library.albums.detail', params: {id: object.album.id }}">
+                      <router-link :to="{name: 'manage.library.albums.detail', params: {id: track.album.id }}">
                         <translate translate-context="*/*/*">
                           Album
                         </translate>
                       </router-link>
                     </td>
                     <td>
-                      {{ object.album.title }}
+                      {{ track.album.title }}
                     </td>
                   </tr>
 
                   <tr>
                     <td>
-                      <router-link :to="{name: 'manage.library.artists.detail', params: {id: object.artist.id }}">
+                      <router-link :to="{name: 'manage.library.artists.detail', params: {id: track.artist.id }}">
                         <translate translate-context="*/*/*/Noun">
                           Artist
                         </translate>
                       </router-link>
                     </td>
                     <td>
-                      {{ object.artist.name }}
+                      {{ track.artist.name }}
                     </td>
                   </tr>
-                  <tr v-if="object.album">
+                  <tr v-if="track.album">
                     <td>
-                      <router-link :to="{name: 'manage.library.artists.detail', params: {id: object.album.artist.id }}">
+                      <router-link :to="{name: 'manage.library.artists.detail', params: {id: track.album.artist.id }}">
                         <translate translate-context="*/*/*/Noun">
                           Album artist
                         </translate>
                       </router-link>
                     </td>
                     <td>
-                      {{ object.album.artist.name }}
+                      {{ track.album.artist.name }}
                     </td>
                   </tr>
                   <tr>
@@ -226,52 +297,52 @@
                       </translate>
                     </td>
                     <td>
-                      {{ object.position }}
+                      {{ track.position }}
                     </td>
                   </tr>
-                  <tr v-if="object.disc_number">
+                  <tr v-if="track.disc_number">
                     <td>
                       <translate translate-context="*/*/*/Noun">
                         Disc number
                       </translate>
                     </td>
                     <td>
-                      {{ object.disc_number }}
+                      {{ track.disc_number }}
                     </td>
                   </tr>
-                  <tr v-if="object.copyright">
+                  <tr v-if="track.copyright">
                     <td>
                       <translate translate-context="Content/Track/*/Noun">
                         Copyright
                       </translate>
                     </td>
-                    <td>{{ object.copyright }}</td>
+                    <td>{{ track.copyright }}</td>
                   </tr>
-                  <tr v-if="object.license">
+                  <tr v-if="track.license">
                     <td>
                       <translate translate-context="Content/*/*/Noun">
                         License
                       </translate>
                     </td>
                     <td>
-                      <router-link :to="{name: 'manage.library.tracks', query: {q: getQuery('license', object.license)}}">
-                        {{ object.license }}
+                      <router-link :to="{name: 'manage.library.tracks', query: {q: getQuery('license', track.license)}}">
+                        {{ track.license }}
                       </router-link>
                     </td>
                   </tr>
-                  <tr v-if="!object.is_local">
+                  <tr v-if="!track.is_local">
                     <td>
-                      <router-link :to="{name: 'manage.moderation.domains.detail', params: {id: object.domain }}">
+                      <router-link :to="{name: 'manage.moderation.domains.detail', params: {id: track.domain }}">
                         <translate translate-context="Content/Moderation/*/Noun">
                           Domain
                         </translate>
                       </router-link>
                     </td>
                     <td>
-                      {{ object.domain }}
+                      {{ track.domain }}
                     </td>
                   </tr>
-                  <tr v-if="object.description">
+                  <tr v-if="track.description">
                     <td>
                       <translate translate-context="'*/*/*/Noun">
                         Description
@@ -279,7 +350,7 @@
                     </td>
                     <sanitized-html 
                       tag="td"
-                      :html="object.description.html" 
+                      :html="track.description.html" 
                     />
                   </tr>
                 </tbody>
@@ -318,7 +389,7 @@
                       </translate>
                     </td>
                     <td>
-                      <human-date :date="object.creation_date" />
+                      <human-date :date="track.creation_date" />
                     </td>
                   </tr>
                   <tr>
@@ -353,7 +424,7 @@
                   </tr>
                   <tr>
                     <td>
-                      <router-link :to="{name: 'manage.moderation.reports.list', query: {q: getQuery('target', `track:${object.id}`) }}">
+                      <router-link :to="{name: 'manage.moderation.reports.list', query: {q: getQuery('target', `track:${track.id}`) }}">
                         <translate translate-context="Content/Moderation/Table.Label/Noun">
                           Linked reports
                         </translate>
@@ -365,7 +436,7 @@
                   </tr>
                   <tr>
                     <td>
-                      <router-link :to="{name: 'manage.library.edits', query: {q: getQuery('target', 'track ' + object.id)}}">
+                      <router-link :to="{name: 'manage.library.edits', query: {q: getQuery('target', 'track ' + track.id)}}">
                         <translate translate-context="*/Admin/*/Noun">
                           Edits
                         </translate>
@@ -427,7 +498,7 @@
 
                   <tr>
                     <td>
-                      <router-link :to="{name: 'manage.library.libraries', query: {q: getQuery('track_id', object.id) }}">
+                      <router-link :to="{name: 'manage.library.libraries', query: {q: getQuery('track_id', track.id) }}">
                         <translate translate-context="*/*/*/Noun">
                           Libraries
                         </translate>
@@ -439,7 +510,7 @@
                   </tr>
                   <tr>
                     <td>
-                      <router-link :to="{name: 'manage.library.uploads', query: {q: getQuery('track_id', object.id) }}">
+                      <router-link :to="{name: 'manage.library.uploads', query: {q: getQuery('track_id', track.id) }}">
                         <translate translate-context="*/*/*">
                           Uploads
                         </translate>
@@ -458,71 +529,3 @@
     </template>
   </main>
 </template>
-
-<script>
-import axios from 'axios'
-import FetchButton from '~/components/federation/FetchButton.vue'
-import TagsList from '~/components/tags/List.vue'
-import { humanSize, truncate } from '~/utils/filters'
-
-export default {
-  components: {
-    FetchButton,
-    TagsList
-  },
-  props: { id: { type: Number, required: true } },
-  setup () {
-    return { humanSize, truncate }
-  },
-  data () {
-    return {
-      isLoading: true,
-      isLoadingStats: false,
-      object: null,
-      stats: null
-    }
-  },
-  computed: {
-    labels () {
-      return {
-        statsWarning: this.$pgettext('Content/Moderation/Help text', 'Statistics are computed from known activity and content on your instance, and do not reflect general activity for this object')
-      }
-    }
-  },
-  created () {
-    this.fetchData()
-    this.fetchStats()
-  },
-  methods: {
-    fetchData () {
-      const self = this
-      this.isLoading = true
-      const url = `manage/library/tracks/${this.id}/`
-      axios.get(url).then(response => {
-        self.object = response.data
-        self.isLoading = false
-      })
-    },
-    fetchStats () {
-      const self = this
-      this.isLoadingStats = true
-      const url = `manage/library/tracks/${this.id}/stats/`
-      axios.get(url).then(response => {
-        self.stats = response.data
-        self.isLoadingStats = false
-      })
-    },
-    remove () {
-      const self = this
-      this.isLoading = true
-      const url = `manage/library/tracks/${this.id}/`
-      axios.delete(url).then(response => {
-        self.$router.push({ name: 'manage.library.tracks' })
-      })
-    },
-    getQuery (field, value) {
-      return `${field}:"${value}"`
-    }
-  }
-}
-</script>
diff --git a/front/src/views/library/DetailTracks.vue b/front/src/views/library/DetailTracks.vue
index 435b52b14..8983a0991 100644
--- a/front/src/views/library/DetailTracks.vue
+++ b/front/src/views/library/DetailTracks.vue
@@ -1,3 +1,16 @@
+<script setup lang="ts">
+import type { Library } from '~/types'
+
+import TrackTable from '~/components/audio/track/Table.vue'
+
+interface Props {
+  object: Library
+  isOwner: boolean
+}
+
+defineProps<Props>()
+</script>
+
 <template>
   <section>
     <track-table
@@ -27,17 +40,3 @@
     </track-table>
   </section>
 </template>
-
-<script>
-import TrackTable from '~/components/audio/track/Table.vue'
-
-export default {
-  components: {
-    TrackTable
-  },
-  props: {
-    object: { type: [Object, String], required: true },
-    isOwner: { type: Boolean, required: true }
-  }
-}
-</script>