MirrorMirror
/
funkwhale
mirror of https://dev.funkwhale.audio/funkwhale/funkwhale.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix #1037: More resilient tag parsing with empty release date or album artist

This commit is contained in:
Eliot Berriot 2020-03-09 17:21:15 +01:00
parent 4845a9f9d5
commit 66a9a62376
No known key found for this signature in database
GPG Key ID: 6B501DFD73514E14
3 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
api/funkwhale_api/music/metadata.py
View File

@ -648,7 +648,7 @@ class MBIDField(serializers.UUIDField):
class ArtistSerializer(serializers.Serializer): class ArtistSerializer(serializers.Serializer):
name = serializers.CharField(required=False, allow_null=True) name = serializers.CharField(required=False, allow_null=True, allow_blank=True)
mbid = MBIDField() mbid = MBIDField()
def __init__(self, *args, **kwargs): def __init__(self, *args, **kwargs):
@ -664,7 +664,9 @@ class ArtistSerializer(serializers.Serializer):
class AlbumSerializer(serializers.Serializer): class AlbumSerializer(serializers.Serializer):
title = serializers.CharField(required=False, allow_null=True) title = serializers.CharField(required=False, allow_null=True)
mbid = MBIDField() mbid = MBIDField()
release_date = PermissiveDateField(required=False, allow_null=True) release_date = PermissiveDateField(
required=False, allow_null=True, allow_blank=True
)
def validate_title(self, v): def validate_title(self, v):
if self.context.get("strict", True) and not v: if self.context.get("strict", True) and not v:

1
api/tests/music/test_metadata.py
View File

@ -247,6 +247,7 @@ def test_can_get_metadata_from_flac_file_not_crash_if_empty():
("2017-14-01 01:32", datetime.date(2017, 1, 14)), # deezer format ("2017-14-01 01:32", datetime.date(2017, 1, 14)), # deezer format
("2017-02", datetime.date(2017, 1, 1)), # weird format that exists ("2017-02", datetime.date(2017, 1, 1)), # weird format that exists
("0000", None), ("0000", None),
("", None),
("nonsense", None), ("nonsense", None),
], ],
) )

1
changes/changelog.d/1037.bugfix Normal file
View File

@ -0,0 +1 @@
More resilient tag parsing with empty release date or album artist (#1037)