From 611631213afce3069b8495ae4e2829b08807f248 Mon Sep 17 00:00:00 2001
From: Marie <robloxfilmcam@gmail.com>
Date: Mon, 2 Jun 2025 14:35:28 +0200
Subject: [PATCH] fix(api): openSubsonic not returning as boolean NOCHANGELOG

---
 api/funkwhale_api/subsonic/renderers.py | 3 ++-
 api/tests/subsonic/test_renderers.py    | 8 ++++----
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/api/funkwhale_api/subsonic/renderers.py b/api/funkwhale_api/subsonic/renderers.py
index b715526e0..3c8b4c029 100644
--- a/api/funkwhale_api/subsonic/renderers.py
+++ b/api/funkwhale_api/subsonic/renderers.py
@@ -42,7 +42,7 @@ def structure_payload(data):
         "status": "ok",
         "type": "funkwhale",
         "version": "1.16.0",
-        "openSubsonic": "true",
+        "openSubsonic": True,
     }
     payload.update(data)
     if "detail" in payload:
@@ -70,6 +70,7 @@ class SubsonicXMLRenderer(renderers.JSONRenderer):
             return super().render(data, accepted_media_type, renderer_context)
         final = structure_payload(data)
         final["xmlns"] = "http://subsonic.org/restapi"
+        final["openSubsonic"] = "true"
         tree = dict_to_xml_tree("subsonic-response", final)
         return b'<?xml version="1.0" encoding="UTF-8"?>\n' + ET.tostring(
             tree, encoding="utf-8"
diff --git a/api/tests/subsonic/test_renderers.py b/api/tests/subsonic/test_renderers.py
index c404555da..73392d37c 100644
--- a/api/tests/subsonic/test_renderers.py
+++ b/api/tests/subsonic/test_renderers.py
@@ -18,7 +18,7 @@ from funkwhale_api.subsonic import renderers
                 "type": "funkwhale",
                 "funkwhaleVersion": funkwhale_api.__version__,
                 "serverVersion": funkwhale_api.__version__,
-                "openSubsonic": "true",
+                "openSubsonic": True,
                 "hello": "world",
             },
         ),
@@ -33,7 +33,7 @@ from funkwhale_api.subsonic import renderers
                 "type": "funkwhale",
                 "funkwhaleVersion": funkwhale_api.__version__,
                 "serverVersion": funkwhale_api.__version__,
-                "openSubsonic": "true",
+                "openSubsonic": True,
                 "hello": "world",
                 "error": {"code": 10, "message": "something went wrong"},
             },
@@ -46,7 +46,7 @@ from funkwhale_api.subsonic import renderers
                 "type": "funkwhale",
                 "funkwhaleVersion": funkwhale_api.__version__,
                 "serverVersion": funkwhale_api.__version__,
-                "openSubsonic": "true",
+                "openSubsonic": True,
                 "hello": "world",
                 "error": {"code": 0, "message": "something went wrong"},
             },
@@ -66,7 +66,7 @@ def test_json_renderer():
             "type": "funkwhale",
             "funkwhaleVersion": funkwhale_api.__version__,
             "serverVersion": funkwhale_api.__version__,
-            "openSubsonic": "true",
+            "openSubsonic": True,
             "hello": "world",
         }
     }