From 60c6a1938f83183b158b4f78f7d31509c0fac635 Mon Sep 17 00:00:00 2001
From: Ciaran Ainsworth <ciaranainsworth@outlook.com>
Date: Mon, 21 Feb 2022 19:52:16 +0100
Subject: [PATCH] Fix some linting issues

---
 front/src/components/Queue.vue                | 11 ++--
 front/src/components/ShortcutsModal.vue       |  4 +-
 front/src/components/admin/SettingsGroup.vue  |  4 +-
 front/src/components/audio/Player.vue         | 11 ++--
 front/src/components/common/ContentForm.vue   |  4 +-
 front/src/components/globals.js               | 57 ++++++++++++-------
 .../src/components/moderation/ReportModal.vue |  7 ++-
 front/src/store/auth.js                       |  2 +-
 8 files changed, 62 insertions(+), 38 deletions(-)

diff --git a/front/src/components/Queue.vue b/front/src/components/Queue.vue
index 921927f9e..c1da216f1 100644
--- a/front/src/components/Queue.vue
+++ b/front/src/components/Queue.vue
@@ -348,14 +348,15 @@ import moment from 'moment'
 import lodash from '@/lodash'
 import time from '@/utils/time.js'
 import { createFocusTrap } from 'focus-trap'
+import TrackFavoriteIcon from '@/components/favorites/TrackFavoriteIcon.vue'
+import TrackPlaylistIcon from '@/components/playlists/TrackPlaylistIcon.vue'
+import draggable from 'vuedraggable'
 
 export default {
   components: {
-    TrackFavoriteIcon: () =>
-    import('@/components/favorites/TrackFavoriteIcon.vue'),
-    TrackPlaylistIcon: () =>
-    import('@/components/playlists/TrackPlaylistIcon.vue'),
-    draggable: () => import('vuedraggable')
+    TrackFavoriteIcon,
+    TrackPlaylistIcon,
+    draggable
   },
   data () {
     return {
diff --git a/front/src/components/ShortcutsModal.vue b/front/src/components/ShortcutsModal.vue
index a0ad671dc..c75976c68 100644
--- a/front/src/components/ShortcutsModal.vue
+++ b/front/src/components/ShortcutsModal.vue
@@ -60,9 +60,11 @@
 
 <script>
 
+import Modal from '@/components/semantic/Modal.vue'
+
 export default {
   components: {
-    Modal: () => import('@/components/semantic/Modal.vue')
+    Modal
   },
   props: { show: { type: Boolean, required: true } },
   computed: {
diff --git a/front/src/components/admin/SettingsGroup.vue b/front/src/components/admin/SettingsGroup.vue
index 4ee4603cd..4f0330a36 100644
--- a/front/src/components/admin/SettingsGroup.vue
+++ b/front/src/components/admin/SettingsGroup.vue
@@ -157,12 +157,12 @@
 
 <script>
 import axios from 'axios'
-
 import lodash from '@/lodash'
+import SignupFormBuilder from '@/components/admin/SignupFormBuilder.vue'
 
 export default {
   components: {
-    SignupFormBuilder: () => import(/* webpackChunkName: "signup-form-builder" */ '@/components/admin/SignupFormBuilder.vue')
+    SignupFormBuilder
   },
   props: {
     group: { type: Object, required: true },
diff --git a/front/src/components/audio/Player.vue b/front/src/components/audio/Player.vue
index a75284751..1baf54683 100644
--- a/front/src/components/audio/Player.vue
+++ b/front/src/components/audio/Player.vue
@@ -348,14 +348,15 @@ import { Howl, Howler } from 'howler'
 import _ from '@/lodash'
 import url from '@/utils/url'
 import axios from 'axios'
+import VolumeControl from './VolumeControl.vue'
+import TrackFavoriteIcon from '@/components/favorites/TrackFavoriteIcon.vue'
+import  TrackPlaylistIcon from '@/components/playlists/TrackPlaylistIcon.vue'
 
 export default {
   components: {
-    VolumeControl: () => import('./VolumeControl.vue'),
-    TrackFavoriteIcon: () =>
-    import('@/components/favorites/TrackFavoriteIcon.vue'),
-    TrackPlaylistIcon: () =>
-    import('@/components/playlists/TrackPlaylistIcon.vue'),
+    VolumeControl,
+    TrackFavoriteIcon,
+    TrackPlaylistIcon,
     GlobalEvents
   },
   data () {
diff --git a/front/src/components/common/ContentForm.vue b/front/src/components/common/ContentForm.vue
index 29f333341..98eef54a8 100644
--- a/front/src/components/common/ContentForm.vue
+++ b/front/src/components/common/ContentForm.vue
@@ -143,8 +143,8 @@ export default {
       try {
         const response = await axios.post('text-preview/', { text: this.newValue, permissive: this.permissive })
         this.preview = response.data.rendered
-      } catch {
-
+      } catch (error) {
+        console.error(error);
       }
       this.isLoadingPreview = false
     }
diff --git a/front/src/components/globals.js b/front/src/components/globals.js
index 69b07b715..f69bde4d5 100644
--- a/front/src/components/globals.js
+++ b/front/src/components/globals.js
@@ -1,23 +1,42 @@
 import Vue from 'vue'
+import HumanDate from '@/components/common/HumanDate.vue'
+import HumanDuration from '@/components/common/HumanDuration.vue'
+import Username from '@/components/common/Username.vue'
+import UserLink from '@/components/common/UserLink.vue'
+import ActorLink from '@/components/common/ActorLink.vue'
+import ActorAvatar from '@/components/common/ActorAvatar.vue'
+import Duration from '@/components/common/Duration.vue'
+import DangerousButton from '@/components/common/DangerousButton.vue'
+import Message from '@/components/common/Message.vue'
+import CopyInput from '@/components/common/CopyInput.vue'
+import AjaxButton from '@/components/common/AjaxButton.vue'
+import Tooltip from '@/components/common/Tooltip.vue'
+import EmptyState from '@/components/common/EmptyState.vue'
+import ExpandableDiv from '@/components/common/ExpandableDiv.vue'
+import CollapseLink from '@/components/common/CollapseLink.vue'
+import ActionFeedback from '@/components/common/ActionFeedback.vue'
+import RenderedDescription from '@/components/common/RenderedDescription.vue'
+import ContentForm from '@/components/common/ContentForm.vue'
+import InlineSearchBar from '@/components/common/InlineSearchBar.vue'
 
-Vue.component('HumanDate', () => import('@/components/common/HumanDate.vue'))
-Vue.component('HumanDuration', () => import('@/components/common/HumanDuration.vue'))
-Vue.component('Username', () => import('@/components/common/Username.vue'))
-Vue.component('UserLink', () => import('@/components/common/UserLink.vue'))
-Vue.component('ActorLink', () => import('@/components/common/ActorLink.vue'))
-Vue.component('ActorAvatar', () => import('@/components/common/ActorAvatar.vue'))
-Vue.component('Duration', () => import('@/components/common/Duration.vue'))
-Vue.component('DangerousButton', () => import('@/components/common/DangerousButton.vue'))
-Vue.component('Message', () => import('@/components/common/Message.vue'))
-Vue.component('CopyInput', () => import('@/components/common/CopyInput.vue'))
-Vue.component('AjaxButton', () => import('@/components/common/AjaxButton.vue'))
-Vue.component('Tooltip', () => import('@/components/common/Tooltip.vue'))
-Vue.component('EmptyState', () => import('@/components/common/EmptyState.vue'))
-Vue.component('ExpandableDiv', () => import('@/components/common/ExpandableDiv.vue'))
-Vue.component('CollapseLink', () => import('@/components/common/CollapseLink.vue'))
-Vue.component('ActionFeedback', () => import('@/components/common/ActionFeedback.vue'))
-Vue.component('RenderedDescription', () => import('@/components/common/RenderedDescription.vue'))
-Vue.component('ContentForm', () => import('@/components/common/ContentForm.vue'))
-Vue.component('InlineSearchBar', () => import('@/components/common/InlineSearchBar.vue'))
+Vue.component('HumanDate', HumanDate)
+Vue.component('HumanDuration', HumanDuration)
+Vue.component('Username', Username)
+Vue.component('UserLink', UserLink)
+Vue.component('ActorLink', ActorLink)
+Vue.component('ActorAvatar', ActorAvatar)
+Vue.component('Duration', Duration)
+Vue.component('DangerousButton', DangerousButton)
+Vue.component('Message', Message)
+Vue.component('CopyInput', CopyInput)
+Vue.component('AjaxButton', AjaxButton)
+Vue.component('Tooltip', Tooltip)
+Vue.component('EmptyState', EmptyState)
+Vue.component('ExpandableDiv', ExpandableDiv)
+Vue.component('CollapseLink', CollapseLink)
+Vue.component('ActionFeedback', ActionFeedback)
+Vue.component('RenderedDescription', RenderedDescription)
+Vue.component('ContentForm', ContentForm)
+Vue.component('InlineSearchBar', InlineSearchBar)
 
 export default {}
diff --git a/front/src/components/moderation/ReportModal.vue b/front/src/components/moderation/ReportModal.vue
index ae59d9e2c..244f30a7c 100644
--- a/front/src/components/moderation/ReportModal.vue
+++ b/front/src/components/moderation/ReportModal.vue
@@ -156,6 +156,8 @@
 <script>
 import axios from 'axios'
 import { mapState } from 'vuex'
+import ReportCategoryDropdown from '@/components/moderation/ReportCategoryDropdown.vue'
+import Modal from '@/components/semantic/Modal.vue'
 
 function urlDomain (data) {
   const a = document.createElement('a')
@@ -165,9 +167,8 @@ function urlDomain (data) {
 
 export default {
   components: {
-    ReportCategoryDropdown: () =>
-    import('@/components/moderation/ReportCategoryDropdown.vue'),
-    Modal: () => import('@/components/semantic/Modal.vue')
+    ReportCategoryDropdown,
+    Modal
   },
   data () {
     return {
diff --git a/front/src/store/auth.js b/front/src/store/auth.js
index 6df59fd9d..0ce58c74c 100644
--- a/front/src/store/auth.js
+++ b/front/src/store/auth.js
@@ -152,7 +152,7 @@ export default {
     async logout ({ state, commit }) {
       try {
         await axios.post('users/logout')
-      } catch {
+      } catch (error) {
         console.log('Error while logging out, probably logged in via oauth')
       }
       const modules = [