MirrorMirror
/
funkwhale
mirror of https://dev.funkwhale.audio/funkwhale/funkwhale.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixed broken error handling on user login and settings

This commit is contained in:
Eliot Berriot 2018-02-24 14:28:48 +01:00
parent 0ed3f68305
commit 55b38a3f6e
No known key found for this signature in database
GPG Key ID: DD6965E2476E5C27
2 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
front/src/components/auth/Login.vue
View File

@ -73,9 +73,9 @@ export default {
// to properly make use of http in the auth service // to properly make use of http in the auth service
this.$store.dispatch('auth/login', { this.$store.dispatch('auth/login', {
credentials, credentials,
next: this.next, next: '/library',
onError: response => { onError: error => {
if (response.status === 400) { if (error.response.status === 400) {
self.error = 'invalid_credentials' self.error = 'invalid_credentials'
} else { } else {
self.error = 'unknown_error' self.error = 'unknown_error'

13
front/src/components/auth/Settings.vue
View File

@ -37,7 +37,6 @@
<script> <script>
import axios from 'axios' import axios from 'axios'
import config from '@/config'
import logger from '@/logging' import logger from '@/logging'
export default { export default {
@ -61,12 +60,16 @@ export default {
new_password1: this.new_password, new_password1: this.new_password,
new_password2: this.new_password new_password2: this.new_password
} }
let url = config.BACKEND_URL + 'api/auth/registration/change-password/' let url = 'auth/registration/change-password/'
return axios.post(url, credentials).then(response => { return axios.post(url, credentials).then(response => {
logger.default.info('Password successfully changed') logger.default.info('Password successfully changed')
self.$router.push('/profile/me') self.$router.push({
}, response => { name: 'profile',
if (response.status === 400) { params: {
username: self.$store.state.auth.username
}})
}, error => {
if (error.response.status === 400) {
self.error = 'invalid_credentials' self.error = 'invalid_credentials'
} else { } else {
self.error = 'unknown_error' self.error = 'unknown_error'