From 406e852bea00f56e13c6f04cf995ce8e5eb6cbb4 Mon Sep 17 00:00:00 2001
From: ArneBo <arne@ecobasa.org>
Date: Wed, 5 Feb 2025 13:30:17 +0100
Subject: [PATCH] refactor(front): profile base tabs routerview

---
 front/src/views/auth/ProfileActivity.vue | 87 +++++++++++++-----------
 front/src/views/auth/ProfileBase.vue     | 47 ++-----------
 front/src/views/auth/ProfileOverview.vue |  4 +-
 3 files changed, 54 insertions(+), 84 deletions(-)

diff --git a/front/src/views/auth/ProfileActivity.vue b/front/src/views/auth/ProfileActivity.vue
index 182dae8dd..b9ce4b902 100644
--- a/front/src/views/auth/ProfileActivity.vue
+++ b/front/src/views/auth/ProfileActivity.vue
@@ -2,9 +2,11 @@
 import type { Actor } from '~/types'
 
 import { ref } from 'vue'
+import { useI18n } from 'vue-i18n'
 
 import PlaylistWidget from '~/components/playlists/Widget.vue'
 import TrackWidget from '~/components/audio/track/Widget.vue'
+import AlbumWidget from '~/components/album/Widget.vue'
 import RadioButton from '~/components/radios/Button.vue'
 
 interface Props {
@@ -14,49 +16,52 @@ interface Props {
 defineProps<Props>()
 
 const recentActivity = ref(0)
+
+const { t } = useI18n()
 </script>
 
 <template>
-  <section>
-    <div>
-      <radio-button
-        v-if="recentActivity > 0"
-        class="right floated"
-        type="account"
-        :object-id="{username: object.preferred_username, fullUsername: object.full_username}"
-        :client-only="true"
-      />
-      <h2 class="ui header">
-        {{ t('views.auth.ProfileActivity.header.recentlyListened') }}
-      </h2>
-      <div class="ui divider" />
-      <track-widget
-        :url="'history/listenings/'"
-        :filters="{scope: `actor:${object.full_username}`, ordering: '-creation_date'}"
-        @count="recentActivity = $event"
-      />
-    </div>
-    <div class="ui hidden divider" />
-    <div>
-      <h2 class="ui header">
-        {{ t('views.auth.ProfileActivity.header.recentlyFavorited') }}
-      </h2>
-      <div class="ui divider" />
-      <track-widget
-        :url="'favorites/tracks/'"
-        :filters="{scope: `actor:${object.full_username}`, ordering: '-creation_date'}"
-      />
-    </div>
-    <div class="ui hidden divider" />
-    <div>
-      <h2 class="ui header">
+  <Layout stack>
+    <radio-button
+      v-if="recentActivity > 0"
+      class="right floated"
+      type="account"
+      :object-id="{username: object.preferred_username, fullUsername: object.full_username}"
+      :client-only="true"
+    />
+    <track-widget
+      :url="'history/listenings/'"
+      :filters="{ scope: `actor:${object?.full_username}`, ordering: '-creation_date', ...qualityFilters}"
+      :websocket-handlers="['Listen']"
+      @count="recentActivity = $event"
+    >
+      <template #title>
+        {{ t('components.library.Home.header.recentlyListened') }}
+      </template>
+    </track-widget>
+
+    <track-widget
+      :url="'favorites/tracks/'"
+      :filters="{scope: 'actor:${object.full_username}', ordering: '-creation_date'}"
+    >
+      <template #title>
+        {{ t('components.library.Home.header.recentlyFavorited') }}
+      </template>
+    </track-widget>
+
+    <playlist-widget
+      :url="'playlists/'"
+      :filters="{scope: `actor:${object.full_username}`, playable: true, ordering: '-modification_date'}"
+    >
+      <template #title>
         {{ t('views.auth.ProfileActivity.header.playlists') }}
-      </h2>
-      <div class="ui divider" />
-      <playlist-widget
-        :url="'playlists/'"
-        :filters="{scope: `actor:${object.full_username}`, playable: true, ordering: '-modification_date'}"
-      />
-    </div>
-  </section>
+      </template>
+    </playlist-widget>
+
+    <album-widget :filters="{scope: `actor:${object?.full_username}`, playable: true, ordering: '-creation_date', ...qualityFilters}">
+      <template #title>
+        {{ t('components.library.Home.header.recentlyAdded') }}
+      </template>
+    </album-widget>
+  </Layout>
 </template>
diff --git a/front/src/views/auth/ProfileBase.vue b/front/src/views/auth/ProfileBase.vue
index f4700eacc..9deb313db 100644
--- a/front/src/views/auth/ProfileBase.vue
+++ b/front/src/views/auth/ProfileBase.vue
@@ -20,9 +20,6 @@ import Tabs from '~/components/ui/Tabs.vue'
 import Tab from '~/components/ui/Tab.vue'
 import LibraryWidget from '~/components/federation/LibraryWidget.vue'
 import ChannelsWidget from '~/components/audio/ChannelsWidget.vue'
-import AlbumWidget from '~/components/album/Widget.vue'
-import TrackWidget from '~/components/audio/track/Widget.vue'
-import PlaylistWidget from '~/components/playlists/Widget.vue'
 
 interface Events {
   (e: 'updated', value: Actor): void
@@ -133,10 +130,10 @@ const recentActivity = ref(0)
     <Tabs>
       <Tab :title="t('views.auth.ProfileBase.link.overview')" :to="{name: 'profile.overview', params: routerParams}">
         <h2>{{ t('views.auth.ProfileBase.link.overview') }}</h2>
-        <!-- <router-view
+        <router-view
           :object="object"
           @updated="fetchData"
-        /> -->
+        />
       </Tab>
 
       <Tab :title="t('views.auth.ProfileOverview.header.libraries')">
@@ -175,42 +172,10 @@ const recentActivity = ref(0)
       </Tab>
 
       <Tab :title="t('views.auth.ProfileBase.link.activity')" :to="{name: 'profile.activity', params: routerParams}">
-        <Layout stack>
-          <track-widget
-            :url="'history/listenings/'"
-            :filters="{ scope: `actor:${object?.full_username}`, ordering: '-creation_date', ...qualityFilters}"
-            :websocket-handlers="['Listen']"
-            @count="recentActivity = $event"
-          >
-            <template #title>
-              {{ t('components.library.Home.header.recentlyListened') }}
-            </template>
-          </track-widget>
-
-          <track-widget
-            :url="'favorites/tracks/'"
-            :filters="{scope: 'actor:${object.full_username}', ordering: '-creation_date'}"
-          >
-            <template #title>
-              {{ t('components.library.Home.header.recentlyFavorited') }}
-            </template>
-          </track-widget>
-
-          <playlist-widget
-            :url="'playlists/'"
-            :filters="{scope: `actor:${object.full_username}`, playable: true, ordering: '-modification_date'}"
-          >
-            <template #title>
-              {{ t('views.auth.ProfileActivity.header.playlists') }}
-            </template>
-          </playlist-widget>
-
-          <album-widget :filters="{scope: `actor:${object?.full_username}`, playable: true, ordering: '-creation_date', ...qualityFilters}">
-            <template #title>
-              {{ t('components.library.Home.header.recentlyAdded') }}
-            </template>
-          </album-widget>
-        </Layout>
+        <router-view
+          :object="object"
+          @updated="fetchData"
+        />
       </Tab>
     </Tabs>
   </Layout>
diff --git a/front/src/views/auth/ProfileOverview.vue b/front/src/views/auth/ProfileOverview.vue
index c98ce3037..c1fad8de7 100644
--- a/front/src/views/auth/ProfileOverview.vue
+++ b/front/src/views/auth/ProfileOverview.vue
@@ -58,7 +58,7 @@ const createForm = ref()
             href=""
             @click.stop.prevent="showCreateModal = true"
           >
-            <i class="plus icon" />
+            <i class="bi bi-plus" />
             {{ t('views.auth.ProfileOverview.link.addNew') }}
           </a>
         </div>
@@ -71,7 +71,7 @@ const createForm = ref()
           class="actions"
         >
           <router-link :to="{name: 'content.libraries.index'}">
-            <i class="plus icon" />
+            <i class="bi bi-plus" />
             {{ t('views.auth.ProfileOverview.link.addNew') }}
           </router-link>
         </div>