MirrorMirror
/
funkwhale
mirror of https://dev.funkwhale.audio/funkwhale/funkwhale.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add missing playable serializer

This commit is contained in:
Ciarán Ainsworth 2021-05-09 05:38:55 +00:00 committed by Georg Krause
parent e67faee3ef
commit 0176b29dae
No known key found for this signature in database
GPG Key ID: FD479B9A4D48E632
3 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
api/funkwhale_api/music/serializers.py
View File

@ -201,7 +201,6 @@ class AlbumSerializer(OptionalDescriptionMixin, serializers.Serializer):
release_date = serializers.DateField() release_date = serializers.DateField()
creation_date = serializers.DateTimeField() creation_date = serializers.DateTimeField()
is_local = serializers.BooleanField() is_local = serializers.BooleanField()
is_playable = serializers.SerializerMethodField()
get_attributed_to = serialize_attributed_to get_attributed_to = serialize_attributed_to
@ -302,6 +301,7 @@ class TrackSerializer(OptionalDescriptionMixin, serializers.Serializer):
license = serializers.SerializerMethodField() license = serializers.SerializerMethodField()
cover = cover_field cover = cover_field
get_attributed_to = serialize_attributed_to get_attributed_to = serialize_attributed_to
is_playable = serializers.SerializerMethodField()
def get_artist(self, o): def get_artist(self, o):
return serialize_artist_simple(o.artist) return serialize_artist_simple(o.artist)
@ -323,6 +323,9 @@ class TrackSerializer(OptionalDescriptionMixin, serializers.Serializer):
def get_license(self, o): def get_license(self, o):
return o.license_id return o.license_id
def get_is_playable(self, obj):
return bool(getattr(obj, "playable_uploads", []))
@common_serializers.track_fields_for_update("name", "description", "privacy_level") @common_serializers.track_fields_for_update("name", "description", "privacy_level")
class LibraryForOwnerSerializer(serializers.ModelSerializer): class LibraryForOwnerSerializer(serializers.ModelSerializer):

1
api/tests/music/test_serializers.py
View File

@ -255,6 +255,7 @@ def test_track_serializer(factories, to_api_date):
"attributed_to": federation_serializers.APIActorSerializer(actor).data, "attributed_to": federation_serializers.APIActorSerializer(actor).data,
"cover": common_serializers.AttachmentSerializer(track.attachment_cover).data, "cover": common_serializers.AttachmentSerializer(track.attachment_cover).data,
"downloads_count": track.downloads_count, "downloads_count": track.downloads_count,
"is_playable": bool(track.playable_uploads),
} }
serializer = serializers.TrackSerializer(track) serializer = serializers.TrackSerializer(track)
assert serializer.data == expected assert serializer.data == expected

1
changes/changelog.d/playable.bugfix Normal file
View File

@ -0,0 +1 @@
Added missing is_playable serializer for the tracks endpoint.