de37141812
Add a crawler that expires old backups
2024-04-01 13:45:21 -05:00
de9eaa98db
404 instead of 400 on unknown source cdn
2024-03-27 17:00:37 -05:00
37b657cbbd
avoid baos::writeTo on virtual threads
2024-03-27 16:58:38 -05:00
8a587d1d12
Rename `NoiseStreamHandler` to `NoiseTransportHandler` for consistency with Noise specification terminology
2024-03-27 17:57:46 -04:00
aec6ac019f
Introduce a Noise-over-WebSocket client connection manager
2024-03-22 15:20:55 -04:00
075a08884b
Preserve backupCredentialRequest across rereg
2024-03-22 14:19:35 -05:00
6fcb2ab5dd
Remove username phased rollout plumbing (usernames are now available to everybody)
2024-03-21 13:42:20 -04:00
7f0f045f29
Minor cleanup of report spam endpoint ( #1979 )
2024-03-21 10:41:25 -07:00
e7d1eadf8e
Fix experiments in BackupAuthManager
2024-03-20 11:43:07 -05:00
2c2b5d555e
Rename obsolete uses of recaptcha
2024-03-13 16:40:32 -05:00
0ab2428d87
Don't produce zkgroup auth creds with PNI as ACI
2024-03-13 16:22:45 -05:00
8574494573
Support "captcha" rename in AnswerChallengeRequest.type
2024-03-13 16:19:05 -05:00
3dadaf9334
Migrate DynamicConfigurationManager to use java.util.concurrent
2024-03-08 13:53:28 -06:00
9e510a678c
disable response buffering on the websocket
...
Jersey buffers responses (by default up to 8192 bytes) just so it can
add a content length to responses. We already buffer our responses to
serialize them as protos, so we can compute the content length
ourselves. Setting the buffer to zero disables buffering.
2024-03-08 13:46:00 -06:00
9f6a6d7f5b
Include HTTP/2 stream idle timeouts in IOExceptionMapper
2024-03-06 11:11:39 -06:00
3cc740cda3
Temporarily hold a username after an account releases it
2024-03-06 11:09:25 -06:00
47b24b5dff
Simplify username operations in `Accounts`
...
- Group username table constants together
- Rethrow JsonProcessingException earlier
- Use UpdateAccountSpec.forAccount in username operations
- Inline confirm/clear transaction helpers
2024-03-06 11:09:25 -06:00
8f100a792e
calling: update TurnCallRouter to reduce returned options
2024-03-05 11:26:19 -08:00
2adf1e5017
Avoid modification of Account from `@ReadOnly` endpoint
2024-02-28 15:18:12 -06:00
d1d03f45c5
Resolve warnings throughout `AccountControllerTest`
2024-02-26 16:11:03 -05:00
d018efe2a5
Require non-null proofs in "confirm username hash" requests
2024-02-26 10:30:52 -05:00
12c6af23ee
Map TransactionConflict to ContestedOptimisticLockException in username flows
2024-02-23 14:06:03 -08:00
69330f47fd
Explicitly call spam-filter for verification session updates
...
Pass in the same information to the spam-filter, but just use explicit
method calls rather than jersey request filters.
2024-02-23 16:04:24 -06:00
4f40c128bf
Explicitly call spam-filter for challenges
...
Pass in the same information to the spam-filter, but just use explicit
method calls rather than jersey request filters.
2024-02-23 15:58:52 -06:00
665a26d164
update call routing to return ipv6 ips in RFC3986 format
2024-02-23 11:57:58 -05:00
a5774bf6ff
Introduce a (dormant) Noise/WebSocket for future client/server communication
2024-02-23 11:42:42 -05:00
d2716fe5cf
Add an endpoint for checking that clients and the server have a common view of the client's repeated-use keys
2024-02-23 11:41:58 -05:00
279f877bf2
Validate pre-key signatures via the legacy "set signed pre-key" endpoint
2024-02-23 11:33:41 -05:00
26ffa19f36
Lifecycle management for Account objects reused accross websocket requests
2024-02-22 12:05:32 -06:00
29ef3f0b41
Add tests and metrics for parsing invalid keys
2024-02-21 15:32:25 -05:00
6ac2460eb0
Drop the "key without version byte" counter
2024-02-21 15:32:25 -05:00
4aa4246695
Clear account records from the account cache after username operations
2024-02-20 12:11:29 -05:00
1bebceb29c
Actually fix flaky test in MetricsHttpChannelListenerIntegrationTest
2024-02-20 10:52:04 -06:00
a2139ee236
Revert "Add diagnostic dimensions to the "get keys" counter"
...
This reverts commit cd64390141
2024-02-18 20:14:05 -05:00
8c55f39cdf
Revert "Use a phased enrollment strategy for the `pnp` compatibility flag"
...
This reverts commit 3e12a8780d
2024-02-18 20:08:39 -05:00
0329184c94
Fix flaky test in MetricsHttpChannelListenerIntegrationTest
2024-02-18 20:08:29 -05:00
cd64390141
Add diagnostic dimensions to the "get keys" counter
2024-02-18 18:10:58 -05:00
3e12a8780d
Use a phased enrollment strategy for the `pnp` compatibility flag
2024-02-18 17:59:00 -05:00
9ce2b7555c
Add static servlet paths to MetricsHttpChannelListener
2024-02-14 17:09:30 -06:00
5ff092e541
Retire the `pni` device capability
2024-02-14 18:04:23 -05:00
9745854ab8
Switch MetricsHttpChannelListener to ContainerResponseFilter
2024-02-14 13:43:23 -06:00
7124621f66
Use pre-calculated pre-key counts when possible
2024-02-14 14:28:33 -05:00
40d698f2db
Remove last vestiges of stale capabilities.
...
Not for deployment until 2024-02-06!
2024-02-14 14:23:05 -05:00
699b0c775a
Add dynamic configuration to enable detailed Lettuce metrics
2024-02-13 10:33:43 -06:00
ff59ef8094
Add MetricHttpChannelListener
2024-02-13 10:29:03 -06:00
d1f68eacd9
Add call routing API endpoint for turn servers
2024-02-09 11:12:23 -08:00
4f45f23094
Prevent old versions of the Android app from carrying out "change phone number" requests
2024-02-09 09:58:38 -05:00
c5dc01ee11
Restore high-cardinality Lettuce metrics for debugging
2024-02-08 19:27:56 -05:00
3b44ed6d16
Explicitly call spam-filter for messages
...
Pass in the same information to the spam-filter, but just use explicit
method calls rather than jersey request filters.
2024-02-07 14:30:32 -06:00
0965ab8063
Move HeaderUtils#getMostRecentyProxy to RemoteAddressFilter
2024-02-07 14:28:37 -06:00
2ab14ca59e
Refactor remote address/X-Forwarded-For handling
2024-02-05 13:37:06 -06:00
c838df90ef
Add HttpServletRequestUtil
2024-01-31 17:53:47 -06:00
2d4d37f96a
Translate TransactionCanceledException to ContestedOptimisticLockException in Accounts#changeNumber
2024-01-31 17:27:16 -06:00
50f1ed7851
Add a virtual-thread backed `@ManagedAsyncExecutor`
2024-01-31 14:38:50 -06:00
b483159b3a
reintroduce VirtualThreadPinEventMonitor
2024-01-31 14:28:12 -06:00
480abebf7e
Offload account lock updates to accountLockExecutor
2024-01-31 14:27:16 -06:00
b924dea045
Remove VirtualThreadPinEventMonitor
2024-01-30 13:49:39 -06:00
2c1e7e5ed6
Disable flaky VirtualThreadPinEventMonitorTest
2024-01-30 13:29:58 -06:00
4dfd74906c
Add timeouts to VirtualThreadPinEventMonitorTest
2024-01-30 13:10:43 -06:00
0e6242373e
Add a monitor for virtual thread pin events
2024-01-30 12:48:07 -06:00
36e7772f74
Put some validation on to profile version strings
...
Co-authored-by: Jon Chambers <63609320+jon-signal@users.noreply.github.com>
2024-01-26 15:24:38 -06:00
6c13193623
Add a data store for client public keys for transport-level authentication/encryption
2024-01-26 10:29:59 -05:00
1428ca73de
Make identity token fetcher more async friendly
...
After the identity token expires a subsequent call would do a blocking
operation to retrieve the new token. Since we're making use of an async
gRPC client, this tends to block a thread we don't want to be blocking
on.
Instead, switch to periodically refreshing the token on a dedicated
thread.
2024-01-25 13:01:21 -06:00
498ace0488
Remove iOS special case handling logic for SEPA/iDEAL
2024-01-25 10:52:17 -08:00
595cc55578
Retire the `returnPqKey` flag when fetching pre-keys
2024-01-23 16:01:40 -05:00
21d0ffc990
Allow "reserving" one's own committed username hash
2024-01-23 12:44:55 -08:00
3820a231ec
Strictly enforce ACI service identifier strings have no prefix
2024-01-22 11:23:33 -06:00
f5080f9bd6
Support configurable verification code sender overrides
2024-01-19 13:58:17 -06:00
70134507f8
Add metric for ServiceId string parsing
2024-01-19 13:56:47 -06:00
360a4793ae
Remove global lock in RateLimitChallengeManager
2024-01-19 13:56:09 -06:00
47bfb25f2c
Retire a now-unused transacational update method for accounts
2024-01-18 16:40:21 -05:00
b048b0bf65
Remove signed pre-keys from `Device` entities
2024-01-18 12:13:00 -05:00
394f9929ad
limit size of multi-recipient messages
2024-01-11 16:31:37 -08:00
bf39be3320
Add Content-Type header for copy uploads
2024-01-11 14:59:35 -06:00
cc6cf8194f
Add media deletion endpoint
2024-01-11 10:19:06 -06:00
323bfd9a6e
Remove some secondary keys from account cache
...
Remove e164, usernameHash, and usernameLink secondary mappings from the
accounts redis cache.
2024-01-11 10:10:32 -06:00
bf05e47e26
Get accounts asynchronously when checking SVR credentials via gRPC
2024-01-11 11:09:49 -05:00
d18f576239
Revert "Revert "Treat the stand-alone signed pre-keys table as the source of truth for signed pre-keys""
...
This reverts commit 3f9edfe597
2024-01-10 11:22:10 -05:00
7d483c711a
Revert "Revert "Retire "migrate signed pre-keys" configuration""
...
This reverts commit a024949311
2024-01-10 11:22:10 -05:00
61256d49cd
Revert "Revert "Retire the "migrate signed pre-keys" command""
...
This reverts commit f738bc97e7
2024-01-10 11:22:10 -05:00
184cdc0331
Remove two-stage check of username availability in reserve/confirm
2024-01-09 14:01:42 -08:00
ed972a0037
Fix archive listing directory prefix order
2024-01-09 16:01:11 -06:00
a62a6c1cb6
Change type of Cdn3StorageManagerConfiguration.clientSecret to SecretString
2024-01-08 16:06:54 -06:00
b6ecfc7131
Add archive listing
2024-01-08 13:54:57 -06:00
2b688b1a60
Refactor spam filter's S3MonitoredObject to server parent module.
...
Allows other parts of server to use S3MonitoredObjects.
2024-01-08 10:34:12 -08:00
1e5fadc440
Allow reserving a hash previously reserved (but not committed) by the same user
2024-01-05 15:38:45 -08:00
f495ff483a
Update RemoveExpiredLinkedDevicesCommand to retry failures
2024-01-05 15:38:34 -08:00
e1ad25cee0
Group Send Credential support in chat
2024-01-04 11:38:57 -08:00
195f23c347
Add `/v1/accounts` and `/v2/keys` to the WebSocket
2024-01-02 15:51:57 -06:00
b9dd9fc47d
Reduce fan-out by processing a single stream of expired linked devices
2023-12-22 10:51:06 -06:00
057d1f07a8
Remove bulk "set repeated-use signed pre-keys" methods because they were only ever used for single devices
2023-12-21 12:07:42 -05:00
ca47a7b663
handle new RegistrationService proto error
2023-12-19 18:19:26 -06:00
9d3d4a3698
Add phone-number-sharing field to versioned profile
...
Co-authored-by: Katherine <katherine@signal.org>
2023-12-19 11:20:04 -08:00
3b509bf820
Add command to remove expired linked devices
2023-12-19 13:11:26 -06:00
5b7f91827a
Remove signed pre-keys transactionally when removing devices
2023-12-19 14:11:05 -05:00
a37acd1f42
Add ttl for braintree writes to onetime donation table
2023-12-15 13:37:35 -05:00
b259eea8ce
Refactor/clarify account creation/reclamation process
2023-12-14 16:48:57 -08:00
9cfc2ba09a
Persist onetime donation payment success timestamps for Braintree transactions
2023-12-14 16:48:29 -08:00
3548c3df15
Calculate onetime badge expiration from payment success timestamp
2023-12-14 15:39:46 -05:00
f738bc97e7
Revert "Retire the "migrate signed pre-keys" command"
...
This reverts commit c7cc3002d5
2023-12-13 17:49:55 -05:00
3f9edfe597
Revert "Treat the stand-alone signed pre-keys table as the source of truth for signed pre-keys"
...
This reverts commit feb933b4df
2023-12-13 17:49:55 -05:00
a024949311
Revert "Retire "migrate signed pre-keys" configuration"
...
This reverts commit 44145073f1
2023-12-13 17:49:55 -05:00
8d4acf0330
Remove `ForkJoinPool.managedBlock` in favor of async updates
2023-12-13 10:18:04 -05:00
28a981f29f
Assume that all devices have signed pre-keys
2023-12-13 10:17:51 -05:00
c29113d17a
Reject requests with missing device capabilities
2023-12-12 11:37:44 -05:00
3cbbf37468
Use payment success timestamp to calculate recurring donation badge expiration
2023-12-12 10:01:20 -05:00
6c7a3df5ae
Retire non-atomic device-linking pathways
2023-12-12 09:53:51 -05:00
44145073f1
Retire "migrate signed pre-keys" configuration
2023-12-12 09:53:34 -05:00
feb933b4df
Treat the stand-alone signed pre-keys table as the source of truth for signed pre-keys
2023-12-11 11:39:54 -05:00
c7cc3002d5
Retire the "migrate signed pre-keys" command
2023-12-11 11:07:00 -05:00
3cf1b92dfc
Do not set one-time pre-keys if the lists of new keys are empty
2023-12-08 14:03:08 -05:00
5b0fcbe854
Always expose sequential fluxes to account crawlers
2023-12-08 13:43:42 -05:00
cca747a1f6
Treat transaction conflicts during transactional account updates as contested optimistic locks
2023-12-08 12:13:23 -05:00
417d99a17e
Check story rate limits in parallel
2023-12-08 12:13:08 -05:00
e9708b9259
Use random UUIDs throughout `MessageControllerTest`
2023-12-08 12:13:08 -05:00
e5d3be16b0
Fetch destination accounts in parallel when sending multi-recipient messages
2023-12-08 12:13:08 -05:00
2ab3c97ee8
Replace MultiRecipientMessage parsing with libsignal's implementation
...
Co-authored-by: Jonathan Klabunde Tomer <jkt@signal.org>
2023-12-08 11:52:47 -05:00
4efda89358
multisend cleanup
2023-12-07 12:23:02 -08:00
a843780f68
Add a (failing!) test for device-linking
2023-12-07 13:27:26 -05:00
50d92265ea
Add devices to accounts transactionally
2023-12-07 11:19:40 -05:00
e084a9f2b6
Remove PUT/DELETE methods from RemoteConfigController
2023-12-07 10:54:19 -05:00
4c9efdb936
Revert "Revert "Represent device names as byte arrays""
...
This reverts commit 45848e7bfe
2023-12-07 10:53:56 -05:00
45848e7bfe
Revert "Represent device names as byte arrays"
...
This reverts commit 5ae2e5281a
2023-12-06 17:05:04 -05:00
fc0bc85f4d
Add some extra request validation to `/v1/archives/keys`
2023-12-06 15:11:27 -05:00
5ae2e5281a
Represent device names as byte arrays
2023-12-06 15:10:45 -05:00
00e72a30c9
Assume all accounts have primary devices
2023-12-06 10:28:19 -05:00
df421e0182
Update signed pre-keys in transactions
2023-12-05 14:20:16 -05:00
ede9297139
Disallow identity key changes
2023-12-05 14:14:24 -05:00
4cca7aa4bd
Normalize identity types throughout `KeysController`
2023-12-05 14:14:24 -05:00
e2037dea6c
Rename `PreKeyState` to `SetKeysRequest`
2023-12-05 14:14:24 -05:00
f10f772e94
Convert `PreKeyState` to a record
2023-12-05 14:14:24 -05:00
5f0726af8a
Perform cleanup operations before overwriting an existing account record
2023-12-05 12:18:09 -05:00
331bbdd4e6
replace deprecated apache RandomUtils
2023-12-05 10:48:18 -06:00
37e3bcfc3e
Move "remove device" logic into `AccountsManager`
2023-12-05 11:44:58 -05:00
4f42c10d60
Disallow sync messages to PNIs
2023-12-05 11:44:27 -05:00
20392a567b
Revert "multisend cleanup"
...
This reverts commit c03249b411
2023-12-01 14:39:31 -08:00
c03249b411
multisend cleanup
2023-11-30 15:50:36 -08:00
22e6584402
Add auth controller for SVR3 to /v3/backup.
2023-11-30 15:50:21 -08:00
01fde4f9ca
Require PNI-associated registration IDs for new devices
2023-11-29 16:56:47 -05:00
9c54d2407b
Update tests
2023-11-29 15:48:24 -06:00
a027c4ce1f
Conditionally use `request.remoteAddr` instead of `X-Forwarded-For`
2023-11-29 15:48:24 -06:00
b1fd025ea6
Use EpochSecondSerializer for UserRemoteConfigList.serverEpochTime
2023-11-29 15:47:10 -06:00
f46842c6c9
Validate registration IDs
2023-11-28 15:43:35 -08:00
202dd8e92d
Add copy endpoint to ArchiveController
...
Co-authored-by: Jonathan Klabunde Tomer <125505367+jkt-signal@users.noreply.github.com>
Co-authored-by: Chris Eager <79161849+eager-signal@users.noreply.github.com>
2023-11-28 11:45:41 -06:00
a74438d1ee
Add test for concurrent in-flight outbound messages on WebSocket queue processing
...
This also elevates the implicit default concurrency (via reactor’s `Queues.SMALL_BUFFER_SIZE`) to be explicit.
2023-11-27 14:37:46 -06:00
c8033f875d
Create accounts transactionally
2023-11-27 09:57:43 -05:00
521900c048
Always require atomic account creation
2023-11-27 09:52:57 -05:00
cb1fc734c2
report exceptions in fanned-out sends of multi-recipient messages
2023-11-20 10:46:26 -08:00
84b56ae1b2
Upgrade to dropwizard 3.0
2023-11-16 17:57:48 -06:00
8f7bae54fe
When persisting messages fails due to a full queue in DynamoDB, automatically unlink one device to free up room.
...
Co-authored-by: Chris Eager <79161849+eager-signal@users.noreply.github.com>
2023-11-15 17:15:17 -08:00
7764185c57
return explicit Response rather than Void from async controllers with no expected body content
2023-11-14 21:57:25 -08:00
d4ef2adf0a
Remove low priority attempt login notification workaround for old iOS clients
2023-11-13 12:06:55 -05:00
a83378a44e
add an option to replace username ciphertext without rotating the link handle
2023-11-13 09:01:54 -08:00
a4a4204762
Allow re-registered accounts to reclaim their usernames
2023-11-13 10:41:23 -06:00
71e4351743
Add `sepaMaximumEuros` field to subscription configuration
2023-11-10 09:13:51 -08:00
db63ff6b88
gRPC validations
2023-11-03 11:30:48 -07:00
d47ff9b7c7
don't make empty transactions
2023-11-02 16:20:19 -07:00
2bc4412d66
Encapsulate device ID in ProvisioningAddress
2023-11-02 11:48:10 -05:00
6a428b4da9
Convert Device.id from `long` to `byte`
2023-11-02 11:48:10 -05:00
7299067829
Don't attempt to update PNI PQ prekeys for disabled devices
2023-11-01 16:55:55 -07:00
6b38b538f1
Add ArchiveController
...
Adds endpoints for creating and managing backup objects with ZK
anonymous credentials.
2023-10-30 14:02:19 -05:00
ba139dddd8
Use all devices when checking limit
2023-10-30 12:40:06 -05:00
54bc3bce96
Add an authentication-required gRPC service for working with accounts
2023-10-25 14:47:20 -04:00
e4de6bf4a7
Only update devices that aren't already disabled
2023-10-24 15:29:03 -04:00
6f166425fe
Fix bank mandate test
2023-10-20 16:19:31 -04:00
744eb58071
Discard old chunk-based account crawler machinery
2023-10-20 16:09:17 -04:00
9d47a6f41f
Introduce a reactive push notification feedback processor
2023-10-20 16:09:17 -04:00
fd19299ae0
Accept a captcha score threshold for challenges from the spam filter
2023-10-20 09:09:22 -07:00
f0ab52eb5d
Rename "master device" to "primary device"
2023-10-20 10:52:13 -04:00
6441d5838d
Clear username links in the same transaction when clearing username hashes
2023-10-20 10:51:50 -04:00
ac0c8b1e9a
Introduce a canonical constant for UAK length
2023-10-20 10:50:44 -04:00
5990a100db
Add charge failure details to `/v1/subscription/boost/receipt_credential` 402 response
2023-10-19 10:21:26 -07:00
bc35278684
Drop the old `AccountCleaner`
2023-10-19 10:34:24 -04:00
c3c7329ebb
Add a single-shot command for removing expired accounts
2023-10-19 10:34:24 -04:00
0100f0fcc9
Migrate a username links test from `AccountsTest` to `AccountsManagerUsernameIntegrationTest`
2023-10-18 10:20:48 -04:00
601e9eebbd
Implement an anonymous account service for looking up accounts
2023-10-18 10:14:52 -04:00
eaa868cf06
Add a remote address interceptor to base gRPC tests
2023-10-18 10:14:52 -04:00
b2ff016cc1
Add back story ratelimiter with counter but do not enforce
2023-10-17 12:22:17 -04:00
33b4f17945
Make username-related operations asynchronous
2023-10-17 12:21:52 -04:00
ae976ef8d6
Retire legacy Secure Value Recovery plumbing
2023-10-13 15:32:41 -04:00
c6b4e2b71d
Support iDEAL
2023-10-12 09:54:05 -07:00
e1aa734c40
Define endpoint to get localized bank mandate text
2023-10-05 09:53:33 -07:00
bb7e0528c4
Make account deletion an asynchronous operation
2023-10-04 10:44:50 -04:00
c43e0b54f2
Exclude `SEPA_DEBIT` as a supported payment method for certain iOS client versions
2023-10-03 11:34:52 -07:00
8c7975d89a
Clear presence only if the connection’s displacement listener is still present
2023-10-03 11:42:25 -05:00
7821a3cd61
Accommodate PayPal with SEPA changes
2023-09-28 10:28:17 -07:00
a00c2fcfdb
Support SEPA
2023-09-28 08:26:01 -07:00
8d1135a2a3
Refine `RegistrationController` logic
...
Local device transfer on iOS uses the `409` status code to prompt the
transfer UI. This needs to happen before sending a `423` and locking
an existing account, since the device transfer
includes the local device database verbatim.
2023-09-25 15:54:31 -05:00
f9fabbedce
Convert `SubscriptionController` request/response entities to records
2023-09-25 12:32:49 -07:00
16012e6ffe
Remove obsolete `ManagedPeriodicWork`
2023-09-25 12:15:17 -07:00
d10a132b0c
Remove unused methods in `SubscriptionController`
2023-09-25 12:14:56 -07:00
0b3af7d824
gRPC API for external services credentials service
2023-09-25 12:14:49 -07:00
d0fdae3df7
Enable header-based auth for WebSocket connections
2023-09-25 12:14:40 -07:00
0e989419c6
Add metric for late removal of message availability and displacement listeners
2023-09-19 12:04:24 -05:00
0fa8276d2d
retry hCaptcha errors
...
Co-authored-by: Jon Chambers <63609320+jon-signal@users.noreply.github.com>
2023-09-14 16:07:35 -05:00
9f3ffa3707
gRPC API for payments service
2023-09-14 11:12:00 -07:00
8e598c19dc
don't attempt to update KEM prekeys if we have no PQ-enabled devices
2023-09-14 11:11:22 -07:00
2601d6e906
Convert some fields on `CreateProfileRequest` and `VersionedProfileResponse` to byte arrays
2023-09-13 14:00:03 -07:00
f0544fab89
Update recently-deleted accounts table transactionally as part of account mutations
2023-09-13 16:02:19 -04:00
1b9bf01ab1
Absorb `DeletedAccounts` into `Accounts`
2023-09-13 16:02:19 -04:00
Ravi Khadiwala