51f37350eb
Because one shouldn't take the size of null things
2022-06-17 15:03:25 -05:00
ecfa161da8
Validate the request
2022-06-17 14:32:38 -05:00
e3778c17ea
Use POST not GET for request requiring body
2022-06-17 14:31:15 -05:00
cbc95415b7
Add endpoint to batch check identity keys
2022-06-17 12:20:30 -05:00
327eb0219d
Bypass account registration captcha on test devices
2022-06-13 15:01:46 -07:00
a853748303
Revert "Update ChangeNumber to allow reset of registration IDs."
...
This reverts commit 7001ad1445
2022-06-09 11:51:50 -06:00
7001ad1445
Update ChangeNumber to allow reset of registration IDs.
2022-06-02 16:37:32 -06:00
5cfb133f79
Use redis for abusive hosts autoblock
...
Also delete postgres dependencies that we no longer need
2022-05-31 10:08:10 -05:00
5df24edebf
Remove all unused imports remaining in project
2022-05-25 17:15:20 -05:00
95d0293a96
Remove unused counter
2022-05-25 16:57:01 -05:00
f5a2efb57c
Clarify hidden static method call
2022-05-25 16:51:12 -05:00
e4b9ae4eee
Clear up warnings
2022-05-25 16:50:58 -05:00
bc1ac5a37f
Remove unused fields
2022-05-25 16:50:43 -05:00
96ac56faac
Remove unused import
2022-05-25 16:38:11 -05:00
f0bc444388
Remove unused timer
2022-05-25 16:37:51 -05:00
8584f47d95
Add more metrics to createAccount captcha
2022-05-25 15:50:11 -04:00
f6235b8c08
Check for newly-expired accounts before previously-expired accounts for metric accuracy
2022-05-25 15:49:54 -04:00
d452e90470
Move `AccountCleaner` into its own crawler
2022-05-25 15:46:18 -04:00
418a869451
Increase max deletions per chunk to 256
2022-05-25 14:19:04 -04:00
cf89e2215c
Fully delete already-expired accounts
2022-05-25 14:19:04 -04:00
a4ca1ef1a8
Move `AccountCleanerTest` out of the `test` package; reduce visibility of test-only fields
2022-05-25 14:19:04 -04:00
c38572307d
Remove unused imports
2022-05-20 10:20:45 -07:00
20902df122
Fix ZRANGE arguments in get_items.lua
2022-05-19 12:14:02 -07:00
d31ddb72f3
Optimize message deletion by skipping lookup
2022-05-18 13:02:21 -07:00
75c92eaa93
Drop high-cardinality distribution summaries
2022-05-11 14:26:38 -04:00
0445adcac3
Conclude `ReportMessageManager` ACI migration
2022-05-11 11:26:24 -07:00
06dd4c5026
Derive username from ACI for CDS{H,I} ( #989 )
...
* Derive username from ACI for CDS{H,I}
* Update sample YAML.
2022-05-02 08:41:38 -06:00
058caadf4f
Use BigDecimal#compareTo for numeric equality testing
2022-04-29 14:20:09 -05:00
7b7d309105
Apply stripe conversion factor to gift badge amount check
2022-04-29 13:48:10 -05:00
63be7b93ce
Record level on boost payment intent
2022-04-29 12:06:15 -05:00
578ea12b59
Add gift badges to user capabilities
2022-04-29 11:08:36 -05:00
364e59be57
Add shape to duration to ensure it's render as an integer
2022-04-29 10:14:39 -05:00
fece4dac9e
Add duration to boost badges
...
Lets clients know how long the badge will last for after purchase.
2022-04-29 10:14:39 -05:00
ce85c1aabc
Add name and description for gift badge
2022-04-29 10:14:39 -05:00
0ac2ce5e72
Add gift badge to the level output for boost badges
2022-04-29 10:14:39 -05:00
391c800bf5
Add gift configuration to subscription controller
2022-04-29 10:14:39 -05:00
f6471cf8f9
Add gift configuration source
2022-04-29 10:14:39 -05:00
1eaff753a6
Count "forbidden identity key change" events
2022-04-22 15:53:43 -04:00
c29d5de1eb
Refactor two more switch statements to new switch style
2022-04-19 13:39:38 -05:00
d94c171d63
Use new style switch statement
2022-04-19 13:35:26 -05:00
53203dbcef
Refactor common pattern for checking Account capabilities
2022-04-19 10:33:54 -05:00
9e66f8ac11
Add gift badges device capability
2022-04-19 10:33:54 -05:00
796fb3b4cd
Refactor Device#equals method
2022-04-19 10:33:54 -05:00
473ecbdf2d
Allow primary to set and provide new signed prekeys for linked devices ( #950 )
2022-04-15 12:39:47 -06:00
7b3703506b
Remove number from `ReportMessageManager#store`
2022-04-13 16:41:32 -04:00
5816f76bbe
Add support for getting (limited) profiles by phone number identifier
2022-04-13 16:27:57 -04:00
355996bafc
Add outcome type to subscription information endpoint
2022-04-08 12:31:31 -05:00
c2bb46f41d
Add outcome network status and outcome reason to subscription info
2022-04-08 12:31:31 -05:00
12f76c24b1
Add failure information for the latest charge on a subscription
2022-04-08 12:31:31 -05:00
3dc0d0bb92
Revert "Revert "Replace curve25519-java with libsignal-server""
...
This reverts commit c06a5ac96c
2022-03-29 12:24:45 -04:00
2bb8f92af1
Revert "Revert "Replace zkgroup with libsignal-server""
...
This reverts commit fa3a9570d6
2022-03-29 12:24:45 -04:00
5b7d5d2b93
Reduce "unrecoverable error" messages when sending GCM notifications from WARN to DEBUG
2022-03-25 14:34:44 -07:00
2b27db18d8
Count GCM failures by error code
2022-03-25 14:34:44 -07:00
f3c811cc03
Move "no local subscription" warnings from WARN to DEBUG
2022-03-25 14:34:44 -07:00
77fd01bd9f
Accept source ACI at `/v1/messages/report`
2022-03-25 14:27:09 -07:00
fa3a9570d6
Revert "Replace zkgroup with libsignal-server"
...
This reverts commit 86a09b16ff
2022-03-24 12:11:46 -04:00
c06a5ac96c
Revert "Replace curve25519-java with libsignal-server"
...
This reverts commit 06a57ef811
2022-03-24 12:11:46 -04:00
33467b42da
Remove a deprecated/unused field
2022-03-24 10:50:49 -04:00
13fb641113
Make field name casing consistent
2022-03-24 10:50:49 -04:00
53f17c2baa
Drop the legacy message and relay fields from message entities
2022-03-24 10:50:49 -04:00
06a57ef811
Replace curve25519-java with libsignal-server
...
These APIs stemmed from a common source long ago, so there's not much
to change!
2022-03-24 10:50:18 -04:00
86a09b16ff
Replace zkgroup with libsignal-server
2022-03-24 10:50:18 -04:00
c70d7535b9
Make TURN configuration dynamic
...
Also enables conditionally including more TURN servers for gradual
rollouts
2022-03-23 14:38:02 -05:00
2a832d36d7
Remove AcceptNumericOnlineFlagRequestFilter
2022-03-23 14:31:01 -05:00
1578c89475
Only allow primary device to update identity key.
2022-03-22 14:39:04 -06:00
bab6b36e4d
Count reported messages by destination country code in addition to source country code
2022-03-22 09:56:27 -04:00
f75e616397
Introduce a listener pattern for reported messages
2022-03-22 09:56:27 -04:00
7ba0f604e6
Tag the push challenge request counter by country
2022-03-17 16:07:48 -04:00
cf8a4cc939
Decrease receipt sender executor thread pool
2022-03-17 13:07:03 -07:00
2f6b0b1a55
Tag push challenge attempt metrics by country code
2022-03-16 15:00:04 -04:00
c048074c31
Tag captcha attempt metrics with UA platform
2022-03-16 15:00:04 -04:00
5a88ff0811
Use the async dynamo client to batch uak updates
2022-03-14 14:02:16 -05:00
de68c251f8
Instrument the receipt sender executor
2022-03-11 17:20:52 -08:00
7c9ae3561d
Send delivery receipts asynchronously
2022-03-11 16:34:22 -08:00
b608ece57e
Remove `supportsAnnouncementGroups` metric
2022-03-11 16:18:00 -08:00
8dfffebaf1
Remove unnecessary check for destination UUID
2022-03-11 16:17:54 -08:00
fef37f739b
Remove unused classes and methods
2022-03-10 11:08:38 -05:00
1571f14815
Add a feature flag to disable account normalization
2022-03-09 14:03:21 -06:00
9cb098ad8a
Add a top-level uak to existing items
...
Items wirtten before we started storing the uak at
the top level only store the uak in the
account blob. The will be updated on account
crawl
2022-03-09 14:03:21 -06:00
9b9edbae0e
Drop `DeadLetterHandler` (which is functionally unused)
2022-03-08 10:03:06 -05:00
491155d1cf
Remove `@Consumes` from GET/DELETE in `/v1/subscriptions`
2022-03-04 15:36:02 -08:00
54207254f1
Remove unused configuration
2022-03-04 11:44:17 -08:00
1395dcc0be
Make the enterprise client canonical
2022-03-04 11:44:17 -08:00
2a68d9095d
Remove transitional and legacy client
2022-03-04 11:44:17 -08:00
a984b3640e
Further refine score distribution summary
2022-03-04 11:44:17 -08:00
f6cbc32ee7
Align "link device" and "fetch pre-keys" rate limits
2022-03-04 10:45:06 -05:00
602614acf6
Refine assessment metrics
2022-03-03 16:09:49 -08:00
3854b7d472
Remove `@Consumes` from `GET /v1/config`
2022-03-03 16:08:55 -08:00
5e25481088
Fix a trivial typo in a constant's name
2022-03-03 10:59:19 -05:00
fe86e15d80
Remove PNI repair code
2022-03-03 10:25:11 -05:00
179b4a69eb
Clear one-time pre-keys when PNIs are assigned
2022-03-03 10:24:54 -05:00
eee6307789
Move score floor to dynamic configuration, add distribution summary
2022-03-02 15:18:33 -08:00
9fc5002619
Add stories capability
2022-03-02 15:16:21 -08:00
faa6ae284a
Add uak as a top level attribute
2022-03-02 10:41:09 -06:00
8b4355b21d
Add a "challenge issued" counter tagged by country and platform
2022-03-02 10:40:47 -06:00
e8835da740
Tag captcha success rate counter by country
2022-03-02 10:40:47 -06:00
93d06e3f4d
Fix typos
2022-03-01 14:14:52 -08:00
935e268dec
Parameterize sitekey
2022-03-01 10:40:42 -08:00
3a1c716c73
Remove an unused rate limiter
2022-02-25 13:50:17 -08:00
f3457502a6
Support different v2 captcha actions
2022-02-25 13:49:47 -08:00
d3cd1d1b15
Use GetLatestConfiguration in config manager
...
Use StartConfigurationSession/GetLatestConfiguration instead of
GetConfiguration since the latter has been deprecated
2022-02-23 15:36:33 -06:00
f5a75c6319
Simplify RateLimitExceeded with no retry-duration
...
- Avoid passing negative durations in error cases
- Drop unused message
- Return a duration for a bad forwarded-for
2022-02-23 15:25:24 -06:00
ae3a5c5f5e
Return a Retry-After on rate-limited responses
...
Previously, only endpoints throwing a RetryLaterException would include
a Retry-After header in the 413 response. Now, by default, all
RateLimitExceededExceptions will be marshalled into a 413 with a
Retry-After included if possible.
2022-02-23 15:25:24 -06:00
c367a71223
APNS: include a collapse-id for non-VOIP notifications
...
This has two benefits:
- The APNS server should only send an iOS client a single push
notification for any missed messages while the device is offline
(server-side coalescing). Note that the client can still turn that
into multiple "user notifications" as it pulls from its queue.
- If multiple notifications get delivered but iOS is unable to process
them (say, because the phone just restarted and hasn't been unlocked
yet), the user should only get one "You may have received messages"
notification (client-side coalescing).
2022-02-18 10:41:10 -05:00
d259ef0348
Update rate limit exceeded counter
2022-02-17 13:23:48 -08:00
288cbf4a80
Clean up null-ability of incoming message entity fields
2022-02-17 13:23:48 -08:00
ba5e5a780f
Throw an exception instead of using Optional<Resposne>
2022-02-17 13:23:48 -08:00
73fa3c3fe4
Add test for content length validation
2022-02-17 13:23:48 -08:00
579eb85175
Reject invalid envelope types
2022-02-17 13:23:48 -08:00
b2b20072ae
Add `MicrometerRegistryManager`
2022-02-17 13:18:30 -08:00
a2c4d3fe95
Use a strong reference to the application shutdown gauge
2022-02-17 13:18:30 -08:00
31e2be2e4d
Fixup invalid accept-language counter
...
- Fix name
- Add platform/version tags to the counter
2022-02-10 11:57:25 -06:00
9f5d97e1c6
Silence noisy warnings for invalid Accept-Language
2022-02-10 11:57:25 -06:00
baaae6cd9f
Add `@NotNull` to controller args where appropriate
...
Notably, `@Valid` doesn't imply `@NotNull`
2022-02-10 11:57:04 -06:00
ed398aa7b9
Add `DeviceCapabilities.pni`
2022-02-09 15:56:01 -08:00
6e2ae42dab
Add platform to metrics
2022-02-09 15:55:07 -08:00
41bf2b2c42
Add a binary format for incoming messages
...
The existing, general incoming message endpoint accepts messages as
JSON strings containing base64 data, along with all the metadata as
other JSON keys. That's not very efficient, and we don't make use of
that full generality anyway. This commit introduces a new binary
format that supports everything we're using from the old format (with
the help of some query parameters like multi-recipient messages).
2022-02-07 16:05:03 -08:00
639d634426
Restore displaced UUID from deleted accounts table when present
2022-01-31 13:01:36 -08:00
5358fc4f43
Use `setRegistrationLockFromAttributes`
2022-01-31 12:56:59 -08:00
99eda80a78
Measure rate limit challenge responses by platform
2022-01-27 16:05:52 -05:00
cbbdea1ba4
Impose more stringent requirements on cardinality checks
2022-01-26 16:13:12 -05:00
05e7c98620
Return an `AccountIdentityResponse` when changing phone numbers
2022-01-26 14:44:53 -05:00
1f1d618dea
Rename `AccountCreationResult` to `AccountIdentityResponse` (since it's not just for account creation any more)
2022-01-26 14:44:53 -05:00
b18117ef89
Add tests for unidentified access when requesting profiles
2022-01-25 14:07:44 -05:00
44cb796574
Add more detail to "could not get acceptable languages" logging
2022-01-25 12:21:35 -05:00
f69db11f42
Drop some unused dynamic configuration properties
2022-01-21 18:46:37 -05:00
96a680dcf0
Remove displaced account from directory when changing numbers
2022-01-21 18:46:11 -05:00
c612663490
Handle `null` `AccountAttributes` when verifying linked devices
2022-01-14 14:47:46 -05:00
de5d967d18
Track metrics for dynamic config load failures
2022-01-14 14:47:12 -05:00
7fc63f7847
Allow callers to specify one or more dynamic config classes
2022-01-14 14:45:29 -05:00
146655e997
Add a "sameAvatar" flag to CreateProfileRequest
...
If sameAvatar is set (and "avatar" is also set), the avatar field for
a profile will be copied from the existing profile. This saves S3
churn and client bandwidth.
2022-01-04 13:57:41 -08:00
bb27dd0c3b
Migrate from `Object[]` parameters to `Stream<Arguments>`
2022-01-03 15:10:02 -08:00
d7a3c12bbe
Drop unused DynamoDB class rules
2022-01-03 15:10:02 -08:00
a1e84f5a88
Migrate service tests to JUnit 5
2022-01-03 15:10:02 -08:00
b758737907
Migrate remaining JUnit 4 Redis cluster tests to `RedisClusterExtension`
...
* Increase redis cluster initialization wait to 10 seconds
* Move to JUnit 5 `Assumptions`
2022-01-03 14:59:39 -08:00
3e777df86c
Timeout `sendNextMessagePage` after 5 minutes
2021-12-20 11:31:11 -08:00
278b4e810d
Add (failing) test for send message timeouts
2021-12-20 11:31:11 -08:00
346c7cd743
Remove null-check of destination UUID
2021-12-20 11:31:11 -08:00
5baa51d547
Migrate challenge-issuing configuration into the abusive message filter module
2021-12-16 12:22:19 -05:00
616db337e1
Remove an old rate limiting feature flag
2021-12-16 12:22:19 -05:00
3895871462
Repair missing PNIs in JSON blobs on account load
2021-12-16 11:17:51 -05:00
a87b84fbe2
Return an empty response if somebody requests a profile key credential with a non-existent version
2021-12-16 10:30:55 -05:00
20c95e2606
Register `ApplicationShutdownMonitor` last
...
This will make it start last and shut down first, which is pretty much what we want for shutdown state monitoring
2021-12-15 19:27:23 -05:00
22dccaeddb
Count cases where we can find a given account, but not the given profile version
2021-12-15 15:53:47 -05:00
e611a70ba4
Remove usernames from profile responses
2021-12-15 15:53:47 -05:00
66845d7080
Refactor: separate the various types of profile responses
2021-12-15 15:53:47 -05:00
4ea7278c6f
Remove unversioned profile properties from `Account` entities
2021-12-15 15:53:47 -05:00
2b2e26f14b
Remove deprecated, unversioned profile setters
2021-12-15 15:53:47 -05:00
b496ef8d6f
Fix an issue where the deleted accounts lock client was trying to talk to the deleted accounts table
2021-12-15 13:16:32 -05:00
2d1ca98605
Consolidate DynamoDB clients/configuration
2021-12-15 12:42:41 -05:00
Ehren Kret