4d1bca2d97
Dispatch client presence operations after account deletion to a dedicated executor
2023-12-21 13:40:49 -05:00
f33a2eba50
Add buffer + shuffle and configurable concurrency to `RemoveExpiredLinkedDevicesCommand`
2023-12-21 11:14:02 -06:00
5d6bea5ec9
Clear Redis cache entries strictly after removing accounts from DynamoDB
2023-12-21 12:08:03 -05:00
057d1f07a8
Remove bulk "set repeated-use signed pre-keys" methods because they were only ever used for single devices
2023-12-21 12:07:42 -05:00
95bb9a9780
Log signed pre-key retrieval errors and mismatches
2023-12-20 14:55:12 -05:00
06c391cbf6
Add counter for failed account updates to RemoveExpiredLinkedDevicesCommand
2023-12-20 13:51:28 -06:00
d90dff95b1
Move MeterRegistry#close calls to after the lifecycle has fully stopped
2023-12-20 13:51:16 -06:00
ca47a7b663
handle new RegistrationService proto error
2023-12-19 18:19:26 -06:00
9d3d4a3698
Add phone-number-sharing field to versioned profile
...
Co-authored-by: Katherine <katherine@signal.org>
2023-12-19 11:20:04 -08:00
3b509bf820
Add command to remove expired linked devices
2023-12-19 13:11:26 -06:00
5b7f91827a
Remove signed pre-keys transactionally when removing devices
2023-12-19 14:11:05 -05:00
06800043a9
Set TLS keystore password in secondary persistent services
2023-12-15 13:39:58 -06:00
3090de56b8
Set TLS keystore password from secrets configuration
2023-12-15 12:47:27 -06:00
a37acd1f42
Add ttl for braintree writes to onetime donation table
2023-12-15 13:37:35 -05:00
43f17414ff
Make key-setting methods asynchronous again
2023-12-14 16:49:16 -08:00
b259eea8ce
Refactor/clarify account creation/reclamation process
2023-12-14 16:48:57 -08:00
9cfc2ba09a
Persist onetime donation payment success timestamps for Braintree transactions
2023-12-14 16:48:29 -08:00
bb347999ce
Propagate another subscription processor error to clients
2023-12-14 15:40:08 -05:00
3548c3df15
Calculate onetime badge expiration from payment success timestamp
2023-12-14 15:39:46 -05:00
1167d0ac2e
Make key-setting methods synchronous
2023-12-13 17:49:55 -05:00
f738bc97e7
Revert "Retire the "migrate signed pre-keys" command"
...
This reverts commit c7cc3002d5
2023-12-13 17:49:55 -05:00
3f9edfe597
Revert "Treat the stand-alone signed pre-keys table as the source of truth for signed pre-keys"
...
This reverts commit feb933b4df
2023-12-13 17:49:55 -05:00
a024949311
Revert "Retire "migrate signed pre-keys" configuration"
...
This reverts commit 44145073f1
2023-12-13 17:49:55 -05:00
609c901867
Refactor key-fetching to be reactive
2023-12-13 12:46:48 -05:00
4ce060a963
Count wildcard "get keys" requests by platform
2023-12-13 12:46:48 -05:00
c4ca0fee40
Synchronize access to `responseItems` when assembling a "get keys" response
2023-12-13 12:46:48 -05:00
8d4acf0330
Remove `ForkJoinPool.managedBlock` in favor of async updates
2023-12-13 10:18:04 -05:00
28a981f29f
Assume that all devices have signed pre-keys
2023-12-13 10:17:51 -05:00
c29113d17a
Reject requests with missing device capabilities
2023-12-12 11:37:44 -05:00
951f978447
Use start of subscription period as fallback timestamp
2023-12-12 11:34:44 -05:00
07899f35bd
Return `DeviceController#linkDevice` to synchronous processing
2023-12-12 11:34:23 -05:00
3cbbf37468
Use payment success timestamp to calculate recurring donation badge expiration
2023-12-12 10:01:20 -05:00
6c7a3df5ae
Retire non-atomic device-linking pathways
2023-12-12 09:53:51 -05:00
2054ab2771
Revert "Count requests with missing device capabilities"
...
This reverts commit 6cdf8ebd2c
2023-12-12 09:53:51 -05:00
44145073f1
Retire "migrate signed pre-keys" configuration
2023-12-12 09:53:34 -05:00
feb933b4df
Treat the stand-alone signed pre-keys table as the source of truth for signed pre-keys
2023-12-11 11:39:54 -05:00
c7cc3002d5
Retire the "migrate signed pre-keys" command
2023-12-11 11:07:00 -05:00
049b901d63
Fix typos
2023-12-09 10:04:12 -05:00
3cf1b92dfc
Do not set one-time pre-keys if the lists of new keys are empty
2023-12-08 14:03:08 -05:00
5b0fcbe854
Always expose sequential fluxes to account crawlers
2023-12-08 13:43:42 -05:00
cca747a1f6
Treat transaction conflicts during transactional account updates as contested optimistic locks
2023-12-08 12:13:23 -05:00
417d99a17e
Check story rate limits in parallel
2023-12-08 12:13:08 -05:00
e9708b9259
Use random UUIDs throughout `MessageControllerTest`
2023-12-08 12:13:08 -05:00
e5d3be16b0
Fetch destination accounts in parallel when sending multi-recipient messages
2023-12-08 12:13:08 -05:00
2ab3c97ee8
Replace MultiRecipientMessage parsing with libsignal's implementation
...
Co-authored-by: Jonathan Klabunde Tomer <jkt@signal.org>
2023-12-08 11:52:47 -05:00
f20d3043d6
Process key migrations sequentially to better control concurrency
2023-12-07 21:42:49 -05:00
4efda89358
multisend cleanup
2023-12-07 12:23:02 -08:00
1fb88271e5
Invalidate cache entries for accounts after successfully adding devices
2023-12-07 13:27:26 -05:00
a843780f68
Add a (failing!) test for device-linking
2023-12-07 13:27:26 -05:00
5ad83da4e0
Remove the now-unused admin logger
2023-12-07 12:58:43 -05:00
50d92265ea
Add devices to accounts transactionally
2023-12-07 11:19:40 -05:00
e084a9f2b6
Remove PUT/DELETE methods from RemoteConfigController
2023-12-07 10:54:19 -05:00
664f9f36e1
Use padded base64 encoding for outbound device names
2023-12-07 10:53:56 -05:00
4c9efdb936
Revert "Revert "Represent device names as byte arrays""
...
This reverts commit 45848e7bfe
2023-12-07 10:53:56 -05:00
45848e7bfe
Revert "Represent device names as byte arrays"
...
This reverts commit 5ae2e5281a
2023-12-06 17:05:04 -05:00
4fa10e5783
Fix NPE in request metrics when a finished request is missing a response
2023-12-06 15:11:41 -05:00
fc0bc85f4d
Add some extra request validation to `/v1/archives/keys`
2023-12-06 15:11:27 -05:00
5ae2e5281a
Represent device names as byte arrays
2023-12-06 15:10:45 -05:00
34a943832a
Align push notification types and delivery priorities
2023-12-06 12:40:16 -05:00
db17693ba7
Revert "Temporarily make registration challenge notifications "noisy""
...
This reverts commit 9069c5abb6
2023-12-06 12:40:16 -05:00
6cdf8ebd2c
Count requests with missing device capabilities
2023-12-06 10:40:50 -05:00
072b470f46
Be more specific about encodings in /v1/archive docs
2023-12-06 10:40:20 -05:00
78b2df2ecc
Use long instead of int for epoch seconds
2023-12-06 10:40:06 -05:00
00e72a30c9
Assume all accounts have primary devices
2023-12-06 10:28:19 -05:00
df421e0182
Update signed pre-keys in transactions
2023-12-05 14:20:16 -05:00
ede9297139
Disallow identity key changes
2023-12-05 14:14:24 -05:00
85383fe581
Remove an unused "store keys" method
2023-12-05 14:14:24 -05:00
4cca7aa4bd
Normalize identity types throughout `KeysController`
2023-12-05 14:14:24 -05:00
e2037dea6c
Rename `PreKeyState` to `SetKeysRequest`
2023-12-05 14:14:24 -05:00
f10f772e94
Convert `PreKeyState` to a record
2023-12-05 14:14:24 -05:00
9ecfe15ac4
Use multiline strings for `PreKeyState` documentation
2023-12-05 14:14:24 -05:00
5f0726af8a
Perform cleanup operations before overwriting an existing account record
2023-12-05 12:18:09 -05:00
331bbdd4e6
replace deprecated apache RandomUtils
2023-12-05 10:48:18 -06:00
37e3bcfc3e
Move "remove device" logic into `AccountsManager`
2023-12-05 11:44:58 -05:00
4f42c10d60
Disallow sync messages to PNIs
2023-12-05 11:44:27 -05:00
20392a567b
Revert "multisend cleanup"
...
This reverts commit c03249b411
2023-12-01 14:39:31 -08:00
c03249b411
multisend cleanup
2023-11-30 15:50:36 -08:00
22e6584402
Add auth controller for SVR3 to /v3/backup.
2023-11-30 15:50:21 -08:00
aa23a5422a
Don't modify registration IDs from the "set account attributes" endpoint
2023-11-29 16:56:47 -05:00
01fde4f9ca
Require PNI-associated registration IDs for new devices
2023-11-29 16:56:47 -05:00
3980dec123
Revert "Add metrics to check presence of PNI-associated registration IDs"
...
This reverts commit 1da3f96d10
2023-11-29 16:56:47 -05:00
c97f837f45
Revert "Instrument registration ID changes via the "set account attributes" endpoint"
...
This reverts commit 8fbc1dac74
2023-11-29 16:56:47 -05:00
9c54d2407b
Update tests
2023-11-29 15:48:24 -06:00
a027c4ce1f
Conditionally use `request.remoteAddr` instead of `X-Forwarded-For`
2023-11-29 15:48:24 -06:00
b1fd025ea6
Use EpochSecondSerializer for UserRemoteConfigList.serverEpochTime
2023-11-29 15:47:10 -06:00
a05a230085
use Account-specific json serializer when reserving username hash
2023-11-29 13:40:06 -08:00
8fbc1dac74
Instrument registration ID changes via the "set account attributes" endpoint
2023-11-29 10:26:41 -05:00
f46842c6c9
Validate registration IDs
2023-11-28 15:43:35 -08:00
202dd8e92d
Add copy endpoint to ArchiveController
...
Co-authored-by: Jonathan Klabunde Tomer <125505367+jkt-signal@users.noreply.github.com>
Co-authored-by: Chris Eager <79161849+eager-signal@users.noreply.github.com>
2023-11-28 11:45:41 -06:00
1da3f96d10
Add metrics to check presence of PNI-associated registration IDs
2023-11-28 12:26:15 -05:00
5f6fe4d670
Add `NoneHealthResponder` to replace default responder
2023-11-27 14:38:47 -06:00
a74438d1ee
Add test for concurrent in-flight outbound messages on WebSocket queue processing
...
This also elevates the implicit default concurrency (via reactor’s `Queues.SMALL_BUFFER_SIZE`) to be explicit.
2023-11-27 14:37:46 -06:00
c8033f875d
Create accounts transactionally
2023-11-27 09:57:43 -05:00
07c04006df
Avoid blocking calls in async account updates
2023-11-27 09:57:43 -05:00
521900c048
Always require atomic account creation
2023-11-27 09:52:57 -05:00
9069c5abb6
Temporarily make registration challenge notifications "noisy"
2023-11-22 10:25:59 -05:00
ff7a5f471b
Always use "conserve power" priority for challenge notifications
2023-11-21 17:58:32 -05:00
42a47406cc
Fix platform tag for push challenge metric
2023-11-21 17:57:32 -05:00
de10b6de7b
Add metric to count invalid registration ID when setting account attributes
2023-11-20 14:25:27 -08:00
d6ade0e1ac
Send HTTP 408 on idle timeout
2023-11-20 16:24:54 -06:00
cb1fc734c2
report exceptions in fanned-out sends of multi-recipient messages
2023-11-20 10:46:26 -08:00
db7f18aae7
Add missing boolean parameter to `getSubscriptionStatus` method call
2023-11-16 19:28:10 -05:00
7fbc327591
For Braintree, return `active` subscription status if latest transaction also succeeded
2023-11-16 19:15:46 -05:00
84b56ae1b2
Upgrade to dropwizard 3.0
2023-11-16 17:57:48 -06:00
041aa8639a
Enforce story ratelimit
2023-11-16 12:36:43 -05:00
216ac72ad0
Use Braintree subscription status alongside transaction status to determine 204 and 402 responses for `/v1/subscription/{subscriberId}/receipt_credentials`
2023-11-16 12:36:19 -05:00
c85ddaeb9c
Make DynamoDB client connection pool sizes configurable
2023-11-16 12:29:43 -05:00
8f7bae54fe
When persisting messages fails due to a full queue in DynamoDB, automatically unlink one device to free up room.
...
Co-authored-by: Chris Eager <79161849+eager-signal@users.noreply.github.com>
2023-11-15 17:15:17 -08:00
ce60f13320
Don't track IPv4/IPv6 metrics at the application level
...
We can measure this at the infrastructure level without observing IPs directly.
2023-11-15 17:18:54 -05:00
1ac0140666
Remove a couple of now-unused variables
2023-11-15 17:12:08 -05:00
6cc8b147a9
Remove unused `X-Forwarded-For` parameters
2023-11-15 17:09:47 -05:00
7764185c57
return explicit Response rather than Void from async controllers with no expected body content
2023-11-14 21:57:25 -08:00
d4ef2adf0a
Remove low priority attempt login notification workaround for old iOS clients
2023-11-13 12:06:55 -05:00
a83378a44e
add an option to replace username ciphertext without rotating the link handle
2023-11-13 09:01:54 -08:00
a4a4204762
Allow re-registered accounts to reclaim their usernames
2023-11-13 10:41:23 -06:00
acd1140ef6
Make registration challenge APNs payloads "silent"
2023-11-13 08:39:58 -08:00
fbf71c93ff
Make rate limit challenge APNs payloads "silent"
2023-11-13 08:39:58 -08:00
38bc0c466a
Change `sepaMaximumEuros` field to number in JSON response
2023-11-10 10:16:03 -08:00
71e4351743
Add `sepaMaximumEuros` field to subscription configuration
2023-11-10 09:13:51 -08:00
387e4b94b4
Expand charge object on Stripe subscription to surface charge failure information
2023-11-10 09:12:59 -08:00
201c76b861
Add charge failure details to `/v1/subscription/{subscriberId}/receipt_credentials` 402 response
2023-11-08 10:54:14 -08:00
db63ff6b88
gRPC validations
2023-11-03 11:30:48 -07:00
115431a486
Un-hardcode payment activation flag
2023-11-03 11:27:34 -07:00
d47ff9b7c7
don't make empty transactions
2023-11-02 16:20:19 -07:00
2bc4412d66
Encapsulate device ID in ProvisioningAddress
2023-11-02 11:48:10 -05:00
6a428b4da9
Convert Device.id from `long` to `byte`
2023-11-02 11:48:10 -05:00
7299067829
Don't attempt to update PNI PQ prekeys for disabled devices
2023-11-01 16:55:55 -07:00
570aa4b9e2
Remove several unused classes
2023-11-01 15:46:10 -05:00
6b38b538f1
Add ArchiveController
...
Adds endpoints for creating and managing backup objects with ZK
anonymous credentials.
2023-10-30 14:02:19 -05:00
ba139dddd8
Use all devices when checking limit
2023-10-30 12:40:06 -05:00
0f5c62ade5
Set max threads = min threads on command executor services
2023-10-27 09:26:32 -05:00
54bc3bce96
Add an authentication-required gRPC service for working with accounts
2023-10-25 14:47:20 -04:00
3d92e5b8a9
Explicitly stop and start managed dependencies
2023-10-24 16:50:02 -04:00
e4de6bf4a7
Only update devices that aren't already disabled
2023-10-24 15:29:03 -04:00
6f166425fe
Fix bank mandate test
2023-10-20 16:19:31 -04:00
cf2353bcf9
Remove InstrumentedExecutorService wrapping
2023-10-20 15:14:35 -05:00
744eb58071
Discard old chunk-based account crawler machinery
2023-10-20 16:09:17 -04:00
9d47a6f41f
Introduce a reactive push notification feedback processor
2023-10-20 16:09:17 -04:00
fd19299ae0
Accept a captcha score threshold for challenges from the spam filter
2023-10-20 09:09:22 -07:00
9c053e20da
Drop `Util#isEmpty`/`Util#nonEmpty` in favor of `StringUtils`
2023-10-20 12:04:15 -04:00
19d7b5c65d
Drop `Util#wait`
2023-10-20 12:04:15 -04:00
7b9d8829da
Remove entirely unused `Util` methods
2023-10-20 12:04:15 -04:00
f0ab52eb5d
Rename "master device" to "primary device"
2023-10-20 10:52:13 -04:00
e8cebad27e
Avoid modifying original `Account` instances when constructing JSON for updates
2023-10-20 10:51:50 -04:00
6441d5838d
Clear username links in the same transaction when clearing username hashes
2023-10-20 10:51:50 -04:00
ac0c8b1e9a
Introduce a canonical constant for UAK length
2023-10-20 10:50:44 -04:00
8ec062fbef
Define an endpoint to set the default payment method for iDEAL subscriptions
2023-10-19 10:29:40 -07:00
5990a100db
Add charge failure details to `/v1/subscription/boost/receipt_credential` 402 response
2023-10-19 10:21:26 -07:00
bc35278684
Drop the old `AccountCleaner`
2023-10-19 10:34:24 -04:00
c3c7329ebb
Add a single-shot command for removing expired accounts
2023-10-19 10:34:24 -04:00
6fd1c84126
Make command namespace available to subclasses
2023-10-19 10:34:24 -04:00
0100f0fcc9
Migrate a username links test from `AccountsTest` to `AccountsManagerUsernameIntegrationTest`
2023-10-18 10:20:48 -04:00
0cdc32cf65
Really REALLY fix instrumentation for re-registration of recently-deleted accounts
2023-10-18 10:15:03 -04:00
601e9eebbd
Implement an anonymous account service for looking up accounts
2023-10-18 10:14:52 -04:00
eaa868cf06
Add a remote address interceptor to base gRPC tests
2023-10-18 10:14:52 -04:00
f55504c665
Add utility methods for rate-limiting by remote address
2023-10-18 10:14:52 -04:00
b2ff016cc1
Add back story ratelimiter with counter but do not enforce
2023-10-17 12:22:17 -04:00
33b4f17945
Make username-related operations asynchronous
2023-10-17 12:21:52 -04:00
e310a3560b
Remove unused configuration for the legacy Secure Backup Service
2023-10-17 12:21:14 -04:00
162b27323e
Fix instrumentation for re-registration of recently-deleted accounts
2023-10-17 12:20:58 -04:00
ae976ef8d6
Retire legacy Secure Value Recovery plumbing
2023-10-13 15:32:41 -04:00
c6b4e2b71d
Support iDEAL
2023-10-12 09:54:05 -07:00
33c8bbd0ce
Trim stale capabilities from the profiles gRPC service
2023-10-12 12:52:32 -04:00
f2a3b8dba4
Treat APNs team/key IDs as secrets so they can change atomically with the key itself
2023-10-12 12:52:13 -04:00
207ae6129b
Add `paymentMethod` and `paymentProcessing` fields to `GET /v1/subscription/{subscriberId}` endpoint
2023-10-10 09:56:50 -07:00
e1aa734c40
Define endpoint to get localized bank mandate text
2023-10-05 09:53:33 -07:00
bb7e0528c4
Make account deletion an asynchronous operation
2023-10-04 10:44:50 -04:00
010eadcd10
UnlinkDeviceCommand improvements
2023-10-03 15:14:02 -07:00
c43e0b54f2
Exclude `SEPA_DEBIT` as a supported payment method for certain iOS client versions
2023-10-03 11:34:52 -07:00
6522b74e20
Remove obsolete metrics
2023-10-03 11:42:25 -05:00
8c7975d89a
Clear presence only if the connection’s displacement listener is still present
2023-10-03 11:42:25 -05:00
407070c9fc
Unsubscribe from keyspace notifications only if queue still maps to the listener
2023-10-03 11:42:25 -05:00
7821a3cd61
Accommodate PayPal with SEPA changes
2023-09-28 10:28:17 -07:00
a00c2fcfdb
Support SEPA
2023-09-28 08:26:01 -07:00
9cd21d1326
count ItemCollectionSizeLimitExceededExceptions persisting messages
2023-09-27 10:58:28 -07:00
aaba95f9b8
return `null` for empty username hash in AccountIdentityResponse
2023-09-27 10:58:04 -07:00
8d1135a2a3
Refine `RegistrationController` logic
...
Local device transfer on iOS uses the `409` status code to prompt the
transfer UI. This needs to happen before sending a `423` and locking
an existing account, since the device transfer
includes the local device database verbatim.
2023-09-25 15:54:31 -05:00
f9fabbedce
Convert `SubscriptionController` request/response entities to records
2023-09-25 12:32:49 -07:00
16012e6ffe
Remove obsolete `ManagedPeriodicWork`
2023-09-25 12:15:17 -07:00
d10a132b0c
Remove unused methods in `SubscriptionController`
2023-09-25 12:14:56 -07:00
0b3af7d824
gRPC API for external services credentials service
2023-09-25 12:14:49 -07:00
d0fdae3df7
Enable header-based auth for WebSocket connections
2023-09-25 12:14:40 -07:00
0e989419c6
Add metric for late removal of message availability and displacement listeners
2023-09-19 12:04:24 -05:00
0fa8276d2d
retry hCaptcha errors
...
Co-authored-by: Jon Chambers <63609320+jon-signal@users.noreply.github.com>
2023-09-14 16:07:35 -05:00
b594986241
Set an idle timeout on registration gRPC client
2023-09-14 16:06:49 -05:00
9f3ffa3707
gRPC API for payments service
2023-09-14 11:12:00 -07:00
8e598c19dc
don't attempt to update KEM prekeys if we have no PQ-enabled devices
2023-09-14 11:11:22 -07:00
2601d6e906
Convert some fields on `CreateProfileRequest` and `VersionedProfileResponse` to byte arrays
2023-09-13 14:00:03 -07:00
f0544fab89
Update recently-deleted accounts table transactionally as part of account mutations
2023-09-13 16:02:19 -04:00
1b9bf01ab1
Absorb `DeletedAccounts` into `Accounts`
2023-09-13 16:02:19 -04:00
cbc3887226
Define identity key check endpoint in keys anonymous service
2023-09-11 11:57:00 -07:00
2b764c2abd
Don't allow callers to unlink their primary device
2023-09-11 14:29:48 -04:00
845fc338d7
Add a (failing) test for removing primary devices from accounts
2023-09-11 14:29:48 -04:00
977243ebfd
DRY gRPC tests, refactor error mapping
2023-09-08 17:12:08 -07:00
29ca544c95
Revert "Set `suppressCancel=true` in `Mono.fromFuture`"
...
This reverts commit 8348263fab
2023-09-07 17:03:33 -05:00
94b41d3a2c
Fixup default rate limits
...
A previous refactor left the default rate limits off by a factor of 60.
2023-09-07 16:07:42 -05:00
92bb783cbb
Use static exception instance when a connection is closed
2023-09-07 16:06:16 -05:00
8348263fab
Set `suppressCancel=true` in `Mono.fromFuture`
2023-09-07 16:06:03 -05:00
5934b7344a
Remove unused captcha configuration
2023-09-07 11:16:32 -05:00
a9a2e40fed
Move `onErrorResume` to individual `sendMessage` `Mono`
2023-09-07 11:15:57 -05:00
Jon Chambers