e944306a28
Remove obsolete dropwizard-db dependency
2024-02-07 14:35:23 -06:00
3b44ed6d16
Explicitly call spam-filter for messages
...
Pass in the same information to the spam-filter, but just use explicit
method calls rather than jersey request filters.
2024-02-07 14:30:32 -06:00
0965ab8063
Move HeaderUtils#getMostRecentyProxy to RemoteAddressFilter
2024-02-07 14:28:37 -06:00
fcae100df1
Add dropwizard-http2 dependency
2024-02-07 14:28:20 -06:00
24a7762873
Add `identityType` tag to `SENT_MESSAGE_COUNTER_NAME`
2024-02-06 17:39:00 -06:00
e441ab60a2
Add metric for IPv4/IPv6 requests count
2024-02-06 17:38:25 -06:00
2ab14ca59e
Refactor remote address/X-Forwarded-For handling
2024-02-05 13:37:06 -06:00
4475d65780
Make Accounts#changeNumber exception handling more resilient to future changes
2024-02-01 15:14:15 -06:00
b1d10f5817
Add lifecycle management for AwsCrt for commands
2024-02-01 15:08:45 -06:00
c838df90ef
Add HttpServletRequestUtil
2024-01-31 17:53:47 -06:00
fb39af67e5
Allow for more TransactWriteItems when inspecting TransactionCanceledException
2024-01-31 17:46:32 -06:00
2d4d37f96a
Translate TransactionCanceledException to ContestedOptimisticLockException in Accounts#changeNumber
2024-01-31 17:27:16 -06:00
84af984c4b
remove unversioned and libsignal-0.36 versioned zk secrets from sample bundle
2024-01-31 15:25:23 -08:00
26adf20ee8
Make "fetch profile" endpoints `@ManagedAsync`
2024-01-31 14:38:50 -06:00
72668ed0a2
Make "send individual message" endpoint `@ManagedAsync`
2024-01-31 14:38:50 -06:00
50f1ed7851
Add a virtual-thread backed `@ManagedAsyncExecutor`
2024-01-31 14:38:50 -06:00
cf8f2a3463
remove synchronized locks that may be held while blocking
2024-01-31 14:29:15 -06:00
b483159b3a
reintroduce VirtualThreadPinEventMonitor
2024-01-31 14:28:12 -06:00
480abebf7e
Offload account lock updates to accountLockExecutor
2024-01-31 14:27:16 -06:00
b924dea045
Remove VirtualThreadPinEventMonitor
2024-01-30 13:49:39 -06:00
2c1e7e5ed6
Disable flaky VirtualThreadPinEventMonitorTest
2024-01-30 13:29:58 -06:00
4dfd74906c
Add timeouts to VirtualThreadPinEventMonitorTest
2024-01-30 13:10:43 -06:00
c80225a18c
Remove `NoneHealthResponder`
2024-01-30 12:51:43 -06:00
0e6242373e
Add a monitor for virtual thread pin events
2024-01-30 12:48:07 -06:00
4305db5579
Update to aws sdk 2.23.8 and use AwsCrtHttpClient
2024-01-30 12:46:27 -06:00
36e7772f74
Put some validation on to profile version strings
...
Co-authored-by: Jon Chambers <63609320+jon-signal@users.noreply.github.com>
2024-01-26 15:24:38 -06:00
ca05df5172
Revert "Add support for secondary credentials for registration service"
...
This reverts commit 4b8fc2950f
2024-01-26 11:42:35 -06:00
422e8e6f3e
Remove CommandStopListener
2024-01-26 11:31:04 -06:00
852b285d84
Configure and instantiate a `ClientPublicKeys` data store/manager
2024-01-26 10:29:59 -05:00
6c13193623
Add a data store for client public keys for transport-level authentication/encryption
2024-01-26 10:29:59 -05:00
6bda9d8604
Set destination account on the request context
2024-01-25 13:02:28 -06:00
1428ca73de
Make identity token fetcher more async friendly
...
After the identity token expires a subsequent call would do a blocking
operation to retrieve the new token. Since we're making use of an async
gRPC client, this tends to block a thread we don't want to be blocking
on.
Instead, switch to periodically refreshing the token on a dedicated
thread.
2024-01-25 13:01:21 -06:00
498ace0488
Remove iOS special case handling logic for SEPA/iDEAL
2024-01-25 10:52:17 -08:00
4b8fc2950f
Add support for secondary credentials for registration service
2024-01-24 13:52:23 -06:00
595cc55578
Retire the `returnPqKey` flag when fetching pre-keys
2024-01-23 16:01:40 -05:00
91b0c368b4
Remove unused table configuration parameter
2024-01-23 14:48:52 -06:00
21d0ffc990
Allow "reserving" one's own committed username hash
2024-01-23 12:44:55 -08:00
55b9d84956
Add `host` to `DogstatsdConfiguration`
2024-01-22 15:59:52 -06:00
ffdb0db6c6
Migrate from `host` tag to `dd.internal.entity_id`
2024-01-22 15:59:52 -06:00
a5ed07a666
Support environment variable substitution in configuration
2024-01-22 11:25:18 -06:00
da02c90bad
Remove AWS instance profile credentials provider
2024-01-22 11:24:03 -06:00
3820a231ec
Strictly enforce ACI service identifier strings have no prefix
2024-01-22 11:23:33 -06:00
408b065b9e
Fix typos
2024-01-20 12:40:08 -05:00
238ab84749
use StandardCharsets UTF_8 instead of String
2024-01-20 12:39:43 -05:00
f5080f9bd6
Support configurable verification code sender overrides
2024-01-19 13:58:17 -06:00
db4aa99ce0
Make the ServiceIdentifier interface sealed
2024-01-19 13:57:20 -06:00
70134507f8
Add metric for ServiceId string parsing
2024-01-19 13:56:47 -06:00
360a4793ae
Remove global lock in RateLimitChallengeManager
2024-01-19 13:56:09 -06:00
47bfb25f2c
Retire a now-unused transacational update method for accounts
2024-01-18 16:40:21 -05:00
b048b0bf65
Remove signed pre-keys from `Device` entities
2024-01-18 12:13:00 -05:00
394f9929ad
limit size of multi-recipient messages
2024-01-11 16:31:37 -08:00
bf39be3320
Add Content-Type header for copy uploads
2024-01-11 14:59:35 -06:00
4a2cbb9ec7
Stop timers on Flux termination
2024-01-11 14:57:31 -06:00
cc6cf8194f
Add media deletion endpoint
2024-01-11 10:19:06 -06:00
e934ead85c
Fix incorrect comparison in archive usage metric
2024-01-11 10:19:06 -06:00
323bfd9a6e
Remove some secondary keys from account cache
...
Remove e164, usernameHash, and usernameLink secondary mappings from the
accounts redis cache.
2024-01-11 10:10:32 -06:00
bf05e47e26
Get accounts asynchronously when checking SVR credentials via gRPC
2024-01-11 11:09:49 -05:00
d18f576239
Revert "Revert "Treat the stand-alone signed pre-keys table as the source of truth for signed pre-keys""
...
This reverts commit 3f9edfe597
2024-01-10 11:22:10 -05:00
7d483c711a
Revert "Revert "Retire "migrate signed pre-keys" configuration""
...
This reverts commit a024949311
2024-01-10 11:22:10 -05:00
61256d49cd
Revert "Revert "Retire the "migrate signed pre-keys" command""
...
This reverts commit f738bc97e7
2024-01-10 11:22:10 -05:00
184cdc0331
Remove two-stage check of username availability in reserve/confirm
2024-01-09 14:01:42 -08:00
ed972a0037
Fix archive listing directory prefix order
2024-01-09 16:01:11 -06:00
a62a6c1cb6
Change type of Cdn3StorageManagerConfiguration.clientSecret to SecretString
2024-01-08 16:06:54 -06:00
f66566aa17
Fix default configuratiton in MonitoredS3ObjectConfiguration
2024-01-08 14:52:14 -06:00
b6ecfc7131
Add archive listing
2024-01-08 13:54:57 -06:00
2b688b1a60
Refactor spam filter's S3MonitoredObject to server parent module.
...
Allows other parts of server to use S3MonitoredObjects.
2024-01-08 10:34:12 -08:00
3c64d9292f
Revert "Expand the default max packet size for Dogstatsd"
...
This reverts commit 0f52d2e464
2024-01-08 12:23:16 -05:00
0f52d2e464
Expand the default max packet size for Dogstatsd
2024-01-08 11:43:50 -05:00
1e5fadc440
Allow reserving a hash previously reserved (but not committed) by the same user
2024-01-05 15:38:45 -08:00
f495ff483a
Update RemoveExpiredLinkedDevicesCommand to retry failures
2024-01-05 15:38:34 -08:00
d1a80cc880
fix build-breaking typo
2024-01-04 11:46:07 -08:00
e1ad25cee0
Group Send Credential support in chat
2024-01-04 11:38:57 -08:00
195f23c347
Add `/v1/accounts` and `/v2/keys` to the WebSocket
2024-01-02 15:51:57 -06:00
ad6b99be6a
Dispatch client presence operations after device deletion to a dedicated executor
2023-12-22 10:51:17 -06:00
b9dd9fc47d
Reduce fan-out by processing a single stream of expired linked devices
2023-12-22 10:51:06 -06:00
637792c6d4
Move `RemoveExpiredLinkedDevicesCommand` error handling for more accurate metrics
2023-12-21 16:06:41 -06:00
4d1bca2d97
Dispatch client presence operations after account deletion to a dedicated executor
2023-12-21 13:40:49 -05:00
f33a2eba50
Add buffer + shuffle and configurable concurrency to `RemoveExpiredLinkedDevicesCommand`
2023-12-21 11:14:02 -06:00
5d6bea5ec9
Clear Redis cache entries strictly after removing accounts from DynamoDB
2023-12-21 12:08:03 -05:00
057d1f07a8
Remove bulk "set repeated-use signed pre-keys" methods because they were only ever used for single devices
2023-12-21 12:07:42 -05:00
95bb9a9780
Log signed pre-key retrieval errors and mismatches
2023-12-20 14:55:12 -05:00
06c391cbf6
Add counter for failed account updates to RemoveExpiredLinkedDevicesCommand
2023-12-20 13:51:28 -06:00
d90dff95b1
Move MeterRegistry#close calls to after the lifecycle has fully stopped
2023-12-20 13:51:16 -06:00
ca47a7b663
handle new RegistrationService proto error
2023-12-19 18:19:26 -06:00
9d3d4a3698
Add phone-number-sharing field to versioned profile
...
Co-authored-by: Katherine <katherine@signal.org>
2023-12-19 11:20:04 -08:00
3b509bf820
Add command to remove expired linked devices
2023-12-19 13:11:26 -06:00
5b7f91827a
Remove signed pre-keys transactionally when removing devices
2023-12-19 14:11:05 -05:00
06800043a9
Set TLS keystore password in secondary persistent services
2023-12-15 13:39:58 -06:00
3090de56b8
Set TLS keystore password from secrets configuration
2023-12-15 12:47:27 -06:00
a37acd1f42
Add ttl for braintree writes to onetime donation table
2023-12-15 13:37:35 -05:00
e9a130f976
add versioned zkconfig secrets to sample secrets bundle
2023-12-14 17:38:49 -08:00
43f17414ff
Make key-setting methods asynchronous again
2023-12-14 16:49:16 -08:00
b259eea8ce
Refactor/clarify account creation/reclamation process
2023-12-14 16:48:57 -08:00
9cfc2ba09a
Persist onetime donation payment success timestamps for Braintree transactions
2023-12-14 16:48:29 -08:00
bb347999ce
Propagate another subscription processor error to clients
2023-12-14 15:40:08 -05:00
3548c3df15
Calculate onetime badge expiration from payment success timestamp
2023-12-14 15:39:46 -05:00
1167d0ac2e
Make key-setting methods synchronous
2023-12-13 17:49:55 -05:00
f738bc97e7
Revert "Retire the "migrate signed pre-keys" command"
...
This reverts commit c7cc3002d5
2023-12-13 17:49:55 -05:00
3f9edfe597
Revert "Treat the stand-alone signed pre-keys table as the source of truth for signed pre-keys"
...
This reverts commit feb933b4df
2023-12-13 17:49:55 -05:00
a024949311
Revert "Retire "migrate signed pre-keys" configuration"
...
This reverts commit 44145073f1
2023-12-13 17:49:55 -05:00
609c901867
Refactor key-fetching to be reactive
2023-12-13 12:46:48 -05:00
4ce060a963
Count wildcard "get keys" requests by platform
2023-12-13 12:46:48 -05:00
c4ca0fee40
Synchronize access to `responseItems` when assembling a "get keys" response
2023-12-13 12:46:48 -05:00
8d4acf0330
Remove `ForkJoinPool.managedBlock` in favor of async updates
2023-12-13 10:18:04 -05:00
28a981f29f
Assume that all devices have signed pre-keys
2023-12-13 10:17:51 -05:00
c29113d17a
Reject requests with missing device capabilities
2023-12-12 11:37:44 -05:00
951f978447
Use start of subscription period as fallback timestamp
2023-12-12 11:34:44 -05:00
07899f35bd
Return `DeviceController#linkDevice` to synchronous processing
2023-12-12 11:34:23 -05:00
3cbbf37468
Use payment success timestamp to calculate recurring donation badge expiration
2023-12-12 10:01:20 -05:00
6c7a3df5ae
Retire non-atomic device-linking pathways
2023-12-12 09:53:51 -05:00
2054ab2771
Revert "Count requests with missing device capabilities"
...
This reverts commit 6cdf8ebd2c
2023-12-12 09:53:51 -05:00
44145073f1
Retire "migrate signed pre-keys" configuration
2023-12-12 09:53:34 -05:00
feb933b4df
Treat the stand-alone signed pre-keys table as the source of truth for signed pre-keys
2023-12-11 11:39:54 -05:00
c7cc3002d5
Retire the "migrate signed pre-keys" command
2023-12-11 11:07:00 -05:00
049b901d63
Fix typos
2023-12-09 10:04:12 -05:00
3cf1b92dfc
Do not set one-time pre-keys if the lists of new keys are empty
2023-12-08 14:03:08 -05:00
5b0fcbe854
Always expose sequential fluxes to account crawlers
2023-12-08 13:43:42 -05:00
cca747a1f6
Treat transaction conflicts during transactional account updates as contested optimistic locks
2023-12-08 12:13:23 -05:00
417d99a17e
Check story rate limits in parallel
2023-12-08 12:13:08 -05:00
e9708b9259
Use random UUIDs throughout `MessageControllerTest`
2023-12-08 12:13:08 -05:00
e5d3be16b0
Fetch destination accounts in parallel when sending multi-recipient messages
2023-12-08 12:13:08 -05:00
2ab3c97ee8
Replace MultiRecipientMessage parsing with libsignal's implementation
...
Co-authored-by: Jonathan Klabunde Tomer <jkt@signal.org>
2023-12-08 11:52:47 -05:00
f20d3043d6
Process key migrations sequentially to better control concurrency
2023-12-07 21:42:49 -05:00
4efda89358
multisend cleanup
2023-12-07 12:23:02 -08:00
1fb88271e5
Invalidate cache entries for accounts after successfully adding devices
2023-12-07 13:27:26 -05:00
a843780f68
Add a (failing!) test for device-linking
2023-12-07 13:27:26 -05:00
5ad83da4e0
Remove the now-unused admin logger
2023-12-07 12:58:43 -05:00
50d92265ea
Add devices to accounts transactionally
2023-12-07 11:19:40 -05:00
e084a9f2b6
Remove PUT/DELETE methods from RemoteConfigController
2023-12-07 10:54:19 -05:00
664f9f36e1
Use padded base64 encoding for outbound device names
2023-12-07 10:53:56 -05:00
4c9efdb936
Revert "Revert "Represent device names as byte arrays""
...
This reverts commit 45848e7bfe
2023-12-07 10:53:56 -05:00
45848e7bfe
Revert "Represent device names as byte arrays"
...
This reverts commit 5ae2e5281a
2023-12-06 17:05:04 -05:00
4fa10e5783
Fix NPE in request metrics when a finished request is missing a response
2023-12-06 15:11:41 -05:00
fc0bc85f4d
Add some extra request validation to `/v1/archives/keys`
2023-12-06 15:11:27 -05:00
5ae2e5281a
Represent device names as byte arrays
2023-12-06 15:10:45 -05:00
34a943832a
Align push notification types and delivery priorities
2023-12-06 12:40:16 -05:00
db17693ba7
Revert "Temporarily make registration challenge notifications "noisy""
...
This reverts commit 9069c5abb6
2023-12-06 12:40:16 -05:00
6cdf8ebd2c
Count requests with missing device capabilities
2023-12-06 10:40:50 -05:00
072b470f46
Be more specific about encodings in /v1/archive docs
2023-12-06 10:40:20 -05:00
78b2df2ecc
Use long instead of int for epoch seconds
2023-12-06 10:40:06 -05:00
00e72a30c9
Assume all accounts have primary devices
2023-12-06 10:28:19 -05:00
df421e0182
Update signed pre-keys in transactions
2023-12-05 14:20:16 -05:00
ede9297139
Disallow identity key changes
2023-12-05 14:14:24 -05:00
85383fe581
Remove an unused "store keys" method
2023-12-05 14:14:24 -05:00
4cca7aa4bd
Normalize identity types throughout `KeysController`
2023-12-05 14:14:24 -05:00
e2037dea6c
Rename `PreKeyState` to `SetKeysRequest`
2023-12-05 14:14:24 -05:00
f10f772e94
Convert `PreKeyState` to a record
2023-12-05 14:14:24 -05:00
9ecfe15ac4
Use multiline strings for `PreKeyState` documentation
2023-12-05 14:14:24 -05:00
5f0726af8a
Perform cleanup operations before overwriting an existing account record
2023-12-05 12:18:09 -05:00
331bbdd4e6
replace deprecated apache RandomUtils
2023-12-05 10:48:18 -06:00
37e3bcfc3e
Move "remove device" logic into `AccountsManager`
2023-12-05 11:44:58 -05:00
4f42c10d60
Disallow sync messages to PNIs
2023-12-05 11:44:27 -05:00
20392a567b
Revert "multisend cleanup"
...
This reverts commit c03249b411
2023-12-01 14:39:31 -08:00
c03249b411
multisend cleanup
2023-11-30 15:50:36 -08:00
22e6584402
Add auth controller for SVR3 to /v3/backup.
2023-11-30 15:50:21 -08:00
aa23a5422a
Don't modify registration IDs from the "set account attributes" endpoint
2023-11-29 16:56:47 -05:00
01fde4f9ca
Require PNI-associated registration IDs for new devices
2023-11-29 16:56:47 -05:00
3980dec123
Revert "Add metrics to check presence of PNI-associated registration IDs"
...
This reverts commit 1da3f96d10
2023-11-29 16:56:47 -05:00
c97f837f45
Revert "Instrument registration ID changes via the "set account attributes" endpoint"
...
This reverts commit 8fbc1dac74
2023-11-29 16:56:47 -05:00
9c54d2407b
Update tests
2023-11-29 15:48:24 -06:00
a027c4ce1f
Conditionally use `request.remoteAddr` instead of `X-Forwarded-For`
2023-11-29 15:48:24 -06:00
b1fd025ea6
Use EpochSecondSerializer for UserRemoteConfigList.serverEpochTime
2023-11-29 15:47:10 -06:00
a05a230085
use Account-specific json serializer when reserving username hash
2023-11-29 13:40:06 -08:00
8fbc1dac74
Instrument registration ID changes via the "set account attributes" endpoint
2023-11-29 10:26:41 -05:00
f46842c6c9
Validate registration IDs
2023-11-28 15:43:35 -08:00
202dd8e92d
Add copy endpoint to ArchiveController
...
Co-authored-by: Jonathan Klabunde Tomer <125505367+jkt-signal@users.noreply.github.com>
Co-authored-by: Chris Eager <79161849+eager-signal@users.noreply.github.com>
2023-11-28 11:45:41 -06:00
1da3f96d10
Add metrics to check presence of PNI-associated registration IDs
2023-11-28 12:26:15 -05:00
5f6fe4d670
Add `NoneHealthResponder` to replace default responder
2023-11-27 14:38:47 -06:00
a74438d1ee
Add test for concurrent in-flight outbound messages on WebSocket queue processing
...
This also elevates the implicit default concurrency (via reactor’s `Queues.SMALL_BUFFER_SIZE`) to be explicit.
2023-11-27 14:37:46 -06:00
c8033f875d
Create accounts transactionally
2023-11-27 09:57:43 -05:00
07c04006df
Avoid blocking calls in async account updates
2023-11-27 09:57:43 -05:00
521900c048
Always require atomic account creation
2023-11-27 09:52:57 -05:00
9069c5abb6
Temporarily make registration challenge notifications "noisy"
2023-11-22 10:25:59 -05:00
ff7a5f471b
Always use "conserve power" priority for challenge notifications
2023-11-21 17:58:32 -05:00
42a47406cc
Fix platform tag for push challenge metric
2023-11-21 17:57:32 -05:00
de10b6de7b
Add metric to count invalid registration ID when setting account attributes
2023-11-20 14:25:27 -08:00
d6ade0e1ac
Send HTTP 408 on idle timeout
2023-11-20 16:24:54 -06:00
cb1fc734c2
report exceptions in fanned-out sends of multi-recipient messages
2023-11-20 10:46:26 -08:00
db7f18aae7
Add missing boolean parameter to `getSubscriptionStatus` method call
2023-11-16 19:28:10 -05:00
7fbc327591
For Braintree, return `active` subscription status if latest transaction also succeeded
2023-11-16 19:15:46 -05:00
84b56ae1b2
Upgrade to dropwizard 3.0
2023-11-16 17:57:48 -06:00
041aa8639a
Enforce story ratelimit
2023-11-16 12:36:43 -05:00
216ac72ad0
Use Braintree subscription status alongside transaction status to determine 204 and 402 responses for `/v1/subscription/{subscriberId}/receipt_credentials`
2023-11-16 12:36:19 -05:00
c85ddaeb9c
Make DynamoDB client connection pool sizes configurable
2023-11-16 12:29:43 -05:00
8f7bae54fe
When persisting messages fails due to a full queue in DynamoDB, automatically unlink one device to free up room.
...
Co-authored-by: Chris Eager <79161849+eager-signal@users.noreply.github.com>
2023-11-15 17:15:17 -08:00
ce60f13320
Don't track IPv4/IPv6 metrics at the application level
...
We can measure this at the infrastructure level without observing IPs directly.
2023-11-15 17:18:54 -05:00
1ac0140666
Remove a couple of now-unused variables
2023-11-15 17:12:08 -05:00
6cc8b147a9
Remove unused `X-Forwarded-For` parameters
2023-11-15 17:09:47 -05:00
7764185c57
return explicit Response rather than Void from async controllers with no expected body content
2023-11-14 21:57:25 -08:00
d4ef2adf0a
Remove low priority attempt login notification workaround for old iOS clients
2023-11-13 12:06:55 -05:00
a83378a44e
add an option to replace username ciphertext without rotating the link handle
2023-11-13 09:01:54 -08:00
a4a4204762
Allow re-registered accounts to reclaim their usernames
2023-11-13 10:41:23 -06:00
acd1140ef6
Make registration challenge APNs payloads "silent"
2023-11-13 08:39:58 -08:00
fbf71c93ff
Make rate limit challenge APNs payloads "silent"
2023-11-13 08:39:58 -08:00
38bc0c466a
Change `sepaMaximumEuros` field to number in JSON response
2023-11-10 10:16:03 -08:00
71e4351743
Add `sepaMaximumEuros` field to subscription configuration
2023-11-10 09:13:51 -08:00
387e4b94b4
Expand charge object on Stripe subscription to surface charge failure information
2023-11-10 09:12:59 -08:00
201c76b861
Add charge failure details to `/v1/subscription/{subscriberId}/receipt_credentials` 402 response
2023-11-08 10:54:14 -08:00
db63ff6b88
gRPC validations
2023-11-03 11:30:48 -07:00
115431a486
Un-hardcode payment activation flag
2023-11-03 11:27:34 -07:00
Chris Eager