411087ff1a
Add a testcase with real libsignal User Agent
2024-05-07 14:51:01 -04:00
10bb2a6a10
Add finer grain rollouts to experiments
2024-05-06 13:28:32 -05:00
7aff81547a
Manage some unmanaged executors
2024-05-06 13:25:18 -05:00
fc097db2a0
Use storage-manager's copy implementation
2024-05-06 13:15:42 -05:00
843151859d
Adding hostname property to cloudflare turn config
2024-05-02 12:35:32 -07:00
854ab353b3
calling: update TurnCallRouter to shuffle instance IPs to prevent allocation skew
...
Co-authored-by: Jonathan Klabunde Tomer <125505367+jkt-signal@users.noreply.github.com>
2024-05-02 12:34:34 -07:00
cf307db31d
Update JsonMappingExceptionMapper “Early EOF” logic
2024-05-01 10:31:11 -05:00
567c368a81
Add DiscoverableSubtypeResolver to static YAML_MAPPER
2024-05-01 10:21:55 -05:00
223b2fc263
Add javax.validation.Validator to SpamFilter#configure
2024-05-01 10:21:55 -05:00
4a28ab6317
Add support to trial Cloudflare TURN beta
2024-05-01 10:15:01 -05:00
37aa3b8e49
Default to 0 `usedBytes` in `GET /v1/archives`
2024-05-01 10:10:46 -05:00
0e4be0c85a
Add tests for `WhisperServerService#run`
...
Additionally, `LocalWhisperServerService` may be used for integration testing.
2024-04-29 11:05:35 -05:00
9d3e3c7312
Use a common utility for turning Google API futures into `CompletableFutures`
2024-04-26 15:27:59 -04:00
88e2687e23
Add a check for missing uak in `OptionalAccess`
2024-04-26 15:24:54 -04:00
19944bfdb2
Update to libsignal 0.45 and use libsignal's BackupLevel
2024-04-25 16:54:41 -05:00
c8efcf5105
Don't map a `Mono<Void>`
2024-04-25 16:47:34 -05:00
7f6da52349
Publish donation events for immediately-successful donations
2024-04-24 13:16:37 -04:00
8999f0104f
Trigger pub/sub events for one-time donations via Braintree (PayPal)
2024-04-24 09:19:21 -04:00
516c481e94
Pass a `CurrencyConversionManager` to `BraintreeManager`
2024-04-24 09:19:21 -04:00
f0dcd8e07b
Group Send Endorsement support for unversioned profile fetch
2024-04-23 14:58:19 -07:00
9ef1fee172
Add DELETE `v1/archives`
2024-04-23 16:50:11 -05:00
b3bd4ccc17
simplify profile auth
2024-04-23 14:49:04 -07:00
fba7686390
Remove `shard` tag from Lettuce circuit breaker metrics
2024-04-23 16:00:46 -05:00
2d314e5309
Minor: Return exception instead of throwing it in .orElseThrow()
...
Gets rid of an IntelliJ warning about it. No difference in behavior, there is
a test that already covers this path.
2024-04-22 09:32:12 -04:00
ed72d7f9ec
Attach client platforms when creating donations
2024-04-22 09:31:57 -04:00
b8f64fe3d4
Group Send Endorsement support for pre-key fetch endpoint
2024-04-19 15:40:46 -07:00
ab64828661
Update custom Gauges to Micrometer MeterBinders
2024-04-17 17:43:34 -05:00
a38bf25e68
Migrate remaining custom metrics from Dropwizard to Micrometer
...
And remove some that are obsolete or duplicative.
2024-04-17 15:35:04 -05:00
ada589d0c3
accept Group Send Endorsements for single-recipient message send
...
Co-authored-by: Jon Chambers <63609320+jon-signal@users.noreply.github.com>
2024-04-16 15:06:40 -07:00
a302275187
Use a single cluster instance in MessagesCache
2024-04-16 12:04:18 -05:00
b734d58ab7
Coalesce all Redis clusters to per-shard circuit breakers
2024-04-16 12:04:18 -05:00
2046b02bd8
Rename `RedeemReceiptRequest` to help openapi
2024-04-16 11:16:18 -05:00
1df824db7c
Remap some JsonMappingExceptions to 408 and 400
2024-04-15 16:01:09 -05:00
9cad2c6b7d
Improve test Redis cluster setup and teardown
2024-04-15 15:58:23 -05:00
00ca7d5942
Add cdn number query parameter to `/archives/auth/read`
2024-04-15 13:59:14 -05:00
d36df3eaa9
Add new upload-for-copy backup endpoint
2024-04-15 13:47:46 -05:00
e5d654f0c7
Add `/v1/archives/redeem-receipt`
2024-04-15 13:47:02 -05:00
fc1f471369
Use per-shard circuit breakers for additional Redis clusters
2024-04-15 13:45:24 -05:00
2dc707d86e
Add per-shard Redis circuit breakers
2024-04-12 11:22:41 -05:00
05a92494bb
Remove X-Forwarded-For from RemoteAddressFilter
2024-04-11 11:03:37 -05:00
39fd955f13
Allow clients to request zkc-based auth creds
...
Allow clients to pass a zkcCredential=true query parameter to request the new
auth credential format implemented with the zkcredential Rust library.
2024-04-11 11:00:10 -05:00
4863e1d227
Add backup levels to subscription configuration response
2024-04-11 10:58:40 -05:00
2b652fe2a9
accept group send endorsements for multi-recipient sends
2024-04-10 16:51:09 -07:00
cdd2082b07
Decrease logging level in RemoveExpiredBackupsCommand
2024-04-10 18:41:29 -05:00
5b97bc04e0
Add ExternalRequestFilter
2024-04-04 16:24:20 -05:00
63c8b275d1
Return 401 instead of 404 on unknown backup-ids
2024-04-04 10:56:48 -05:00
1ebc17352f
Check presentation before verifying the signature
2024-04-04 10:56:48 -05:00
268c8382ee
Fix Backup expiration purge time
2024-04-04 10:55:55 -05:00
498dcbbfe8
Make media encrypter stream ordered
...
Co-authored-by: Chris Eager <79161849+eager-signal@users.noreply.github.com>
2024-04-04 10:53:45 -05:00
3a1ecb342f
allow striping clients in FaultTolerantHttpClient
2024-04-04 10:47:34 -05:00
bb0da69c9e
Set the shutdown gauge earlier in the shutdown process
...
Co-authored-by: Chris Eager <79161849+eager-signal@users.noreply.github.com>
2024-04-02 09:39:55 -05:00
796dce3cd3
Always use the "peek" strategy for counting one-time pre-keys
2024-04-02 10:31:20 -04:00
f59c34004d
De-idiom-ize a "wait for everything to finish" idiom
2024-04-02 10:30:44 -04:00
d002e5dda8
Hardcode `paymentActivation` flag to `true`
2024-04-01 15:07:11 -07:00
89cb821c97
Remove vavr dependency
2024-04-01 17:06:55 -05:00
fcc77052a6
Add org.eclipse.jetty.io.EofException to expected measureSendMessageErrors
2024-04-01 17:06:29 -05:00
831c9ff5bf
Make backupDir/mediaDir indirect
2024-04-01 13:45:21 -05:00
de37141812
Add a crawler that expires old backups
2024-04-01 13:45:21 -05:00
a550caf63f
Make sure we close the HTTP/2 stream after cdn read errors
2024-03-27 17:00:37 -05:00
de9eaa98db
404 instead of 400 on unknown source cdn
2024-03-27 17:00:37 -05:00
37b657cbbd
avoid baos::writeTo on virtual threads
2024-03-27 16:58:38 -05:00
a733f5c615
Add debugging context to signature validation failures
2024-03-27 17:58:02 -04:00
8a587d1d12
Rename `NoiseStreamHandler` to `NoiseTransportHandler` for consistency with Noise specification terminology
2024-03-27 17:57:46 -04:00
75bb22f08b
Include HTTP2ServerConnectionFactory in JettyHttpConfigurationCustomizer
2024-03-27 16:56:19 -05:00
d10da39e5b
Pare back debug-oriented metrics around fetching pre-keys
2024-03-26 16:44:34 -04:00
54e9b839bd
update TurnTokenGenerator to add whether this is with ip or url turn allocation
2024-03-26 13:40:53 -07:00
aec6ac019f
Introduce a Noise-over-WebSocket client connection manager
2024-03-22 15:20:55 -04:00
075a08884b
Preserve backupCredentialRequest across rereg
2024-03-22 14:19:35 -05:00
6fcb2ab5dd
Remove username phased rollout plumbing (usernames are now available to everybody)
2024-03-21 13:42:20 -04:00
7f0f045f29
Minor cleanup of report spam endpoint ( #1979 )
2024-03-21 10:41:25 -07:00
e7d1eadf8e
Fix experiments in BackupAuthManager
2024-03-20 11:43:07 -05:00
9df6e19204
Ignored EofException response failure in MetricsHttpChannelListener
2024-03-18 17:38:19 -05:00
5eaae184c9
Set request failure to debug in MetricsHttpChannelListener
2024-03-18 17:38:19 -05:00
459882e6fa
Add JettyHttpConfigurationCustomizer
2024-03-18 17:38:19 -05:00
2c2b5d555e
Rename obsolete uses of recaptcha
2024-03-13 16:40:32 -05:00
0ab2428d87
Don't produce zkgroup auth creds with PNI as ACI
2024-03-13 16:22:45 -05:00
8574494573
Support "captcha" rename in AnswerChallengeRequest.type
2024-03-13 16:19:05 -05:00
a4d4a9c686
Remove RecaptchaClient
2024-03-13 16:19:05 -05:00
fd9eb462cc
Replace extraneous SecureRandom with empty byte array
2024-03-12 16:49:57 -05:00
f9533e016f
Adjust metrics in RemoveExpiredUsernameHoldsCommand
2024-03-11 13:50:08 -05:00
85b15fa63b
Actually increment the "get group credentials" counter
2024-03-08 17:07:16 -05:00
3dadaf9334
Migrate DynamicConfigurationManager to use java.util.concurrent
2024-03-08 13:53:28 -06:00
9e510a678c
disable response buffering on the websocket
...
Jersey buffers responses (by default up to 8192 bytes) just so it can
add a content length to responses. We already buffer our responses to
serialize them as protos, so we can compute the content length
ourselves. Setting the buffer to zero disables buffering.
2024-03-08 13:46:00 -06:00
2dc0ea2b89
Address potential NullPointerException when calling Collection#contains
2024-03-08 13:43:31 -06:00
7d364ca7ce
Count group auth reqs without pniAsServiceId=true
2024-03-06 15:41:48 -05:00
9f6a6d7f5b
Include HTTP/2 stream idle timeouts in IOExceptionMapper
2024-03-06 11:11:39 -06:00
3cc740cda3
Temporarily hold a username after an account releases it
2024-03-06 11:09:25 -06:00
47b24b5dff
Simplify username operations in `Accounts`
...
- Group username table constants together
- Rethrow JsonProcessingException earlier
- Use UpdateAccountSpec.forAccount in username operations
- Inline confirm/clear transaction helpers
2024-03-06 11:09:25 -06:00
8f100a792e
calling: update TurnCallRouter to reduce returned options
2024-03-05 11:26:19 -08:00
4e5dd914dd
Add varargs variant to HmacUtil
2024-02-28 15:18:39 -06:00
2adf1e5017
Avoid modification of Account from `@ReadOnly` endpoint
2024-02-28 15:18:12 -06:00
d1d03f45c5
Resolve warnings throughout `AccountControllerTest`
2024-02-26 16:11:03 -05:00
436bd891bd
Don't register SpamFilter as a request filter
2024-02-26 09:33:36 -06:00
a7c28fe5ed
Rename "name" tags to be more distinguishing
2024-02-26 09:32:50 -06:00
60814d1ff0
Configure metrics registries earlier in background command setup
2024-02-26 09:32:01 -06:00
d018efe2a5
Require non-null proofs in "confirm username hash" requests
2024-02-26 10:30:52 -05:00
6fd0cba06a
Temporarily restore the `giftBadges` capability for backward compatibility
2024-02-26 10:30:29 -05:00
12c6af23ee
Map TransactionConflict to ContestedOptimisticLockException in username flows
2024-02-23 14:06:03 -08:00
69330f47fd
Explicitly call spam-filter for verification session updates
...
Pass in the same information to the spam-filter, but just use explicit
method calls rather than jersey request filters.
2024-02-23 16:04:24 -06:00
4f40c128bf
Explicitly call spam-filter for challenges
...
Pass in the same information to the spam-filter, but just use explicit
method calls rather than jersey request filters.
2024-02-23 15:58:52 -06:00
30b5ad1515
Fix an incorrectly-named "check keys" method
2024-02-23 13:17:10 -05:00
665a26d164
update call routing to return ipv6 ips in RFC3986 format
2024-02-23 11:57:58 -05:00
a5774bf6ff
Introduce a (dormant) Noise/WebSocket for future client/server communication
2024-02-23 11:42:42 -05:00
d2716fe5cf
Add an endpoint for checking that clients and the server have a common view of the client's repeated-use keys
2024-02-23 11:41:58 -05:00
279f877bf2
Validate pre-key signatures via the legacy "set signed pre-key" endpoint
2024-02-23 11:33:41 -05:00
df69d9f195
Annotate authenticated endpoints with `@ReadOnly` or `@Mutable`
2024-02-22 12:05:32 -06:00
26ffa19f36
Lifecycle management for Account objects reused accross websocket requests
2024-02-22 12:05:32 -06:00
29ef3f0b41
Add tests and metrics for parsing invalid keys
2024-02-21 15:32:25 -05:00
106d5e54c7
Extract a common base class for public key serializers/deserializers
2024-02-21 15:32:25 -05:00
6ac2460eb0
Drop the "key without version byte" counter
2024-02-21 15:32:25 -05:00
c8d649e8c2
Update MetricsHttpChannelListener to share MetricsRequestEventListener namespace
2024-02-21 13:32:47 -06:00
1fdf82dd6c
Remove unused ChangePhoneNumberRequest object
...
Actual request object is ChangeNumberRequest
2024-02-21 13:32:27 -06:00
4aa4246695
Clear account records from the account cache after username operations
2024-02-20 12:11:29 -05:00
1bebceb29c
Actually fix flaky test in MetricsHttpChannelListenerIntegrationTest
2024-02-20 10:52:04 -06:00
a2139ee236
Revert "Add diagnostic dimensions to the "get keys" counter"
...
This reverts commit cd64390141
2024-02-18 20:14:05 -05:00
8c55f39cdf
Revert "Use a phased enrollment strategy for the `pnp` compatibility flag"
...
This reverts commit 3e12a8780d
2024-02-18 20:08:39 -05:00
0329184c94
Fix flaky test in MetricsHttpChannelListenerIntegrationTest
2024-02-18 20:08:29 -05:00
cd64390141
Add diagnostic dimensions to the "get keys" counter
2024-02-18 18:10:58 -05:00
3e12a8780d
Use a phased enrollment strategy for the `pnp` compatibility flag
2024-02-18 17:59:00 -05:00
11e6ff1bbe
Introduce a `pnp` capability for backward compatibility
2024-02-18 17:59:00 -05:00
36f85fc97e
Fix an inverted boolean in a counter
2024-02-16 15:18:18 -05:00
9040cfd200
Count "store key" attempts by key type/platform
2024-02-16 13:09:55 -05:00
757da3b15a
Fully-qualify OpenAPI `Tag`, allowing for imported Micrometer `Tag`
2024-02-16 13:09:55 -05:00
d162590a32
Record a remote-aggregated distribution of one-time pre-key counts
2024-02-16 13:09:55 -05:00
f41e1716c6
Combine/expand existing "get keys" counter
2024-02-16 13:09:55 -05:00
4dce0f1b9d
Add identity type/"stale" dimensions to the "pre-key unavailable" counter
2024-02-16 13:09:55 -05:00
fef57dce0d
use explicit `Timer` rather than micrometer annotation for send-message latency distribution
2024-02-15 14:58:43 -08:00
d884700b61
Significantly reduce default Redis command timeout
2024-02-15 17:57:17 -05:00
ff9ad4bd1d
export 1:1 message send latency as a full distribution
2024-02-15 10:33:02 -08:00
9ce2b7555c
Add static servlet paths to MetricsHttpChannelListener
2024-02-14 17:09:30 -06:00
f90ccd3391
Count attempts to fetch a one-time EC pre-key that result in a "key unavailable" response
2024-02-14 18:04:31 -05:00
5ff092e541
Retire the `pni` device capability
2024-02-14 18:04:23 -05:00
dcdf401f64
Make DELETE /v1/device synchronous
2024-02-14 15:30:10 -05:00
e4fb80b39b
Add onResponseFailure handler to MetricsHttpChannelListener
2024-02-14 13:43:23 -06:00
9745854ab8
Switch MetricsHttpChannelListener to ContainerResponseFilter
2024-02-14 13:43:23 -06:00
7124621f66
Use pre-calculated pre-key counts when possible
2024-02-14 14:28:33 -05:00
47fd8f5793
Assume that all devices are PNI-capable
2024-02-14 14:27:48 -05:00
40d698f2db
Remove last vestiges of stale capabilities.
...
Not for deployment until 2024-02-06!
2024-02-14 14:23:05 -05:00
74abe98706
initialize call routing data syncs
2024-02-13 17:05:08 -08:00
86787f3bc8
Start DynamicConfigurationManager directly after construction
2024-02-13 13:08:20 -06:00
699b0c775a
Add dynamic configuration to enable detailed Lettuce metrics
2024-02-13 10:33:43 -06:00
ff59ef8094
Add MetricHttpChannelListener
2024-02-13 10:29:03 -06:00
089af7cc1f
correct metric name in MaxMindDatabaseManager timer
2024-02-09 13:37:39 -08:00
1591a2d9a3
CallRoutingTableManager: fix crash on startup due to typo in metric naming
2024-02-09 12:27:51 -08:00
f7984ed642
CallDnsRecordsManager: fix crash on startup due to typo in metric naming
2024-02-09 12:14:50 -08:00
d1f68eacd9
Add call routing API endpoint for turn servers
2024-02-09 11:12:23 -08:00
4f45f23094
Prevent old versions of the Android app from carrying out "change phone number" requests
2024-02-09 09:58:38 -05:00
c5dc01ee11
Restore high-cardinality Lettuce metrics for debugging
2024-02-08 19:27:56 -05:00
3b44ed6d16
Explicitly call spam-filter for messages
...
Pass in the same information to the spam-filter, but just use explicit
method calls rather than jersey request filters.
2024-02-07 14:30:32 -06:00
0965ab8063
Move HeaderUtils#getMostRecentyProxy to RemoteAddressFilter
2024-02-07 14:28:37 -06:00
24a7762873
Add `identityType` tag to `SENT_MESSAGE_COUNTER_NAME`
2024-02-06 17:39:00 -06:00
e441ab60a2
Add metric for IPv4/IPv6 requests count
2024-02-06 17:38:25 -06:00
2ab14ca59e
Refactor remote address/X-Forwarded-For handling
2024-02-05 13:37:06 -06:00
4475d65780
Make Accounts#changeNumber exception handling more resilient to future changes
2024-02-01 15:14:15 -06:00
b1d10f5817
Add lifecycle management for AwsCrt for commands
2024-02-01 15:08:45 -06:00
c838df90ef
Add HttpServletRequestUtil
2024-01-31 17:53:47 -06:00
fb39af67e5
Allow for more TransactWriteItems when inspecting TransactionCanceledException
2024-01-31 17:46:32 -06:00
2d4d37f96a
Translate TransactionCanceledException to ContestedOptimisticLockException in Accounts#changeNumber
2024-01-31 17:27:16 -06:00
26adf20ee8
Make "fetch profile" endpoints `@ManagedAsync`
2024-01-31 14:38:50 -06:00
72668ed0a2
Make "send individual message" endpoint `@ManagedAsync`
2024-01-31 14:38:50 -06:00
50f1ed7851
Add a virtual-thread backed `@ManagedAsyncExecutor`
2024-01-31 14:38:50 -06:00
cf8f2a3463
remove synchronized locks that may be held while blocking
2024-01-31 14:29:15 -06:00
b483159b3a
reintroduce VirtualThreadPinEventMonitor
2024-01-31 14:28:12 -06:00
480abebf7e
Offload account lock updates to accountLockExecutor
2024-01-31 14:27:16 -06:00
b924dea045
Remove VirtualThreadPinEventMonitor
2024-01-30 13:49:39 -06:00
2c1e7e5ed6
Disable flaky VirtualThreadPinEventMonitorTest
2024-01-30 13:29:58 -06:00
4dfd74906c
Add timeouts to VirtualThreadPinEventMonitorTest
2024-01-30 13:10:43 -06:00
c80225a18c
Remove `NoneHealthResponder`
2024-01-30 12:51:43 -06:00
0e6242373e
Add a monitor for virtual thread pin events
2024-01-30 12:48:07 -06:00
4305db5579
Update to aws sdk 2.23.8 and use AwsCrtHttpClient
2024-01-30 12:46:27 -06:00
36e7772f74
Put some validation on to profile version strings
...
Co-authored-by: Jon Chambers <63609320+jon-signal@users.noreply.github.com>
2024-01-26 15:24:38 -06:00
ca05df5172
Revert "Add support for secondary credentials for registration service"
...
This reverts commit 4b8fc2950f
2024-01-26 11:42:35 -06:00
422e8e6f3e
Remove CommandStopListener
2024-01-26 11:31:04 -06:00
852b285d84
Configure and instantiate a `ClientPublicKeys` data store/manager
2024-01-26 10:29:59 -05:00
6c13193623
Add a data store for client public keys for transport-level authentication/encryption
2024-01-26 10:29:59 -05:00
6bda9d8604
Set destination account on the request context
2024-01-25 13:02:28 -06:00
1428ca73de
Make identity token fetcher more async friendly
...
After the identity token expires a subsequent call would do a blocking
operation to retrieve the new token. Since we're making use of an async
gRPC client, this tends to block a thread we don't want to be blocking
on.
Instead, switch to periodically refreshing the token on a dedicated
thread.
2024-01-25 13:01:21 -06:00
498ace0488
Remove iOS special case handling logic for SEPA/iDEAL
2024-01-25 10:52:17 -08:00
4b8fc2950f
Add support for secondary credentials for registration service
2024-01-24 13:52:23 -06:00
595cc55578
Retire the `returnPqKey` flag when fetching pre-keys
2024-01-23 16:01:40 -05:00
91b0c368b4
Remove unused table configuration parameter
2024-01-23 14:48:52 -06:00
21d0ffc990
Allow "reserving" one's own committed username hash
2024-01-23 12:44:55 -08:00
55b9d84956
Add `host` to `DogstatsdConfiguration`
2024-01-22 15:59:52 -06:00
ffdb0db6c6
Migrate from `host` tag to `dd.internal.entity_id`
2024-01-22 15:59:52 -06:00
a5ed07a666
Support environment variable substitution in configuration
2024-01-22 11:25:18 -06:00
da02c90bad
Remove AWS instance profile credentials provider
2024-01-22 11:24:03 -06:00
3820a231ec
Strictly enforce ACI service identifier strings have no prefix
2024-01-22 11:23:33 -06:00
408b065b9e
Fix typos
2024-01-20 12:40:08 -05:00
238ab84749
use StandardCharsets UTF_8 instead of String
2024-01-20 12:39:43 -05:00
f5080f9bd6
Support configurable verification code sender overrides
2024-01-19 13:58:17 -06:00
db4aa99ce0
Make the ServiceIdentifier interface sealed
2024-01-19 13:57:20 -06:00
70134507f8
Add metric for ServiceId string parsing
2024-01-19 13:56:47 -06:00
360a4793ae
Remove global lock in RateLimitChallengeManager
2024-01-19 13:56:09 -06:00
47bfb25f2c
Retire a now-unused transacational update method for accounts
2024-01-18 16:40:21 -05:00
b048b0bf65
Remove signed pre-keys from `Device` entities
2024-01-18 12:13:00 -05:00
394f9929ad
limit size of multi-recipient messages
2024-01-11 16:31:37 -08:00
bf39be3320
Add Content-Type header for copy uploads
2024-01-11 14:59:35 -06:00
4a2cbb9ec7
Stop timers on Flux termination
2024-01-11 14:57:31 -06:00
cc6cf8194f
Add media deletion endpoint
2024-01-11 10:19:06 -06:00
e934ead85c
Fix incorrect comparison in archive usage metric
2024-01-11 10:19:06 -06:00
Max Moiseev