From ed8a1ed579b4eb7fab13ef68aa888afb8ced7952 Mon Sep 17 00:00:00 2001 From: Jon Chambers Date: Wed, 26 Jul 2023 12:30:30 -0400 Subject: [PATCH] Restore max concurrency when migrating pre-keys --- .../workers/MigrateSignedECPreKeysCommand.java | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/service/src/main/java/org/whispersystems/textsecuregcm/workers/MigrateSignedECPreKeysCommand.java b/service/src/main/java/org/whispersystems/textsecuregcm/workers/MigrateSignedECPreKeysCommand.java index d525933fe..45c96dac1 100644 --- a/service/src/main/java/org/whispersystems/textsecuregcm/workers/MigrateSignedECPreKeysCommand.java +++ b/service/src/main/java/org/whispersystems/textsecuregcm/workers/MigrateSignedECPreKeysCommand.java @@ -26,9 +26,11 @@ public class MigrateSignedECPreKeysCommand extends AbstractSinglePassCrawlAccoun private static final String STORE_KEY_ATTEMPT_COUNTER_NAME = MetricsUtil.name(MigrateSignedECPreKeysCommand.class, "storeKeyAttempt"); - // It's tricky to find, but the default connection count for the AWS SDK's async DynamoDB client is 50. We expect - // four workers, so this should keep us below the concurrency limit. - private static final int MAX_CONCURRENCY = 12; + // It's tricky to find, but this is the default connection count for the AWS SDK's async DynamoDB client. We'll have + // multiple workers using the max number of connections, but that's okay because the client allows for (by default) + // 10,000 pending requests. As long as we don't have more than 200(!) workers, we'll be fine with this concurrency + // level. + private static final int MAX_CONCURRENCY = 50; public MigrateSignedECPreKeysCommand() { super("migrate-signed-ec-pre-keys", "Migrate signed EC pre-keys from Account records to a dedicated table");