Tag captcha success rate counter by country

This commit is contained in:
Jon Chambers 2022-03-01 18:03:34 -05:00 committed by ravi-signal
parent 75854e104e
commit e8835da740
1 changed files with 2 additions and 1 deletions

View File

@ -682,6 +682,7 @@ public class AccountController {
Optional<String> pushChallenge, Optional<String> pushChallenge,
String userAgent) String userAgent)
{ {
final String countryCode = Util.getCountryCode(number);
if (captchaToken.isPresent()) { if (captchaToken.isPresent()) {
boolean validToken = recaptchaClient.verify(captchaToken.get(), sourceHost); boolean validToken = recaptchaClient.verify(captchaToken.get(), sourceHost);
@ -690,6 +691,7 @@ public class AccountController {
final List<Tag> tags = new ArrayList<>(); final List<Tag> tags = new ArrayList<>();
tags.add(Tag.of("success", String.valueOf(validToken))); tags.add(Tag.of("success", String.valueOf(validToken)));
tags.add(UserAgentTagUtil.getPlatformTag(userAgent)); tags.add(UserAgentTagUtil.getPlatformTag(userAgent));
tags.add(Tag.of(COUNTRY_CODE_TAG_NAME, countryCode));
Metrics.counter(CAPTCHA_ATTEMPT_COUNTER_NAME, tags).increment(); Metrics.counter(CAPTCHA_ATTEMPT_COUNTER_NAME, tags).increment();
} }
@ -700,7 +702,6 @@ public class AccountController {
} }
} }
final String countryCode = Util.getCountryCode(number);
{ {
final List<Tag> tags = new ArrayList<>(); final List<Tag> tags = new ArrayList<>();
tags.add(Tag.of(COUNTRY_CODE_TAG_NAME, countryCode)); tags.add(Tag.of(COUNTRY_CODE_TAG_NAME, countryCode));