MirrorMirror
/
Signal-Server
mirror of https://github.com/signalapp/Signal-Server.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Return 400 if a client specifies paypal where it's not supported

This commit is contained in:
Ravi Khadiwala 2024-08-14 16:10:10 -05:00 committed by ravi-signal
parent 2aa1eee29d
commit e5fdab1bc8
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
service/src/main/java/org/whispersystems/textsecuregcm/controllers/SubscriptionController.java
View File

@ -253,6 +253,10 @@ public class SubscriptionController {
SubscriberCredentials subscriberCredentials = SubscriberCredentials subscriberCredentials =
SubscriberCredentials.process(authenticatedAccount, subscriberId, clock); SubscriberCredentials.process(authenticatedAccount, subscriberId, clock);
if (paymentMethodType == PaymentMethod.PAYPAL) {
throw new BadRequestException("The PAYPAL payment type must use create_payment_method/paypal");
}
final SubscriptionPaymentProcessor subscriptionPaymentProcessor = getManagerForPaymentMethod(paymentMethodType); final SubscriptionPaymentProcessor subscriptionPaymentProcessor = getManagerForPaymentMethod(paymentMethodType);
return subscriptionManager.addPaymentMethodToCustomer( return subscriptionManager.addPaymentMethodToCustomer(
@ -301,7 +305,10 @@ public class SubscriptionController {
private SubscriptionPaymentProcessor getManagerForPaymentMethod(PaymentMethod paymentMethod) { private SubscriptionPaymentProcessor getManagerForPaymentMethod(PaymentMethod paymentMethod) {
return switch (paymentMethod) { return switch (paymentMethod) {
// Today, we always choose stripe to process non-paypal payment types, however we could use braintree to process
// other types (like CARD) in the future.
case CARD, SEPA_DEBIT, IDEAL -> stripeManager; case CARD, SEPA_DEBIT, IDEAL -> stripeManager;
// PAYPAL payments can only be processed with braintree
case PAYPAL -> braintreeManager; case PAYPAL -> braintreeManager;
case UNKNOWN -> throw new BadRequestException("Invalid payment method"); case UNKNOWN -> throw new BadRequestException("Invalid payment method");
}; };