diff --git a/service/src/main/java/org/whispersystems/textsecuregcm/websocket/AuthenticatedConnectListener.java b/service/src/main/java/org/whispersystems/textsecuregcm/websocket/AuthenticatedConnectListener.java index b64f6b0ab..fccf265b6 100644 --- a/service/src/main/java/org/whispersystems/textsecuregcm/websocket/AuthenticatedConnectListener.java +++ b/service/src/main/java/org/whispersystems/textsecuregcm/websocket/AuthenticatedConnectListener.java @@ -1,11 +1,9 @@ package org.whispersystems.textsecuregcm.websocket; import com.codahale.metrics.Counter; -import com.codahale.metrics.Meter; import com.codahale.metrics.MetricRegistry; import com.codahale.metrics.SharedMetricRegistries; import com.codahale.metrics.Timer; -import com.google.protobuf.ByteString; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.whispersystems.textsecuregcm.push.ApnFallbackManager; @@ -17,7 +15,6 @@ import org.whispersystems.textsecuregcm.storage.Account; import org.whispersystems.textsecuregcm.storage.Device; import org.whispersystems.textsecuregcm.storage.MessagesManager; import org.whispersystems.textsecuregcm.storage.PubSubManager; -import org.whispersystems.textsecuregcm.storage.PubSubProtos.PubSubMessage; import org.whispersystems.textsecuregcm.util.Constants; import org.whispersystems.websocket.session.WebSocketSessionContext; import org.whispersystems.websocket.setup.WebSocketConnectListener; @@ -67,16 +64,12 @@ public class AuthenticatedConnectListener implements WebSocketConnectListener { final WebSocketConnection connection = new WebSocketConnection(pushSender, receiptSender, messagesManager, account, device, context.getClient(), connectionId); - final PubSubMessage connectMessage = PubSubMessage.newBuilder().setType(PubSubMessage.Type.CONNECTED) - .setContent(ByteString.copyFrom(connectionId.getBytes())) - .build(); openWebsocketCounter.inc(); RedisOperation.unchecked(() -> apnFallbackManager.cancel(account, device)); clientPresenceManager.setPresent(account.getUuid(), device.getId(), connection); messagesManager.addMessageAvailabilityListener(account.getUuid(), device.getId(), connection); - pubSubManager.publish(address, connectMessage); pubSubManager.subscribe(address, connection); context.addListener(new WebSocketSessionContext.WebSocketEventListener() { diff --git a/service/src/main/java/org/whispersystems/textsecuregcm/websocket/WebSocketConnection.java b/service/src/main/java/org/whispersystems/textsecuregcm/websocket/WebSocketConnection.java index 7054187a0..b11401317 100644 --- a/service/src/main/java/org/whispersystems/textsecuregcm/websocket/WebSocketConnection.java +++ b/service/src/main/java/org/whispersystems/textsecuregcm/websocket/WebSocketConnection.java @@ -45,7 +45,6 @@ public class WebSocketConnection implements DispatchChannel, MessageAvailability private static final MetricRegistry metricRegistry = SharedMetricRegistries.getOrCreate(Constants.METRICS_NAME); public static final Histogram messageTime = metricRegistry.histogram(name(MessageController.class, "message_delivery_duration")); private static final Meter sendMessageMeter = metricRegistry.meter(name(WebSocketConnection.class, "send_message")); - private static final Meter pubSubDisplacementMeter = metricRegistry.meter(name(WebSocketConnection.class, "pubSubDisplacement")); private static final Meter messageAvailableMeter = metricRegistry.meter(name(WebSocketConnection.class, "messagesAvailable")); private static final Meter messagesPersistedMeter = metricRegistry.meter(name(WebSocketConnection.class, "messagesPersisted")); private static final Meter pubSubNewMessageMeter = metricRegistry.meter(name(WebSocketConnection.class, "pubSubNewMessage")); @@ -94,12 +93,6 @@ public class WebSocketConnection implements DispatchChannel, MessageAvailability pubSubNewMessageMeter.mark(); sendMessage(Envelope.parseFrom(pubSubMessage.getContent()), Optional.empty(), false); break; - case PubSubMessage.Type.CONNECTED_VALUE: - if (pubSubMessage.hasContent() && !new String(pubSubMessage.getContent().toByteArray()).equals(connectionId)) { - pubSubDisplacementMeter.mark(); - client.hardDisconnectQuietly(); - } - break; default: logger.warn("Unknown pubsub message: " + pubSubMessage.getType().getNumber()); }