MirrorMirror
/
Signal-Server
mirror of https://github.com/signalapp/Signal-Server.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Only wrap Base64 decode with the exception catch

This commit is contained in:
Ehren Kret 2022-06-20 09:42:33 -05:00
parent 51f37350eb
commit d31550d444
1 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
service/src/main/java/org/whispersystems/textsecuregcm/controllers/ProfileController.java
View File

@ -371,10 +371,15 @@ public class ProfileController {
}); });
} }
private void checkFingerprintAndAdd(BatchIdentityCheckRequest.Element element, Collection<BatchIdentityCheckResponse.Element> responseElements, MessageDigest md) { private void checkFingerprintAndAdd(BatchIdentityCheckRequest.Element element,
Collection<BatchIdentityCheckResponse.Element> responseElements, MessageDigest md) {
accountsManager.getByAccountIdentifier(element.aci()).ifPresent(account -> { accountsManager.getByAccountIdentifier(element.aci()).ifPresent(account -> {
byte[] identityKeyBytes;
try { try {
byte[] identityKeyBytes = Base64.getDecoder().decode(account.getIdentityKey()); identityKeyBytes = Base64.getDecoder().decode(account.getIdentityKey());
} catch (IllegalArgumentException ignored) {
return;
}
md.reset(); md.reset();
byte[] digest = md.digest(identityKeyBytes); byte[] digest = md.digest(identityKeyBytes);
byte[] fingerprint = Util.truncate(digest, 4); byte[] fingerprint = Util.truncate(digest, 4);
@ -382,8 +387,6 @@ public class ProfileController {
if (!Arrays.equals(fingerprint, element.fingerprint())) { if (!Arrays.equals(fingerprint, element.fingerprint())) {
responseElements.add(new BatchIdentityCheckResponse.Element(element.aci(), identityKeyBytes)); responseElements.add(new BatchIdentityCheckResponse.Element(element.aci(), identityKeyBytes));
} }
} catch (IllegalArgumentException ignored) {
}
}); });
} }