diff --git a/src/main/java/org/whispersystems/textsecuregcm/controllers/MessageController.java b/src/main/java/org/whispersystems/textsecuregcm/controllers/MessageController.java index 0c7b958c8..9f4b62b88 100644 --- a/src/main/java/org/whispersystems/textsecuregcm/controllers/MessageController.java +++ b/src/main/java/org/whispersystems/textsecuregcm/controllers/MessageController.java @@ -104,19 +104,19 @@ public class MessageController extends HttpServlet { rateLimiters.getMessagesLimiter().validate(sender.getNumber()); - Map, Device> accountCache = new HashMap<>(); + Map, Device> deviceCache = new HashMap<>(); List numbersMissingDevices = new LinkedList<>(); List incomingMessages = messages.getMessages(); List outgoingMessages = getOutgoingMessageSignals(sender.getNumber(), incomingMessages, - accountCache, + deviceCache, numbersMissingDevices); IterablePair listPair = new IterablePair<>(incomingMessages, outgoingMessages); - handleAsyncDelivery(timerContext, req.startAsync(), listPair, accountCache, numbersMissingDevices); + handleAsyncDelivery(timerContext, req.startAsync(), listPair, deviceCache, numbersMissingDevices); } catch (AuthenticationException e) { failureMeter.mark(); timerContext.stop(); @@ -140,7 +140,7 @@ public class MessageController extends HttpServlet { private void handleAsyncDelivery(final TimerContext timerContext, final AsyncContext context, final IterablePair listPair, - final Map, Device> accountCache, + final Map, Device> deviceCache, final List numbersMissingDevices) { executor.submit(new Runnable() { @@ -159,7 +159,7 @@ public class MessageController extends HttpServlet { if (Util.isEmpty(relay)) { try { - pushSender.sendMessage(accountCache.get(new Pair<>(destination, destinationDeviceId)), messagePair.second()); + pushSender.sendMessage(deviceCache.get(new Pair<>(destination, destinationDeviceId)), messagePair.second()); } catch (NoSuchUserException e) { logger.debug("No such user", e); failure.add(destination); @@ -218,12 +218,12 @@ public class MessageController extends HttpServlet { } /** - * @param accountCache is a map from Pair to the account + * @param deviceCache is a map from Pair to the account */ @Nullable private List getOutgoingMessageSignals(String sourceNumber, List incomingMessages, - Map, Device> accountCache, + Map, Device> deviceCache, List numbersMissingDevices) { List outgoingMessages = new LinkedList<>(); @@ -238,7 +238,7 @@ public class MessageController extends HttpServlet { deviceIds.second().add(incoming.getDestinationDeviceId()); } - pushSender.fillLocalAccountsCache(destinations, accountCache, numbersMissingDevices); + pushSender.fillLocalAccountsCache(destinations, deviceCache, numbersMissingDevices); for (IncomingMessage incoming : incomingMessages) { OutgoingMessageSignal.Builder outgoingMessage = OutgoingMessageSignal.newBuilder();