MirrorMirror
/
Signal-Server
mirror of https://github.com/signalapp/Signal-Server.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Restore high-cardinality Lettuce metrics for debugging

This commit is contained in:
Jon Chambers 2024-02-08 19:17:42 -05:00 committed by Jon Chambers
parent 587c385936
commit c5dc01ee11
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
service/src/main/java/org/whispersystems/textsecuregcm/metrics/MetricsUtil.java
View File

@ -76,7 +76,7 @@ public class MetricsUtil {
return defaultDistributionStatisticConfig.merge(config); return defaultDistributionStatisticConfig.merge(config);
} }
}) })
// Remove high-cardinality `command` and `remote` tags from Lettuce metrics and prepend "chat." to meter names // Remove high-cardinality `command` tags from Lettuce metrics and prepend "chat." to meter names
.meterFilter(new MeterFilter() { .meterFilter(new MeterFilter() {
@Override @Override
public Meter.Id map(final Meter.Id id) { public Meter.Id map(final Meter.Id id) {
@ -84,7 +84,6 @@ public class MetricsUtil {
return id.withName(PREFIX + "." + id.getName()) return id.withName(PREFIX + "." + id.getName())
.replaceTags(id.getTags().stream() .replaceTags(id.getTags().stream()
.filter(tag -> !"command".equals(tag.getKey())) .filter(tag -> !"command".equals(tag.getKey()))
.filter(tag -> !"remote".equals(tag.getKey()))
.toList()); .toList());
} }

1
service/src/test/java/org/whispersystems/textsecuregcm/metrics/MetricsUtilTest.java
View File

@ -37,7 +37,6 @@ class MetricsUtilTest {
Meter meter = meters.get(0); Meter meter = meters.get(0);
assertThat(meter.getId().getName()).isEqualTo("chat.lettuce.command.completion.max"); assertThat(meter.getId().getName()).isEqualTo("chat.lettuce.command.completion.max");
assertThat(meter.getId().getTag("command")).isNull(); assertThat(meter.getId().getTag("command")).isNull();
assertThat(meter.getId().getTag("remote")).isNull();
assertThat(meter.getId().getTag("allowed")).isNotNull(); assertThat(meter.getId().getTag("allowed")).isNotNull();
} }
} }