Make sure to close scheduled reporters.

This commit is contained in:
Jon Chambers 2020-10-09 16:12:09 -04:00 committed by Jon Chambers
parent 81cfa5891c
commit ac2ff29288
2 changed files with 8 additions and 2 deletions

View File

@ -18,6 +18,7 @@ package org.whispersystems.textsecuregcm.storage;
import com.codahale.metrics.Gauge; import com.codahale.metrics.Gauge;
import com.codahale.metrics.MetricRegistry; import com.codahale.metrics.MetricRegistry;
import com.codahale.metrics.ScheduledReporter;
import com.fasterxml.jackson.core.JsonProcessingException; import com.fasterxml.jackson.core.JsonProcessingException;
import com.fasterxml.jackson.databind.ObjectMapper; import com.fasterxml.jackson.databind.ObjectMapper;
import io.dropwizard.metrics.MetricsFactory; import io.dropwizard.metrics.MetricsFactory;
@ -91,7 +92,9 @@ public class ActiveUserCounter extends AccountDatabaseCrawlerListener {
} }
for (ReporterFactory reporterFactory : metricsFactory.getReporters()) { for (ReporterFactory reporterFactory : metricsFactory.getReporters()) {
reporterFactory.build(metrics).report(); try (final ScheduledReporter reporter = reporterFactory.build(metrics)) {
reporter.report();
}
} }
} }

View File

@ -1,6 +1,7 @@
package org.whispersystems.textsecuregcm.storage; package org.whispersystems.textsecuregcm.storage;
import com.codahale.metrics.MetricRegistry; import com.codahale.metrics.MetricRegistry;
import com.codahale.metrics.ScheduledReporter;
import io.dropwizard.metrics.MetricsFactory; import io.dropwizard.metrics.MetricsFactory;
import io.dropwizard.metrics.ReporterFactory; import io.dropwizard.metrics.ReporterFactory;
import io.lettuce.core.KeyValue; import io.lettuce.core.KeyValue;
@ -82,7 +83,9 @@ public class RegistrationLockVersionCounter extends AccountDatabaseCrawlerListen
} }
for (final ReporterFactory reporterFactory : metricsFactory.getReporters()) { for (final ReporterFactory reporterFactory : metricsFactory.getReporters()) {
reporterFactory.build(metricRegistry).report(); try (final ScheduledReporter reporter = reporterFactory.build(metricRegistry)) {
reporter.report();
}
} }
} }
} }