MirrorMirror
/
Signal-Server
mirror of https://github.com/signalapp/Signal-Server.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove `FullTreeHead` from `TreeSearchResponse`

This commit is contained in:
Katherine 2024-10-31 10:51:22 -04:00 committed by GitHub
parent 3bb1eab48c
commit 9b5a62e60f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 5 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
service/src/main/proto/KeyTransparencyService.proto
View File

@ -79,8 +79,6 @@ message E164SearchRequest {
/** /**
* SearchResponse contains search proofs for each of the requested identifiers. * SearchResponse contains search proofs for each of the requested identifiers.
* Callers should use the top-level `FullTreeHead` for verification;
* the `FullTreeHead` field on the individual `TreeSearchResponse`s will be empty.
*/ */
message SearchResponse { message SearchResponse {
/** /**
@ -143,9 +141,7 @@ message DistinguishedRequest {
/** /**
* DistinguishedResponse contains the tree head and search proof for the most * DistinguishedResponse contains the tree head and search proof for the most
* recent `distinguished` key in the log. Callers should use the top-level * recent `distinguished` key in the log.
* `FullTreeHead` for verification; the `FullTreeHead` field on
* `TreeSearchResponse` will be empty.
*/ */
message DistinguishedResponse { message DistinguishedResponse {
/** /**
@ -160,30 +156,25 @@ message DistinguishedResponse {
} }
message TreeSearchResponse { message TreeSearchResponse {
/**
* A signed representation of the log tree's current state along with some
* additional information necessary for validation such as a consistency proof and an auditor-signed tree head.
*/
FullTreeHead tree_head = 1;
/** /**
* A proof that is combined with the original requested identifier and the VRF public key * A proof that is combined with the original requested identifier and the VRF public key
* and outputs whether the proof is valid, and if so, the commitment index. * and outputs whether the proof is valid, and if so, the commitment index.
*/ */
bytes vrf_proof = 2; bytes vrf_proof = 1;
/** /**
* A proof that the binary search for the given identifier was done correctly. * A proof that the binary search for the given identifier was done correctly.
*/ */
SearchProof search = 3; SearchProof search = 2;
/** /**
* A 32-byte value computed based on the log position of the identifier * A 32-byte value computed based on the log position of the identifier
* and a random 32 byte key that is only known by the key transparency service. * and a random 32 byte key that is only known by the key transparency service.
* It is provided so that clients can recompute and verify the commitment. * It is provided so that clients can recompute and verify the commitment.
*/ */
bytes opening = 4; bytes opening = 3;
/** /**
* The new or updated value that the identifier maps to. * The new or updated value that the identifier maps to.
*/ */
UpdateValue value = 5; UpdateValue value = 4;
} }
message FullTreeHead { message FullTreeHead {

1
service/src/test/java/org/whispersystems/textsecuregcm/controllers/KeyTransparencyControllerTest.java
View File

@ -141,7 +141,6 @@ public class KeyTransparencyControllerTest {
void searchSuccess(final Optional<String> e164, final Optional<byte[]> usernameHash) { void searchSuccess(final Optional<String> e164, final Optional<byte[]> usernameHash) {
final TreeSearchResponse aciSearchResponse = TreeSearchResponse.newBuilder() final TreeSearchResponse aciSearchResponse = TreeSearchResponse.newBuilder()
.setOpening(ByteString.copyFrom(TestRandomUtil.nextBytes(16))) .setOpening(ByteString.copyFrom(TestRandomUtil.nextBytes(16)))
.setTreeHead(FullTreeHead.getDefaultInstance())
.setSearch(SearchProof.getDefaultInstance()) .setSearch(SearchProof.getDefaultInstance())
.setValue(UpdateValue.newBuilder() .setValue(UpdateValue.newBuilder()
.setValue(ByteString.copyFrom(TestRandomUtil.nextBytes(16))) .setValue(ByteString.copyFrom(TestRandomUtil.nextBytes(16)))