From 85e4de693300c75c6f85e15607a62d4b942071c9 Mon Sep 17 00:00:00 2001 From: Chris Eager Date: Mon, 17 May 2021 10:39:39 -0500 Subject: [PATCH] Switch platform value from `null` to "unrecognized" in metrics --- .../textsecuregcm/limits/PushChallengeManager.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/service/src/main/java/org/whispersystems/textsecuregcm/limits/PushChallengeManager.java b/service/src/main/java/org/whispersystems/textsecuregcm/limits/PushChallengeManager.java index 57affa08f..a34f0fd64 100644 --- a/service/src/main/java/org/whispersystems/textsecuregcm/limits/PushChallengeManager.java +++ b/service/src/main/java/org/whispersystems/textsecuregcm/limits/PushChallengeManager.java @@ -5,7 +5,12 @@ package org.whispersystems.textsecuregcm.limits; +import static com.codahale.metrics.MetricRegistry.name; + import io.micrometer.core.instrument.Metrics; +import java.security.SecureRandom; +import java.time.Duration; +import java.util.Optional; import org.apache.commons.codec.DecoderException; import org.apache.commons.codec.binary.Hex; import org.apache.commons.lang3.StringUtils; @@ -19,11 +24,6 @@ import org.whispersystems.textsecuregcm.storage.Account; import org.whispersystems.textsecuregcm.storage.Device; import org.whispersystems.textsecuregcm.storage.PushChallengeDynamoDb; import org.whispersystems.textsecuregcm.util.ua.ClientPlatform; -import java.security.SecureRandom; -import java.time.Duration; -import java.util.Optional; - -import static com.codahale.metrics.MetricRegistry.name; public class PushChallengeManager { private final APNSender apnSender; @@ -79,7 +79,7 @@ public class PushChallengeManager { } } else { sent = false; - platform = null; + platform = "unrecognized"; } Metrics.counter(CHALLENGE_REQUESTED_COUNTER_NAME,